[INFO] crate brainpreter 0.1.0 is already in cache [INFO] extracting crate brainpreter 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/brainpreter/0.1.0 [INFO] extracting crate brainpreter 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brainpreter/0.1.0 [INFO] validating manifest of brainpreter-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brainpreter-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brainpreter-0.1.0 [INFO] finished frobbing brainpreter-0.1.0 [INFO] frobbed toml for brainpreter-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/brainpreter/0.1.0/Cargo.toml [INFO] started frobbing brainpreter-0.1.0 [INFO] finished frobbing brainpreter-0.1.0 [INFO] frobbed toml for brainpreter-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brainpreter/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brainpreter-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brainpreter/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 54556a988226dc62ca41a3fe8946214f1294fe2d3ed2fa377c33db3ce6bc7868 [INFO] running `"docker" "start" "-a" "54556a988226dc62ca41a3fe8946214f1294fe2d3ed2fa377c33db3ce6bc7868"` [INFO] [stderr] Checking brainpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/program.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / return match self.instr.pop() { [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | Some(_) => { [INFO] [stderr] 110 | | [INFO] [stderr] ... | [INFO] [stderr] 122 | | [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 107 | match self.instr.pop() { [INFO] [stderr] 108 | [INFO] [stderr] 109 | Some(_) => { [INFO] [stderr] 110 | [INFO] [stderr] 111 | if self.ptr >= self.instr.len() { [INFO] [stderr] 112 | if self.ptr > 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/core/program.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | / if self.ptr >= self.instr.len() { [INFO] [stderr] 112 | | if self.ptr > 0 { [INFO] [stderr] 113 | | self.ptr -= 1; [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 111 | if self.ptr >= self.instr.len() && self.ptr > 0 { [INFO] [stderr] 112 | self.ptr -= 1; [INFO] [stderr] 113 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/program.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/parser.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return Result::Ok(prog); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(prog)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return Result::Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/program.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | / return match self.instr.pop() { [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | Some(_) => { [INFO] [stderr] 110 | | [INFO] [stderr] ... | [INFO] [stderr] 122 | | [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 107 | match self.instr.pop() { [INFO] [stderr] 108 | [INFO] [stderr] 109 | Some(_) => { [INFO] [stderr] 110 | [INFO] [stderr] 111 | if self.ptr >= self.instr.len() { [INFO] [stderr] 112 | if self.ptr > 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/core/program.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | / if self.ptr >= self.instr.len() { [INFO] [stderr] 112 | | if self.ptr > 0 { [INFO] [stderr] 113 | | self.ptr -= 1; [INFO] [stderr] 114 | | } [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 111 | if self.ptr >= self.instr.len() && self.ptr > 0 { [INFO] [stderr] 112 | self.ptr -= 1; [INFO] [stderr] 113 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/program.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/parser.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return Result::Ok(prog); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(prog)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return Result::Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/program.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | if self.instr.len() > 0 { Option::Some(self.instr[self.ptr]) } else { Option::None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.instr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/program.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if self.instr.len() == 0 || pos >= self.instr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.instr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/parser.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if self.code_buffer.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.code_buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Inter` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Inter { [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | Inter { [INFO] [stderr] 28 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for Inter { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match io::stdin().bytes().next() { [INFO] [stderr] 138 | | [INFO] [stderr] 139 | | Some(v) => self.tape.set_val(v.unwrap()), [INFO] [stderr] 140 | | [INFO] [stderr] 141 | | None => { } [INFO] [stderr] 142 | | [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(v) = io::stdin().bytes().next() { self.tape.set_val(v.unwrap()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/program.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | if self.instr.len() > 0 { Option::Some(self.instr[self.ptr]) } else { Option::None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.instr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/program.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if self.instr.len() == 0 || pos >= self.instr.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.instr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/core/parser.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if self.code_buffer.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.code_buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Inter` [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Inter { [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | Inter { [INFO] [stderr] 28 | | [INFO] [stderr] ... | [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | impl Default for Inter { [INFO] [stderr] 23 | fn default() -> Self { [INFO] [stderr] 24 | Self::new() [INFO] [stderr] 25 | } [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | / match io::stdin().bytes().next() { [INFO] [stderr] 138 | | [INFO] [stderr] 139 | | Some(v) => self.tape.set_val(v.unwrap()), [INFO] [stderr] 140 | | [INFO] [stderr] 141 | | None => { } [INFO] [stderr] 142 | | [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(v) = io::stdin().bytes().next() { self.tape.set_val(v.unwrap()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `"docker" "inspect" "54556a988226dc62ca41a3fe8946214f1294fe2d3ed2fa377c33db3ce6bc7868"` [INFO] running `"docker" "rm" "-f" "54556a988226dc62ca41a3fe8946214f1294fe2d3ed2fa377c33db3ce6bc7868"` [INFO] [stdout] 54556a988226dc62ca41a3fe8946214f1294fe2d3ed2fa377c33db3ce6bc7868