[INFO] crate bqrs 0.1.3 is already in cache [INFO] extracting crate bqrs 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/bqrs/0.1.3 [INFO] extracting crate bqrs 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bqrs/0.1.3 [INFO] validating manifest of bqrs-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bqrs-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bqrs-0.1.3 [INFO] finished frobbing bqrs-0.1.3 [INFO] frobbed toml for bqrs-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/bqrs/0.1.3/Cargo.toml [INFO] started frobbing bqrs-0.1.3 [INFO] finished frobbing bqrs-0.1.3 [INFO] frobbed toml for bqrs-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bqrs/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bqrs-0.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bqrs/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d26548ff1c4c45aaf63bfb0515c4e7f36d97b7a68df258034511aa612069cf91 [INFO] running `"docker" "start" "-a" "d26548ff1c4c45aaf63bfb0515c4e7f36d97b7a68df258034511aa612069cf91"` [INFO] [stderr] Checking bqrs v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | Ok(ts) => return build_bquery(ts), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_bquery(ts)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(tokens); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return build_query(&mut tokens); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_query(&mut tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | return Ok(left); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:165:19 [INFO] [stderr] | [INFO] [stderr] 165 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | return Ok(left); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:196:19 [INFO] [stderr] | [INFO] [stderr] 196 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | return next; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(q) => return Ok(Matcher { query: q }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Matcher { query: q })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return match_bquery(&self.query, s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `match_bquery(&self.query, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | &AND(ref a, ref b) => return match_bquery(&*a, s) && match_bquery(&*b, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `match_bquery(&*a, s) && match_bquery(&*b, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | &OR(ref a, ref b) => return match_bquery(&*a, s) || match_bquery(&*b, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `match_bquery(&*a, s) || match_bquery(&*b, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | &NOT(ref a) => return !match_bquery(&*a, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!match_bquery(&*a, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:39:46 [INFO] [stderr] | [INFO] [stderr] 39 | &Leaf(ref keyword, ref jumptable) => return kmp(jumptable, keyword, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kmp(jumptable, keyword, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:61:19 [INFO] [stderr] | [INFO] [stderr] 61 | Ok(ts) => return build_bquery(ts), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_bquery(ts)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(tokens); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return build_query(&mut tokens); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_query(&mut tokens)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | return Ok(left); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:165:19 [INFO] [stderr] | [INFO] [stderr] 165 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | return Ok(left); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:196:19 [INFO] [stderr] | [INFO] [stderr] 196 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | return next; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(q) => return Ok(Matcher { query: q }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Matcher { query: q })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return match_bquery(&self.query, s) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `match_bquery(&self.query, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | &AND(ref a, ref b) => return match_bquery(&*a, s) && match_bquery(&*b, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `match_bquery(&*a, s) && match_bquery(&*b, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | &OR(ref a, ref b) => return match_bquery(&*a, s) || match_bquery(&*b, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `match_bquery(&*a, s) || match_bquery(&*b, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | &NOT(ref a) => return !match_bquery(&*a, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!match_bquery(&*a, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:39:46 [INFO] [stderr] | [INFO] [stderr] 39 | &Leaf(ref keyword, ref jumptable) => return kmp(jumptable, keyword, s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kmp(jumptable, keyword, s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matcher.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | while let Some(c) = query.next() [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in query { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:253:18 [INFO] [stderr] | [INFO] [stderr] 253 | fn kmp_table(s1: &Vec) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/parser.rs:270:27 [INFO] [stderr] | [INFO] [stderr] 270 | while (j > -1) && (s1[(j+1) as usize] != s1[(j+1) as usize]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/matcher.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match query [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | &AND(ref a, ref b) => return match_bquery(&*a, s) && match_bquery(&*b, s), [INFO] [stderr] 37 | | &OR(ref a, ref b) => return match_bquery(&*a, s) || match_bquery(&*b, s), [INFO] [stderr] 38 | | &NOT(ref a) => return !match_bquery(&*a, s), [INFO] [stderr] 39 | | &Leaf(ref keyword, ref jumptable) => return kmp(jumptable, keyword, s), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *query [INFO] [stderr] 35 | { [INFO] [stderr] 36 | AND(ref a, ref b) => return match_bquery(&*a, s) && match_bquery(&*b, s), [INFO] [stderr] 37 | OR(ref a, ref b) => return match_bquery(&*a, s) || match_bquery(&*b, s), [INFO] [stderr] 38 | NOT(ref a) => return !match_bquery(&*a, s), [INFO] [stderr] 39 | Leaf(ref keyword, ref jumptable) => return kmp(jumptable, keyword, s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/matcher.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | fn kmp(table: &Vec, s1: &str, s2: &str) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bqrs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | while let Some(c) = query.next() [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in query { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:253:18 [INFO] [stderr] | [INFO] [stderr] 253 | fn kmp_table(s1: &Vec) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/parser.rs:270:27 [INFO] [stderr] | [INFO] [stderr] 270 | while (j > -1) && (s1[(j+1) as usize] != s1[(j+1) as usize]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/matcher.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match query [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | &AND(ref a, ref b) => return match_bquery(&*a, s) && match_bquery(&*b, s), [INFO] [stderr] 37 | | &OR(ref a, ref b) => return match_bquery(&*a, s) || match_bquery(&*b, s), [INFO] [stderr] 38 | | &NOT(ref a) => return !match_bquery(&*a, s), [INFO] [stderr] 39 | | &Leaf(ref keyword, ref jumptable) => return kmp(jumptable, keyword, s), [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *query [INFO] [stderr] 35 | { [INFO] [stderr] 36 | AND(ref a, ref b) => return match_bquery(&*a, s) && match_bquery(&*b, s), [INFO] [stderr] 37 | OR(ref a, ref b) => return match_bquery(&*a, s) || match_bquery(&*b, s), [INFO] [stderr] 38 | NOT(ref a) => return !match_bquery(&*a, s), [INFO] [stderr] 39 | Leaf(ref keyword, ref jumptable) => return kmp(jumptable, keyword, s), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/matcher.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | fn kmp(table: &Vec, s1: &str, s2: &str) -> bool [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bqrs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d26548ff1c4c45aaf63bfb0515c4e7f36d97b7a68df258034511aa612069cf91"` [INFO] running `"docker" "rm" "-f" "d26548ff1c4c45aaf63bfb0515c4e7f36d97b7a68df258034511aa612069cf91"` [INFO] [stdout] d26548ff1c4c45aaf63bfb0515c4e7f36d97b7a68df258034511aa612069cf91