[INFO] crate block-array-cow 0.1.4 is already in cache [INFO] extracting crate block-array-cow 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/block-array-cow/0.1.4 [INFO] extracting crate block-array-cow 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/block-array-cow/0.1.4 [INFO] validating manifest of block-array-cow-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of block-array-cow-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing block-array-cow-0.1.4 [INFO] finished frobbing block-array-cow-0.1.4 [INFO] frobbed toml for block-array-cow-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/block-array-cow/0.1.4/Cargo.toml [INFO] started frobbing block-array-cow-0.1.4 [INFO] finished frobbing block-array-cow-0.1.4 [INFO] frobbed toml for block-array-cow-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/block-array-cow/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting block-array-cow-0.1.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/block-array-cow/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15a1d1fa4245ca2546d48170e16626202822d1b124c201824792464289d07b24 [INFO] running `"docker" "start" "-a" "15a1d1fa4245ca2546d48170e16626202822d1b124c201824792464289d07b24"` [INFO] [stderr] Checking block-array-cow v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | chunk_size: chunk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_base.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | link_iter: link_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `link_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_base.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | link_iter: link_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `link_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | total_size: total_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1240:50 [INFO] [stderr] | [INFO] [stderr] 1240 | table_ref_stack.push(BTableRef { cref: cref, next: tref_prev }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1407:17 [INFO] [stderr] | [INFO] [stderr] 1407 | accum_steps: accum_steps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accum_steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1410:17 [INFO] [stderr] | [INFO] [stderr] 1410 | accum_read_ahead_len: accum_read_ahead_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accum_read_ahead_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1411:17 [INFO] [stderr] | [INFO] [stderr] 1411 | accum_read_ahead_bytes: accum_read_ahead_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accum_read_ahead_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1527:17 [INFO] [stderr] | [INFO] [stderr] 1527 | chunk_list: chunk_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | chunk_size: chunk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_base.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | link_iter: link_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `link_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list_base.rs:381:13 [INFO] [stderr] | [INFO] [stderr] 381 | link_iter: link_iter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `link_iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | total_size: total_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1240:50 [INFO] [stderr] | [INFO] [stderr] 1240 | table_ref_stack.push(BTableRef { cref: cref, next: tref_prev }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1407:17 [INFO] [stderr] | [INFO] [stderr] 1407 | accum_steps: accum_steps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accum_steps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1410:17 [INFO] [stderr] | [INFO] [stderr] 1410 | accum_read_ahead_len: accum_read_ahead_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accum_read_ahead_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1411:17 [INFO] [stderr] | [INFO] [stderr] 1411 | accum_read_ahead_bytes: accum_read_ahead_bytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accum_read_ahead_bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1527:17 [INFO] [stderr] | [INFO] [stderr] 1527 | chunk_list: chunk_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plain_ptr.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if self.ptr.is_null() == false { Some(*self) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plain_ptr.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if self.ptr.is_null() == false { Some(*self) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return self.elem_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elem_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return self.elem_count == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elem_count == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | return &mut (*elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut (*elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return unsafe { &mut (*elem) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { &mut (*elem) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / return unsafe { [INFO] [stderr] 195 | | self.chunks.get_unchecked( [INFO] [stderr] 196 | | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 197 | | pos.data_index) [INFO] [stderr] 198 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 194 | unsafe { [INFO] [stderr] 195 | self.chunks.get_unchecked( [INFO] [stderr] 196 | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 197 | pos.data_index) [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / return unsafe { [INFO] [stderr] 204 | | self.chunks.get_unchecked_mut( [INFO] [stderr] 205 | | pos.chunk_index).data.get_unchecked_mut( [INFO] [stderr] 206 | | pos.data_index) as *mut TElem [INFO] [stderr] 207 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 203 | unsafe { [INFO] [stderr] 204 | self.chunks.get_unchecked_mut( [INFO] [stderr] 205 | pos.chunk_index).data.get_unchecked_mut( [INFO] [stderr] 206 | pos.data_index) as *mut TElem [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / return unsafe { [INFO] [stderr] 213 | | self.chunks.get_unchecked( [INFO] [stderr] 214 | | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 215 | | pos.data_index) as *const TElem [INFO] [stderr] 216 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 212 | unsafe { [INFO] [stderr] 213 | self.chunks.get_unchecked( [INFO] [stderr] 214 | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 215 | pos.data_index) as *const TElem [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | return (count_final, Some(count_final)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(count_final, Some(count_final))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | / return ( [INFO] [stderr] 267 | | if pos_max < count_final { count_final.wrapping_sub(pos_max) } else { 0 }, [INFO] [stderr] 268 | | Some(min(count_max.wrapping_sub(pos_max), count_final)), [INFO] [stderr] 269 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 266 | ( [INFO] [stderr] 267 | if pos_max < count_final { count_final.wrapping_sub(pos_max) } else { 0 }, [INFO] [stderr] 268 | Some(min(count_max.wrapping_sub(pos_max), count_final)), [INFO] [stderr] 269 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | return Some(elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | return self.pool.iter_to_size_hint(&self.pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pool.iter_to_size_hint(&self.pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | return Some(elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:360:9 [INFO] [stderr] | [INFO] [stderr] 360 | return self.pool.iter_to_size_hint(&self.pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pool.iter_to_size_hint(&self.pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | return Some(link); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(link)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | return Some(link); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(link)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return len; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return len; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return self.head.is_null(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.head.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | return !self.head.is_null() && (self.head == self.tail) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.head.is_null() && (self.head == self.tail)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | return Some(elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | return Some(elem.as_const()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem.as_const())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | return self.chunk_refs.head.as_ptr() as usize as *mut Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chunk_refs.head.as_ptr() as usize as *mut Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return self.users as *mut Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.users as *mut Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:428:5 [INFO] [stderr] | [INFO] [stderr] 428 | return bchunk_new(bs_mem, data_copy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bchunk_new(bs_mem, data_copy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:450:9 [INFO] [stderr] | [INFO] [stderr] 450 | return &data_base[offset..(offset + chunk.data.len())] == &chunk.data[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&data_base[offset..(offset + chunk.data.len())] == &chunk.data[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:452:9 [INFO] [stderr] | [INFO] [stderr] 452 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:515:5 [INFO] [stderr] | [INFO] [stderr] 515 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:634:13 [INFO] [stderr] | [INFO] [stderr] 634 | / if data_last_chunk_len != 0 { [INFO] [stderr] 635 | | if data_last_chunk_len < info.chunk_byte_size_min { [INFO] [stderr] 636 | | // may be zero and thats OK [INFO] [stderr] 637 | | data_trim_len -= info.chunk_byte_size; [INFO] [stderr] 638 | | data_last_chunk_len += info.chunk_byte_size; [INFO] [stderr] 639 | | } [INFO] [stderr] 640 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 634 | if data_last_chunk_len != 0 && data_last_chunk_len < info.chunk_byte_size_min { [INFO] [stderr] 635 | // may be zero and thats OK [INFO] [stderr] 636 | data_trim_len -= info.chunk_byte_size; [INFO] [stderr] 637 | data_last_chunk_len += info.chunk_byte_size; [INFO] [stderr] 638 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:761:5 [INFO] [stderr] | [INFO] [stderr] 761 | / if USE_MERGE_CHUNKS { [INFO] [stderr] 762 | | if data.len() > info.chunk_byte_size { [INFO] [stderr] 763 | | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 764 | | } [INFO] [stderr] 765 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 761 | if USE_MERGE_CHUNKS && data.len() > info.chunk_byte_size { [INFO] [stderr] 762 | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 763 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:802:5 [INFO] [stderr] | [INFO] [stderr] 802 | / if USE_MERGE_CHUNKS { [INFO] [stderr] 803 | | if data.len() > info.chunk_byte_size { [INFO] [stderr] 804 | | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 805 | | } [INFO] [stderr] 806 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 802 | if USE_MERGE_CHUNKS && data.len() > info.chunk_byte_size { [INFO] [stderr] 803 | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 804 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:829:5 [INFO] [stderr] | [INFO] [stderr] 829 | return ((HASH_INIT << 5) + HASH_INIT).wrapping_add((p as i8) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((HASH_INIT << 5) + HASH_INIT).wrapping_add((p as i8) as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:841:5 [INFO] [stderr] | [INFO] [stderr] 841 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:961:9 [INFO] [stderr] | [INFO] [stderr] 961 | return key; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plain_ptr.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if self.ptr.is_null() == false { Some(*self) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plain_ptr.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if self.ptr.is_null() == false { Some(*self) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return self.elem_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elem_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return self.elem_count == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.elem_count == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | return &mut (*elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut (*elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | return unsafe { &mut (*elem) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { &mut (*elem) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / return unsafe { [INFO] [stderr] 195 | | self.chunks.get_unchecked( [INFO] [stderr] 196 | | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 197 | | pos.data_index) [INFO] [stderr] 198 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 194 | unsafe { [INFO] [stderr] 195 | self.chunks.get_unchecked( [INFO] [stderr] 196 | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 197 | pos.data_index) [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / return unsafe { [INFO] [stderr] 204 | | self.chunks.get_unchecked_mut( [INFO] [stderr] 205 | | pos.chunk_index).data.get_unchecked_mut( [INFO] [stderr] 206 | | pos.data_index) as *mut TElem [INFO] [stderr] 207 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 203 | unsafe { [INFO] [stderr] 204 | self.chunks.get_unchecked_mut( [INFO] [stderr] 205 | pos.chunk_index).data.get_unchecked_mut( [INFO] [stderr] 206 | pos.data_index) as *mut TElem [INFO] [stderr] 207 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / return unsafe { [INFO] [stderr] 213 | | self.chunks.get_unchecked( [INFO] [stderr] 214 | | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 215 | | pos.data_index) as *const TElem [INFO] [stderr] 216 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 212 | unsafe { [INFO] [stderr] 213 | self.chunks.get_unchecked( [INFO] [stderr] 214 | pos.chunk_index).data.get_unchecked( [INFO] [stderr] 215 | pos.data_index) as *const TElem [INFO] [stderr] 216 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | return (count_final, Some(count_final)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(count_final, Some(count_final))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | / return ( [INFO] [stderr] 267 | | if pos_max < count_final { count_final.wrapping_sub(pos_max) } else { 0 }, [INFO] [stderr] 268 | | Some(min(count_max.wrapping_sub(pos_max), count_final)), [INFO] [stderr] 269 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 266 | ( [INFO] [stderr] 267 | if pos_max < count_final { count_final.wrapping_sub(pos_max) } else { 0 }, [INFO] [stderr] 268 | Some(min(count_max.wrapping_sub(pos_max), count_final)), [INFO] [stderr] 269 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | return Some(elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:332:13 [INFO] [stderr] | [INFO] [stderr] 332 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | return self.pool.iter_to_size_hint(&self.pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pool.iter_to_size_hint(&self.pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | return Some(elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:360:9 [INFO] [stderr] | [INFO] [stderr] 360 | return self.pool.iter_to_size_hint(&self.pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pool.iter_to_size_hint(&self.pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests_mempool.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return 0; // don't run! [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests_mempool.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return self.link; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | return Some(link); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(link)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | return Some(link); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(link)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | return len; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return len; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return self.head.is_null(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.head.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | return !self.head.is_null() && (self.head == self.tail) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.head.is_null() && (self.head == self.tail)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:971:9 [INFO] [stderr] | [INFO] [stderr] 971 | return key; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | return Some(elem); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:419:13 [INFO] [stderr] | [INFO] [stderr] 419 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | return Some(elem.as_const()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(elem.as_const())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/list_base.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:987:13 [INFO] [stderr] | [INFO] [stderr] 987 | / if chunk_test.data.len() <= size_left { [INFO] [stderr] 988 | | if bchunk_data_compare(chunk_test, data, data_len, offset) { [INFO] [stderr] 989 | | // we could remove the chunk from the table, to avoid multiple hits [INFO] [stderr] 990 | | return cref; [INFO] [stderr] 991 | | } [INFO] [stderr] 992 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 987 | if chunk_test.data.len() <= size_left && bchunk_data_compare(chunk_test, data, data_len, offset) { [INFO] [stderr] 988 | // we could remove the chunk from the table, to avoid multiple hits [INFO] [stderr] 989 | return cref; [INFO] [stderr] 990 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1357:5 [INFO] [stderr] | [INFO] [stderr] 1357 | return chunk_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | return self.chunk_refs.head.as_ptr() as usize as *mut Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.chunk_refs.head.as_ptr() as usize as *mut Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | return self.users as *mut Self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.users as *mut Self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1045:9 [INFO] [stderr] | [INFO] [stderr] 1045 | / if full_match { [INFO] [stderr] 1046 | | if chunk_list_reference.total_size == data_len_original { [INFO] [stderr] 1047 | | return chunk_list_reference; [INFO] [stderr] 1048 | | } [INFO] [stderr] 1049 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1045 | if full_match && chunk_list_reference.total_size == data_len_original { [INFO] [stderr] 1046 | return chunk_list_reference; [INFO] [stderr] 1047 | } [INFO] [stderr] | [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:428:5 [INFO] [stderr] | [INFO] [stderr] 428 | return bchunk_new(bs_mem, data_copy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bchunk_new(bs_mem, data_copy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:450:9 [INFO] [stderr] | [INFO] [stderr] 450 | return &data_base[offset..(offset + chunk.data.len())] == &chunk.data[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&data_base[offset..(offset + chunk.data.len())] == &chunk.data[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:452:9 [INFO] [stderr] | [INFO] [stderr] 452 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1095:5 [INFO] [stderr] | [INFO] [stderr] 1095 | / if USE_FASTPATH_CHUNKS_LAST { [INFO] [stderr] 1096 | | if !chunk_list_reference.chunk_refs.is_empty() { [INFO] [stderr] 1097 | | let mut cref: PtrMut = chunk_list_reference.chunk_refs.tail; [INFO] [stderr] 1098 | | while [INFO] [stderr] ... | [INFO] [stderr] 1115 | | } [INFO] [stderr] 1116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] | [INFO] [stderr] --> src/lib.rs:515:5 [INFO] [stderr] | [INFO] [stderr] 515 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1095 | if USE_FASTPATH_CHUNKS_LAST && !chunk_list_reference.chunk_refs.is_empty() { [INFO] [stderr] 1096 | let mut cref: PtrMut = chunk_list_reference.chunk_refs.tail; [INFO] [stderr] 1097 | while [INFO] [stderr] 1098 | (cref.prev != null_mut()) && [INFO] [stderr] 1099 | (cref != cref_match_first) && [INFO] [stderr] 1100 | (cref.link.data.len() <= data_len - i_prev) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1129:5 [INFO] [stderr] | [INFO] [stderr] 1129 | / if USE_ALIGN_CHUNKS_TEST { [INFO] [stderr] 1130 | | if chunk_list.total_size == chunk_list_reference.total_size { [INFO] [stderr] 1131 | | // if we're already a quarter aligned [INFO] [stderr] 1132 | | if data_len - i_prev <= chunk_list.total_size / 4 { [INFO] [stderr] ... | [INFO] [stderr] 1137 | | } [INFO] [stderr] 1138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1129 | if USE_ALIGN_CHUNKS_TEST && chunk_list.total_size == chunk_list_reference.total_size { [INFO] [stderr] 1130 | // if we're already a quarter aligned [INFO] [stderr] 1131 | if data_len - i_prev <= chunk_list.total_size / 4 { [INFO] [stderr] 1132 | use_aligned = true; [INFO] [stderr] 1133 | } else { [INFO] [stderr] 1134 | // TODO, walk over chunks and check if some arbitrary amount align [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:634:13 [INFO] [stderr] | [INFO] [stderr] 634 | / if data_last_chunk_len != 0 { [INFO] [stderr] 635 | | if data_last_chunk_len < info.chunk_byte_size_min { [INFO] [stderr] 636 | | // may be zero and thats OK [INFO] [stderr] 637 | | data_trim_len -= info.chunk_byte_size; [INFO] [stderr] 638 | | data_last_chunk_len += info.chunk_byte_size; [INFO] [stderr] 639 | | } [INFO] [stderr] 640 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 634 | if data_last_chunk_len != 0 && data_last_chunk_len < info.chunk_byte_size_min { [INFO] [stderr] 635 | // may be zero and thats OK [INFO] [stderr] 636 | data_trim_len -= info.chunk_byte_size; [INFO] [stderr] 637 | data_last_chunk_len += info.chunk_byte_size; [INFO] [stderr] 638 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:761:5 [INFO] [stderr] | [INFO] [stderr] 761 | / if USE_MERGE_CHUNKS { [INFO] [stderr] 762 | | if data.len() > info.chunk_byte_size { [INFO] [stderr] 763 | | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 764 | | } [INFO] [stderr] 765 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 761 | if USE_MERGE_CHUNKS && data.len() > info.chunk_byte_size { [INFO] [stderr] 762 | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 763 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:802:5 [INFO] [stderr] | [INFO] [stderr] 802 | / if USE_MERGE_CHUNKS { [INFO] [stderr] 803 | | if data.len() > info.chunk_byte_size { [INFO] [stderr] 804 | | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 805 | | } [INFO] [stderr] 806 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 802 | if USE_MERGE_CHUNKS && data.len() > info.chunk_byte_size { [INFO] [stderr] 803 | debug_assert!(chunk_list.chunk_refs.tail.link.data.len() >= info.chunk_byte_size_min); [INFO] [stderr] 804 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:829:5 [INFO] [stderr] | [INFO] [stderr] 829 | return ((HASH_INIT << 5) + HASH_INIT).wrapping_add((p as i8) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((HASH_INIT << 5) + HASH_INIT).wrapping_add((p as i8) as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:841:5 [INFO] [stderr] | [INFO] [stderr] 841 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:961:9 [INFO] [stderr] | [INFO] [stderr] 961 | return key; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:971:9 [INFO] [stderr] | [INFO] [stderr] 971 | return key; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:987:13 [INFO] [stderr] | [INFO] [stderr] 987 | / if chunk_test.data.len() <= size_left { [INFO] [stderr] 988 | | if bchunk_data_compare(chunk_test, data, data_len, offset) { [INFO] [stderr] 989 | | // we could remove the chunk from the table, to avoid multiple hits [INFO] [stderr] 990 | | return cref; [INFO] [stderr] 991 | | } [INFO] [stderr] 992 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 987 | if chunk_test.data.len() <= size_left && bchunk_data_compare(chunk_test, data, data_len, offset) { [INFO] [stderr] 988 | // we could remove the chunk from the table, to avoid multiple hits [INFO] [stderr] 989 | return cref; [INFO] [stderr] 990 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1357:5 [INFO] [stderr] | [INFO] [stderr] 1357 | return chunk_list; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1045:9 [INFO] [stderr] | [INFO] [stderr] 1045 | / if full_match { [INFO] [stderr] 1046 | | if chunk_list_reference.total_size == data_len_original { [INFO] [stderr] 1047 | | return chunk_list_reference; [INFO] [stderr] 1048 | | } [INFO] [stderr] 1049 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1045 | if full_match && chunk_list_reference.total_size == data_len_original { [INFO] [stderr] 1046 | return chunk_list_reference; [INFO] [stderr] 1047 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1095:5 [INFO] [stderr] | [INFO] [stderr] 1095 | / if USE_FASTPATH_CHUNKS_LAST { [INFO] [stderr] 1096 | | if !chunk_list_reference.chunk_refs.is_empty() { [INFO] [stderr] 1097 | | let mut cref: PtrMut = chunk_list_reference.chunk_refs.tail; [INFO] [stderr] 1098 | | while [INFO] [stderr] ... | [INFO] [stderr] 1115 | | } [INFO] [stderr] 1116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1095 | if USE_FASTPATH_CHUNKS_LAST && !chunk_list_reference.chunk_refs.is_empty() { [INFO] [stderr] 1096 | let mut cref: PtrMut = chunk_list_reference.chunk_refs.tail; [INFO] [stderr] 1097 | while [INFO] [stderr] 1098 | (cref.prev != null_mut()) && [INFO] [stderr] 1099 | (cref != cref_match_first) && [INFO] [stderr] 1100 | (cref.link.data.len() <= data_len - i_prev) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1332:5 [INFO] [stderr] | [INFO] [stderr] 1332 | / if USE_FASTPATH_CHUNKS_LAST { [INFO] [stderr] 1333 | | if chunk_list_reference_last != null_mut() { [INFO] [stderr] 1334 | | // write chunk_list_reference_last since it hasn't been written yet [INFO] [stderr] 1335 | | let mut cref: PtrMut = chunk_list_reference_last; [INFO] [stderr] ... | [INFO] [stderr] 1346 | | } [INFO] [stderr] 1347 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1129:5 [INFO] [stderr] | [INFO] [stderr] 1129 | / if USE_ALIGN_CHUNKS_TEST { [INFO] [stderr] 1130 | | if chunk_list.total_size == chunk_list_reference.total_size { [INFO] [stderr] 1131 | | // if we're already a quarter aligned [INFO] [stderr] 1132 | | if data_len - i_prev <= chunk_list.total_size / 4 { [INFO] [stderr] ... | [INFO] [stderr] 1137 | | } [INFO] [stderr] 1138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] | [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1129 | if USE_ALIGN_CHUNKS_TEST && chunk_list.total_size == chunk_list_reference.total_size { [INFO] [stderr] 1130 | // if we're already a quarter aligned [INFO] [stderr] 1131 | if data_len - i_prev <= chunk_list.total_size / 4 { [INFO] [stderr] 1132 | use_aligned = true; [INFO] [stderr] 1133 | } else { [INFO] [stderr] 1134 | // TODO, walk over chunks and check if some arbitrary amount align [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1332 | if USE_FASTPATH_CHUNKS_LAST && chunk_list_reference_last != null_mut() { [INFO] [stderr] 1333 | // write chunk_list_reference_last since it hasn't been written yet [INFO] [stderr] 1334 | let mut cref: PtrMut = chunk_list_reference_last; [INFO] [stderr] 1335 | while cref != null_mut() { [INFO] [stderr] 1336 | let chunk: PtrMut = cref.link; [INFO] [stderr] 1337 | // debug_assert!(bchunk_data_compare(chunk, data, data_len, i_prev)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:1395:38 [INFO] [stderr] | [INFO] [stderr] 1395 | let accum_read_ahead_len = ((((accum_steps * (accum_steps + 1))) / 2) + 1) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1541:9 [INFO] [stderr] | [INFO] [stderr] 1541 | return state.as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `state.as_ptr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1567:9 [INFO] [stderr] | [INFO] [stderr] 1567 | return unsafe { (*state).chunk_list.total_size }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { (*state).chunk_list.total_size }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1606:9 [INFO] [stderr] | [INFO] [stderr] 1606 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1698:9 [INFO] [stderr] | [INFO] [stderr] 1698 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1718:5 [INFO] [stderr] | [INFO] [stderr] 1718 | return total_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:1332:5 [INFO] [stderr] | [INFO] [stderr] 1332 | / if USE_FASTPATH_CHUNKS_LAST { [INFO] [stderr] 1333 | | if chunk_list_reference_last != null_mut() { [INFO] [stderr] 1334 | | // write chunk_list_reference_last since it hasn't been written yet [INFO] [stderr] 1335 | | let mut cref: PtrMut = chunk_list_reference_last; [INFO] [stderr] ... | [INFO] [stderr] 1346 | | } [INFO] [stderr] 1347 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1332 | if USE_FASTPATH_CHUNKS_LAST && chunk_list_reference_last != null_mut() { [INFO] [stderr] 1333 | // write chunk_list_reference_last since it hasn't been written yet [INFO] [stderr] 1334 | let mut cref: PtrMut = chunk_list_reference_last; [INFO] [stderr] 1335 | while cref != null_mut() { [INFO] [stderr] 1336 | let chunk: PtrMut = cref.link; [INFO] [stderr] 1337 | // debug_assert!(bchunk_data_compare(chunk, data, data_len, i_prev)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:1395:38 [INFO] [stderr] | [INFO] [stderr] 1395 | let accum_read_ahead_len = ((((accum_steps * (accum_steps + 1))) / 2) + 1) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1541:9 [INFO] [stderr] | [INFO] [stderr] 1541 | return state.as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `state.as_ptr()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1567:9 [INFO] [stderr] | [INFO] [stderr] 1567 | return unsafe { (*state).chunk_list.total_size }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { (*state).chunk_list.total_size }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1606:9 [INFO] [stderr] | [INFO] [stderr] 1606 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1698:9 [INFO] [stderr] | [INFO] [stderr] 1698 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1718:5 [INFO] [stderr] | [INFO] [stderr] 1718 | return total_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/plain_ptr.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | #[derive(Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/plain_ptr.rs:189:1 [INFO] [stderr] | [INFO] [stderr] 189| / impl PartialEq for PtrMut { [INFO] [stderr] 190| | fn eq(&self, other: &PtrMut) -> bool { [INFO] [stderr] 191| | self.ptr == other.ptr [INFO] [stderr] 192| | } [INFO] [stderr] 193| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn is_null(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/plain_ptr.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | self.ptr == ::std::ptr::null_mut() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:144:19 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn as_ptr(&self) -> *mut T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn as_option(&self) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/plain_ptr.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn as_const(&self) -> PtrConst { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/plain_ptr.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | #[derive(Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/plain_ptr.rs:369:1 [INFO] [stderr] | [INFO] [stderr] 369 | / impl PartialEq for PtrConst { [INFO] [stderr] 370 | | fn eq(&self, other: &PtrConst) -> bool { [INFO] [stderr] 371 | | self.ptr == other.ptr [INFO] [stderr] 372 | | } [INFO] [stderr] 373 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:299:16 [INFO] [stderr] | [INFO] [stderr] 299 | fn is_null(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/plain_ptr.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | self.ptr == ::std::ptr::null() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:303:19 [INFO] [stderr] | [INFO] [stderr] 303 | pub fn as_ptr(&self) -> *const T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:307:22 [INFO] [stderr] | [INFO] [stderr] 307 | pub fn as_option(&self) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/plain_ptr.rs:308:19 [INFO] [stderr] | [INFO] [stderr] 308 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:312:17 [INFO] [stderr] | [INFO] [stderr] 312 | fn as_const(&self) -> PtrConst { PtrConst::new(self.ptr) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:337:26 [INFO] [stderr] | [INFO] [stderr] 337 | pub unsafe fn as_mut(&self) -> PtrMut { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/mempool_elem.rs:232:16 [INFO] [stderr] | [INFO] [stderr] 232 | if self.iter_impl_elem_from_index_ref(pos).free_ptr_test() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.iter_impl_elem_from_index_ref(pos).free_ptr_test()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/plain_ptr.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | #[derive(Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/plain_ptr.rs:189:1 [INFO] [stderr] | [INFO] [stderr] 189| / impl PartialEq for PtrMut { [INFO] [stderr] 190| | fn eq(&self, other: &PtrMut) -> bool { [INFO] [stderr] 191| | self.ptr == other.ptr [INFO] [stderr] 192| | } [INFO] [stderr] 193| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn is_null(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/plain_ptr.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | self.ptr == ::std::ptr::null_mut() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:144:19 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn as_ptr(&self) -> *mut T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn as_option(&self) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/plain_ptr.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn as_const(&self) -> PtrConst { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/plain_ptr.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | #[derive(Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/plain_ptr.rs:369:1 [INFO] [stderr] | [INFO] [stderr] 369 | / impl PartialEq for PtrConst { [INFO] [stderr] 370 | | fn eq(&self, other: &PtrConst) -> bool { [INFO] [stderr] 371 | | self.ptr == other.ptr [INFO] [stderr] 372 | | } [INFO] [stderr] 373 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:299:16 [INFO] [stderr] | [INFO] [stderr] 299 | fn is_null(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/plain_ptr.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | self.ptr == ::std::ptr::null() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:303:19 [INFO] [stderr] | [INFO] [stderr] 303 | pub fn as_ptr(&self) -> *const T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:307:22 [INFO] [stderr] | [INFO] [stderr] 307 | pub fn as_option(&self) -> Option> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:324:12 [INFO] [stderr] | [INFO] [stderr] 324 | if a.prev_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/plain_ptr.rs:308:19 [INFO] [stderr] | [INFO] [stderr] 308 | return if self.ptr.is_null() == false { Some(*self) } else { None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.ptr.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:327:12 [INFO] [stderr] | [INFO] [stderr] 327 | if a.next_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:312:17 [INFO] [stderr] | [INFO] [stderr] 312 | fn as_const(&self) -> PtrConst { PtrConst::new(self.ptr) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:330:12 [INFO] [stderr] | [INFO] [stderr] 330 | if b.prev_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:333:12 [INFO] [stderr] | [INFO] [stderr] 333 | if b.next_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plain_ptr.rs:337:26 [INFO] [stderr] | [INFO] [stderr] 337 | pub unsafe fn as_mut(&self) -> PtrMut { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:450:16 [INFO] [stderr] | [INFO] [stderr] 450 | return &data_base[offset..(offset + chunk.data.len())] == &chunk.data[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 450 | return data_base[offset..(offset + chunk.data.len())] == chunk.data[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:481:15 [INFO] [stderr] | [INFO] [stderr] 481 | while cref != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:510:12 [INFO] [stderr] | [INFO] [stderr] 510 | if &data[offset..(offset + cref.link.data.len())] != &cref.link.data[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/mempool_elem.rs:232:16 [INFO] [stderr] | [INFO] [stderr] 232 | if self.iter_impl_elem_from_index_ref(pos).free_ptr_test() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.iter_impl_elem_from_index_ref(pos).free_ptr_test()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 510 | if data[offset..(offset + cref.link.data.len())] != cref.link.data[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:534:8 [INFO] [stderr] | [INFO] [stderr] 534 | if cref != null_mut() && cref.prev != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:534:30 [INFO] [stderr] | [INFO] [stderr] 534 | if cref != null_mut() && cref.prev != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:633:13 [INFO] [stderr] | [INFO] [stderr] 633 | data_trim_len = data_trim_len - data_last_chunk_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_trim_len -= data_last_chunk_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:649:9 [INFO] [stderr] | [INFO] [stderr] 649 | data_trim_len = data_trim_len - data_last_chunk_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_trim_len -= data_last_chunk_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/lib.rs:712:8 [INFO] [stderr] | [INFO] [stderr] 712 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/lib.rs:712:17 [INFO] [stderr] | [INFO] [stderr] 712 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:681:19 [INFO] [stderr] | [INFO] [stderr] 681 | debug_assert!(data.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/lib.rs:809:8 [INFO] [stderr] | [INFO] [stderr] 809 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] | [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/lib.rs:809:17 [INFO] [stderr] | [INFO] [stderr] 809 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:853:29 [INFO] [stderr] | [INFO] [stderr] 853 | hash_array[i] = hash_data(&data_slice[i_step..i_next]) as HashKey; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(hash_data(&data_slice[i_step..i_next]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:860:29 [INFO] [stderr] | [INFO] [stderr] 860 | hash_array[i] = hash_data_single(data_slice[i]) as HashKey; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(hash_data_single(data_slice[i]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:916:18 [INFO] [stderr] | [INFO] [stderr] 916 | if unlikely!(!(iter_steps <= hash_array.len())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter_steps > hash_array.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:976:31 [INFO] [stderr] | [INFO] [stderr] 976 | info: &BArrayInfo, table: &Vec>, table_len: usize, i_table_start: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[PtrMut]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:977:68 [INFO] [stderr] | [INFO] [stderr] 977 | data: &[u8], data_len: usize, offset: usize, table_hash_array: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[HashKey]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:975:1 [INFO] [stderr] | [INFO] [stderr] 975 | / fn table_lookup( [INFO] [stderr] 976 | | info: &BArrayInfo, table: &Vec>, table_len: usize, i_table_start: usize, [INFO] [stderr] 977 | | data: &[u8], data_len: usize, offset: usize, table_hash_array: &Vec, [INFO] [stderr] 978 | | ) -> PtrMut { [INFO] [stderr] ... | [INFO] [stderr] 996 | | null_mut() [INFO] [stderr] 997 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:324:12 [INFO] [stderr] | [INFO] [stderr] 324 | if a.prev_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/lib.rs:1267:24 [INFO] [stderr] | [INFO] [stderr] 1267 | if false && i_prev != 0 { } // quiet warning! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/lib.rs:1267:33 [INFO] [stderr] | [INFO] [stderr] 1267 | if false && i_prev != 0 { } // quiet warning! [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:327:12 [INFO] [stderr] | [INFO] [stderr] 327 | if a.next_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:330:12 [INFO] [stderr] | [INFO] [stderr] 330 | if b.prev_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/list_base.rs:333:12 [INFO] [stderr] | [INFO] [stderr] 333 | if b.next_get() != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 105 [INFO] [stderr] --> src/lib.rs:1009:1 [INFO] [stderr] | [INFO] [stderr] 1009 | / fn bchunk_list_from_data_merge( [INFO] [stderr] 1010 | | info: &BArrayInfo, bs_mem: &mut BArrayMemory, [INFO] [stderr] 1011 | | data: &[u8], data_len_original: usize, [INFO] [stderr] 1012 | | chunk_list_reference: PtrMut, [INFO] [stderr] ... | [INFO] [stderr] 1357 | | return chunk_list; [INFO] [stderr] 1358 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1031:17 [INFO] [stderr] | [INFO] [stderr] 1031 | if cref != null_mut() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:450:16 [INFO] [stderr] | [INFO] [stderr] 450 | return &data_base[offset..(offset + chunk.data.len())] == &chunk.data[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 450 | return data_base[offset..(offset + chunk.data.len())] == chunk.data[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:481:15 [INFO] [stderr] | [INFO] [stderr] 481 | while cref != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:510:12 [INFO] [stderr] | [INFO] [stderr] 510 | if &data[offset..(offset + cref.link.data.len())] != &cref.link.data[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 510 | if data[offset..(offset + cref.link.data.len())] != cref.link.data[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:534:8 [INFO] [stderr] | [INFO] [stderr] 534 | if cref != null_mut() && cref.prev != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:534:30 [INFO] [stderr] | [INFO] [stderr] 534 | if cref != null_mut() && cref.prev != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1099:17 [INFO] [stderr] | [INFO] [stderr] 1099 | (cref.prev != null_mut()) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1146:16 [INFO] [stderr] | [INFO] [stderr] 1146 | if cref_match_first != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1175:9 [INFO] [stderr] | [INFO] [stderr] 1175 | (chunk_list_reference.chunk_refs.head != null_mut()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1214:20 [INFO] [stderr] | [INFO] [stderr] 1214 | if cref_match_first != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1283:21 [INFO] [stderr] | [INFO] [stderr] 1283 | (cref_found.next != null_mut()) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:1305:17 [INFO] [stderr] | [INFO] [stderr] 1305 | i = i + info.chunk_stride; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `i += info.chunk_stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1333:12 [INFO] [stderr] | [INFO] [stderr] 1333 | if chunk_list_reference_last != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1336:19 [INFO] [stderr] | [INFO] [stderr] 1336 | while cref != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:633:13 [INFO] [stderr] | [INFO] [stderr] 633 | data_trim_len = data_trim_len - data_last_chunk_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_trim_len -= data_last_chunk_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:649:9 [INFO] [stderr] | [INFO] [stderr] 649 | data_trim_len = data_trim_len - data_last_chunk_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_trim_len -= data_last_chunk_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/lib.rs:712:8 [INFO] [stderr] | [INFO] [stderr] 712 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::logic_bug)] on by default [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/lib.rs:712:17 [INFO] [stderr] | [INFO] [stderr] 712 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:681:19 [INFO] [stderr] | [INFO] [stderr] 681 | debug_assert!(data.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:1567:27 [INFO] [stderr] | [INFO] [stderr] 1567 | return unsafe { (*state).chunk_list.total_size }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1670:20 [INFO] [stderr] | [INFO] [stderr] 1670 | if !(unsafe { (**chunk_list).users } == *users) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unsafe { (**chunk_list).users } != *users` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1674:16 [INFO] [stderr] | [INFO] [stderr] 1674 | if !(self.memory.chunk_list.len() == chunk_list_map.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.chunk_list.len() != chunk_list_map.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1693:20 [INFO] [stderr] | [INFO] [stderr] 1693 | if !(unsafe { (**chunk).users } == *users) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unsafe { (**chunk).users } != *users` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/lib.rs:809:8 [INFO] [stderr] | [INFO] [stderr] 809 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] | [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/lib.rs:809:17 [INFO] [stderr] | [INFO] [stderr] 809 | if false && USE_MERGE_CHUNKS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:853:29 [INFO] [stderr] | [INFO] [stderr] 853 | hash_array[i] = hash_data(&data_slice[i_step..i_next]) as HashKey; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(hash_data(&data_slice[i_step..i_next]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:860:29 [INFO] [stderr] | [INFO] [stderr] 860 | hash_array[i] = hash_data_single(data_slice[i]) as HashKey; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(hash_data_single(data_slice[i]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:916:18 [INFO] [stderr] | [INFO] [stderr] 916 | if unlikely!(!(iter_steps <= hash_array.len())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter_steps > hash_array.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: Could not compile `block-array-cow`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:976:31 [INFO] [stderr] | [INFO] [stderr] 976 | info: &BArrayInfo, table: &Vec>, table_len: usize, i_table_start: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[PtrMut]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:977:68 [INFO] [stderr] | [INFO] [stderr] 977 | data: &[u8], data_len: usize, offset: usize, table_hash_array: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[HashKey]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:975:1 [INFO] [stderr] | [INFO] [stderr] 975 | / fn table_lookup( [INFO] [stderr] 976 | | info: &BArrayInfo, table: &Vec>, table_len: usize, i_table_start: usize, [INFO] [stderr] 977 | | data: &[u8], data_len: usize, offset: usize, table_hash_array: &Vec, [INFO] [stderr] 978 | | ) -> PtrMut { [INFO] [stderr] ... | [INFO] [stderr] 996 | | null_mut() [INFO] [stderr] 997 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this boolean expression contains a logic bug [INFO] [stderr] --> src/lib.rs:1267:24 [INFO] [stderr] | [INFO] [stderr] 1267 | if false && i_prev != 0 { } // quiet warning! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false` [INFO] [stderr] | [INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression [INFO] [stderr] --> src/lib.rs:1267:33 [INFO] [stderr] | [INFO] [stderr] 1267 | if false && i_prev != 0 { } // quiet warning! [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 105 [INFO] [stderr] --> src/lib.rs:1009:1 [INFO] [stderr] | [INFO] [stderr] 1009 | / fn bchunk_list_from_data_merge( [INFO] [stderr] 1010 | | info: &BArrayInfo, bs_mem: &mut BArrayMemory, [INFO] [stderr] 1011 | | data: &[u8], data_len_original: usize, [INFO] [stderr] 1012 | | chunk_list_reference: PtrMut, [INFO] [stderr] ... | [INFO] [stderr] 1357 | | return chunk_list; [INFO] [stderr] 1358 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1031:17 [INFO] [stderr] | [INFO] [stderr] 1031 | if cref != null_mut() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1099:17 [INFO] [stderr] | [INFO] [stderr] 1099 | (cref.prev != null_mut()) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1146:16 [INFO] [stderr] | [INFO] [stderr] 1146 | if cref_match_first != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1175:9 [INFO] [stderr] | [INFO] [stderr] 1175 | (chunk_list_reference.chunk_refs.head != null_mut()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1214:20 [INFO] [stderr] | [INFO] [stderr] 1214 | if cref_match_first != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1283:21 [INFO] [stderr] | [INFO] [stderr] 1283 | (cref_found.next != null_mut()) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:1305:17 [INFO] [stderr] | [INFO] [stderr] 1305 | i = i + info.chunk_stride; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `i += info.chunk_stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1333:12 [INFO] [stderr] | [INFO] [stderr] 1333 | if chunk_list_reference_last != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:1336:19 [INFO] [stderr] | [INFO] [stderr] 1336 | while cref != null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:1567:27 [INFO] [stderr] | [INFO] [stderr] 1567 | return unsafe { (*state).chunk_list.total_size }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1670:20 [INFO] [stderr] | [INFO] [stderr] 1670 | if !(unsafe { (**chunk_list).users } == *users) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unsafe { (**chunk_list).users } != *users` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1674:16 [INFO] [stderr] | [INFO] [stderr] 1674 | if !(self.memory.chunk_list.len() == chunk_list_map.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.memory.chunk_list.len() != chunk_list_map.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1693:20 [INFO] [stderr] | [INFO] [stderr] 1693 | if !(unsafe { (**chunk).users } == *users) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unsafe { (**chunk).users } != *users` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `block-array-cow`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "15a1d1fa4245ca2546d48170e16626202822d1b124c201824792464289d07b24"` [INFO] running `"docker" "rm" "-f" "15a1d1fa4245ca2546d48170e16626202822d1b124c201824792464289d07b24"` [INFO] [stdout] 15a1d1fa4245ca2546d48170e16626202822d1b124c201824792464289d07b24