[INFO] crate blake2b 0.7.0 is already in cache [INFO] extracting crate blake2b 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/blake2b/0.7.0 [INFO] extracting crate blake2b 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blake2b/0.7.0 [INFO] validating manifest of blake2b-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blake2b-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blake2b-0.7.0 [INFO] finished frobbing blake2b-0.7.0 [INFO] frobbed toml for blake2b-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/blake2b/0.7.0/Cargo.toml [INFO] started frobbing blake2b-0.7.0 [INFO] finished frobbing blake2b-0.7.0 [INFO] frobbed toml for blake2b-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blake2b/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blake2b-0.7.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blake2b/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85aa38592e5129eac6b0e4cfd8df7985acda8742d57399ab47b4be339e299c63 [INFO] running `"docker" "start" "-a" "85aa38592e5129eac6b0e4cfd8df7985acda8742d57399ab47b4be339e299c63"` [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking blake2b v0.7.0 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blake2xb.rs:44:4 [INFO] [stderr] | [INFO] [stderr] 44 | parameter_block: parameter_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter_block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blake2xb.rs:70:4 [INFO] [stderr] | [INFO] [stderr] 70 | parameter_block: parameter_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blake2xb.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blake2xb.rs:96:4 [INFO] [stderr] | [INFO] [stderr] 96 | parameter_block: parameter_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blake2xb.rs:97:4 [INFO] [stderr] | [INFO] [stderr] 97 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unbuffered.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | len: len [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | 0x6A09E667F3BCC908, 0xBB67AE8584CAA73B, 0x3C6EF372FE94F82B, 0xA54FF53A5F1D36F1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x6A09_E667_F3BC_C908` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | 0x6A09E667F3BCC908, 0xBB67AE8584CAA73B, 0x3C6EF372FE94F82B, 0xA54FF53A5F1D36F1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xBB67_AE85_84CA_A73B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:18:42 [INFO] [stderr] | [INFO] [stderr] 18 | 0x6A09E667F3BCC908, 0xBB67AE8584CAA73B, 0x3C6EF372FE94F82B, 0xA54FF53A5F1D36F1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3C6E_F372_FE94_F82B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:18:62 [INFO] [stderr] | [INFO] [stderr] 18 | 0x6A09E667F3BCC908, 0xBB67AE8584CAA73B, 0x3C6EF372FE94F82B, 0xA54FF53A5F1D36F1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xA54F_F53A_5F1D_36F1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:2 [INFO] [stderr] | [INFO] [stderr] 19 | 0x510E527FADE682D1, 0x9B05688C2B3E6C1F, 0x1F83D9ABFB41BD6B, 0x5BE0CD19137E2179 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x510E_527F_ADE6_82D1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | 0x510E527FADE682D1, 0x9B05688C2B3E6C1F, 0x1F83D9ABFB41BD6B, 0x5BE0CD19137E2179 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x9B05_688C_2B3E_6C1F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:42 [INFO] [stderr] | [INFO] [stderr] 19 | 0x510E527FADE682D1, 0x9B05688C2B3E6C1F, 0x1F83D9ABFB41BD6B, 0x5BE0CD19137E2179 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1F83_D9AB_FB41_BD6B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:62 [INFO] [stderr] | [INFO] [stderr] 19 | 0x510E527FADE682D1, 0x9B05688C2B3E6C1F, 0x1F83D9ABFB41BD6B, 0x5BE0CD19137E2179 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5BE0_CD19_137E_2179` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `arrayvec`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:15 [INFO] [stderr] | [INFO] [stderr] 129 | let mut a = 0xDEAD4BADu32.wrapping_mul(out.len() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xDEAD_4BADu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `blake2xb::Blake2xb` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/blake2xb.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / impl Blake2xb { [INFO] [stderr] 22 | | pub fn new(len: Option) -> Self { [INFO] [stderr] 23 | | Self::keyed(len, &[]) [INFO] [stderr] 24 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blake2xb.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | .set_node_offset((len.unwrap_or(u32::max_value()) as u64) << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(len.unwrap_or(u32::max_value()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/blake2xb.rs:43:58 [INFO] [stderr] | [INFO] [stderr] 43 | blake2b: Blake2b::with_parameter_block_keyed(64, key, parameter_block.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `parameter_block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/blake2xb.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | let parameter_block = self.parameter_block.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.parameter_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blake2xb.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | .set_node_offset((self.out_len as u64 / 64) | ((self.max_out_len as u64) << 32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.out_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blake2xb.rs:124:51 [INFO] [stderr] | [INFO] [stderr] 124 | .set_node_offset((self.out_len as u64 / 64) | ((self.max_out_len as u64) << 32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.max_out_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `unbuffered::Blake2b` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/unbuffered.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / impl Blake2b { [INFO] [stderr] 15 | | pub fn new(len: usize) -> Self { [INFO] [stderr] 16 | | Self::with_parameter_block(len, ParameterBlock::new().set_digest_len(len as u8).set_fanout(1).set_max_depth(1)) [INFO] [stderr] 17 | | } [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `buffered::Blake2b` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffered.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / impl Blake2b { [INFO] [stderr] 14 | | pub fn new(len: usize) -> Self { [INFO] [stderr] 15 | | Self::keyed(len, &[]) [INFO] [stderr] 16 | | } [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `hash::Hash` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/hash.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / impl Hash { [INFO] [stderr] 15 | | pub(crate) fn new(hash: [u64; 8], len: usize) -> Self { [INFO] [stderr] 16 | | Hash { [INFO] [stderr] 17 | | hash, [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/hash.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | fn as_mut<'a>(&'a mut self) -> &'a mut [u8] { [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | &mut self.hash.as_mut_bytes()[..self.len] [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/hash.rs:52:2 [INFO] [stderr] | [INFO] [stderr] 52 | fn deref<'a>(&'a self) -> &'a Self::Target { [INFO] [stderr] | _____^ [INFO] [stderr] 53 | | self.as_ref() [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/hash.rs:58:2 [INFO] [stderr] | [INFO] [stderr] 58 | fn deref_mut<'a>(&'a mut self) -> &'a mut Self::Target { [INFO] [stderr] | _____^ [INFO] [stderr] 59 | | self.as_mut() [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/hash.rs:73:3 [INFO] [stderr] | [INFO] [stderr] 73 | &**self == &**rhs [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 73 | **self == **rhs [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `out`. [INFO] [stderr] --> src/lib.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | for i in 0..out.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 132 | for in &mut out { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "85aa38592e5129eac6b0e4cfd8df7985acda8742d57399ab47b4be339e299c63"` [INFO] running `"docker" "rm" "-f" "85aa38592e5129eac6b0e4cfd8df7985acda8742d57399ab47b4be339e299c63"` [INFO] [stdout] 85aa38592e5129eac6b0e4cfd8df7985acda8742d57399ab47b4be339e299c63