[INFO] crate bit_range 0.1.0 is already in cache [INFO] extracting crate bit_range 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bit_range/0.1.0 [INFO] extracting crate bit_range 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit_range/0.1.0 [INFO] validating manifest of bit_range-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bit_range-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bit_range-0.1.0 [INFO] finished frobbing bit_range-0.1.0 [INFO] frobbed toml for bit_range-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bit_range/0.1.0/Cargo.toml [INFO] started frobbing bit_range-0.1.0 [INFO] finished frobbing bit_range-0.1.0 [INFO] frobbed toml for bit_range-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit_range/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bit_range-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit_range/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6ec82c9f86d8c706dcf8824b6d13025b06c6580c971273339b1528e59188d9c [INFO] running `"docker" "start" "-a" "a6ec82c9f86d8c706dcf8824b6d13025b06c6580c971273339b1528e59188d9c"` [INFO] [stderr] Checking bit_range v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | (byte >> 7-bit%8) & 1 == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `byte >> (7-bit%8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:52:10 [INFO] [stderr] | [INFO] [stderr] 52 | (byte >> 7-bit%8) & 1 == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `byte >> (7-bit%8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:63:46 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(vec.get_bit_range(1..14), 0b1001100000111); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0b1_0011_0000_0111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let byte = self[(bit/8) as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[(bit/8) as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let byte = self[(bit/8) as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[(bit/8) as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.39s [INFO] running `"docker" "inspect" "a6ec82c9f86d8c706dcf8824b6d13025b06c6580c971273339b1528e59188d9c"` [INFO] running `"docker" "rm" "-f" "a6ec82c9f86d8c706dcf8824b6d13025b06c6580c971273339b1528e59188d9c"` [INFO] [stdout] a6ec82c9f86d8c706dcf8824b6d13025b06c6580c971273339b1528e59188d9c