[INFO] crate bit_manager 0.5.3 is already in cache [INFO] extracting crate bit_manager 0.5.3 into work/ex/clippy-test-run/sources/stable/reg/bit_manager/0.5.3 [INFO] extracting crate bit_manager 0.5.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit_manager/0.5.3 [INFO] validating manifest of bit_manager-0.5.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bit_manager-0.5.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bit_manager-0.5.3 [INFO] finished frobbing bit_manager-0.5.3 [INFO] frobbed toml for bit_manager-0.5.3 written to work/ex/clippy-test-run/sources/stable/reg/bit_manager/0.5.3/Cargo.toml [INFO] started frobbing bit_manager-0.5.3 [INFO] finished frobbing bit_manager-0.5.3 [INFO] frobbed toml for bit_manager-0.5.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit_manager/0.5.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bit_manager-0.5.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit_manager/0.5.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f405e4613811a53b448b9bffcf84050060e6e18c601762aff1c75e3ed26fda2 [INFO] running `"docker" "start" "-a" "9f405e4613811a53b448b9bffcf84050060e6e18c601762aff1c75e3ed26fda2"` [INFO] [stderr] Checking bit_manager v0.5.3 (/opt/crater/workdir) [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | let value = (self.buffer >> self.bits-8 & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.buffer >> (self.bits-8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:155:26 [INFO] [stderr] | [INFO] [stderr] 155 | self.buffer &= !((0xff as u64) << self.bits-8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0xff as u64) << (self.bits-8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | let value = self.buffer >> self.bits-1 & 1 == 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.buffer >> (self.bits-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | self.buffer &= !(1 << self.bits-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (self.bits-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | let value = (self.buffer >> self.bits-8 & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.buffer >> (self.bits-8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:155:26 [INFO] [stderr] | [INFO] [stderr] 155 | self.buffer &= !((0xff as u64) << self.bits-8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0xff as u64) << (self.bits-8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | let value = self.buffer >> self.bits-1 & 1 == 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.buffer >> (self.bits-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/buffer.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | self.buffer &= !(1 << self.bits-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1 << (self.bits-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/buffer.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &Some(ref message) = message { [INFO] [stderr] 47 | | write!(f, "bit error ({})", message) [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | write!(f, "unknown error") [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(ref message) = *message { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `buffer::BitBuffer` [INFO] [stderr] --> src/buffer.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn new() -> BitBuffer { [INFO] [stderr] 112 | | BitBuffer { [INFO] [stderr] 113 | | buffer: 0, [INFO] [stderr] 114 | | bits: 0, [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:123:42 [INFO] [stderr] | [INFO] [stderr] 123 | self.buffer = self.buffer << 8 | value as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:144:24 [INFO] [stderr] | [INFO] [stderr] 144 | self.buffer |= (value as u64) << self.bits; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/data.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / match self { [INFO] [stderr] 112 | | &StringConverter::LengthPrefixed { prefix_bits: 32 } => { [INFO] [stderr] 113 | | writer.write_bit(false)?; [INFO] [stderr] 114 | | writer.write_bit(false) [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | match *self { [INFO] [stderr] 112 | StringConverter::LengthPrefixed { prefix_bits: 32 } => { [INFO] [stderr] 113 | writer.write_bit(false)?; [INFO] [stderr] 114 | writer.write_bit(false) [INFO] [stderr] 115 | } [INFO] [stderr] 116 | StringConverter::LengthPrefixed { prefix_bits } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:257:36 [INFO] [stderr] | [INFO] [stderr] 257 | int |= (read as $u) << (self.bits - index*8 - 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(read)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:257:36 [INFO] [stderr] | [INFO] [stderr] 257 | int |= (read as $u) << (self.bits - index*8 - 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(read)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | let int = *value as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/buffer.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &Some(ref message) = message { [INFO] [stderr] 47 | | write!(f, "bit error ({})", message) [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | write!(f, "unknown error") [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(ref message) = *message { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:257:36 [INFO] [stderr] | [INFO] [stderr] 257 | int |= (read as $u) << (self.bits - index*8 - 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(read)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `buffer::BitBuffer` [INFO] [stderr] --> src/buffer.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn new() -> BitBuffer { [INFO] [stderr] 112 | | BitBuffer { [INFO] [stderr] 113 | | buffer: 0, [INFO] [stderr] 114 | | bits: 0, [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | let int = *value as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:123:42 [INFO] [stderr] | [INFO] [stderr] 123 | self.buffer = self.buffer << 8 | value as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/buffer.rs:144:24 [INFO] [stderr] | [INFO] [stderr] 144 | self.buffer |= (value as u64) << self.bits; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | let int = *value as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/data.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / match self { [INFO] [stderr] 112 | | &StringConverter::LengthPrefixed { prefix_bits: 32 } => { [INFO] [stderr] 113 | | writer.write_bit(false)?; [INFO] [stderr] 114 | | writer.write_bit(false) [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | match *self { [INFO] [stderr] 112 | StringConverter::LengthPrefixed { prefix_bits: 32 } => { [INFO] [stderr] 113 | writer.write_bit(false)?; [INFO] [stderr] 114 | writer.write_bit(false) [INFO] [stderr] 115 | } [INFO] [stderr] 116 | StringConverter::LengthPrefixed { prefix_bits } => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/io.rs:190:30 [INFO] [stderr] | [INFO] [stderr] 190 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 190 | for in buf.iter().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:257:36 [INFO] [stderr] | [INFO] [stderr] 257 | int |= (read as $u) << (self.bits - index*8 - 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(read)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:257:36 [INFO] [stderr] | [INFO] [stderr] 257 | int |= (read as $u) << (self.bits - index*8 - 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(read)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | let int = *value as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/lib.rs:111:36 [INFO] [stderr] | [INFO] [stderr] 111 | (reader) => { Ok( unsafe { mem::transmute($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?))) } ) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?)))` [INFO] [stderr] ... [INFO] [stderr] 116 | float_impl!(4 => u32 => f32; 8 => u64 => f64); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:257:36 [INFO] [stderr] | [INFO] [stderr] 257 | int |= (read as $u) << (self.bits - index*8 - 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(read)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/lib.rs:111:36 [INFO] [stderr] | [INFO] [stderr] 111 | (reader) => { Ok( unsafe { mem::transmute($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?))) } ) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?)))` [INFO] [stderr] ... [INFO] [stderr] 116 | float_impl!(4 => u32 => f32; 8 => u64 => f64); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | let int = *value as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / if let &Some(ref value) = self { [INFO] [stderr] 133 | | writer.write_bit(true)?; [INFO] [stderr] 134 | | writer.write(value) [INFO] [stderr] 135 | | } else { [INFO] [stderr] 136 | | writer.write_bit(false) [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / match self { [INFO] [stderr] 150 | | &Ok(ref value) => { [INFO] [stderr] 151 | | writer.write_bit(true)?; [INFO] [stderr] 152 | | writer.write(value) [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/data.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | let int = *value as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*value)` [INFO] [stderr] ... [INFO] [stderr] 294 | impl_bit_mask!(u64 64, u32 32, u16 16, u8 8); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | match *self { [INFO] [stderr] 150 | Ok(ref value) => { [INFO] [stderr] 151 | writer.write_bit(true)?; [INFO] [stderr] 152 | writer.write(value) [INFO] [stderr] 153 | }, [INFO] [stderr] 154 | Err(ref value) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/io.rs:190:30 [INFO] [stderr] | [INFO] [stderr] 190 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 190 | for in buf.iter().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/lib.rs:111:36 [INFO] [stderr] | [INFO] [stderr] 111 | (reader) => { Ok( unsafe { mem::transmute($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?))) } ) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?)))` [INFO] [stderr] ... [INFO] [stderr] 116 | float_impl!(4 => u32 => f32; 8 => u64 => f64); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/lib.rs:111:36 [INFO] [stderr] | [INFO] [stderr] 111 | (reader) => { Ok( unsafe { mem::transmute($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?))) } ) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits($u::from_be(mem::transmute::<[u8; $s], $u>(reader.read()?)))` [INFO] [stderr] ... [INFO] [stderr] 116 | float_impl!(4 => u32 => f32; 8 => u64 => f64); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / if let &Some(ref value) = self { [INFO] [stderr] 133 | | writer.write_bit(true)?; [INFO] [stderr] 134 | | writer.write(value) [INFO] [stderr] 135 | | } else { [INFO] [stderr] 136 | | writer.write_bit(false) [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(ref value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | / match self { [INFO] [stderr] 150 | | &Ok(ref value) => { [INFO] [stderr] 151 | | writer.write_bit(true)?; [INFO] [stderr] 152 | | writer.write(value) [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 149 | match *self { [INFO] [stderr] 150 | Ok(ref value) => { [INFO] [stderr] 151 | writer.write_bit(true)?; [INFO] [stderr] 152 | writer.write(value) [INFO] [stderr] 153 | }, [INFO] [stderr] 154 | Err(ref value) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.60s [INFO] running `"docker" "inspect" "9f405e4613811a53b448b9bffcf84050060e6e18c601762aff1c75e3ed26fda2"` [INFO] running `"docker" "rm" "-f" "9f405e4613811a53b448b9bffcf84050060e6e18c601762aff1c75e3ed26fda2"` [INFO] [stdout] 9f405e4613811a53b448b9bffcf84050060e6e18c601762aff1c75e3ed26fda2