[INFO] crate biodata-parsers 0.1.0 is already in cache [INFO] extracting crate biodata-parsers 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/biodata-parsers/0.1.0 [INFO] extracting crate biodata-parsers 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/biodata-parsers/0.1.0 [INFO] validating manifest of biodata-parsers-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of biodata-parsers-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing biodata-parsers-0.1.0 [INFO] finished frobbing biodata-parsers-0.1.0 [INFO] frobbed toml for biodata-parsers-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/biodata-parsers/0.1.0/Cargo.toml [INFO] started frobbing biodata-parsers-0.1.0 [INFO] finished frobbing biodata-parsers-0.1.0 [INFO] frobbed toml for biodata-parsers-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/biodata-parsers/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting biodata-parsers-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/biodata-parsers/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9097c69c0d4b2ee619a524c2ec1ecf96ca05bd5480482ddb041f098f3c418100 [INFO] running `"docker" "start" "-a" "9097c69c0d4b2ee619a524c2ec1ecf96ca05bd5480482ddb041f098f3c418100"` [INFO] [stderr] Checking biodata-parsers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | uniparc_xref_idx: uniparc_xref_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_xref_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | property_idx: property_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `property_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:323:26 [INFO] [stderr] | [INFO] [stderr] 323 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:331:26 [INFO] [stderr] | [INFO] [stderr] 331 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:339:26 [INFO] [stderr] | [INFO] [stderr] 339 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:347:26 [INFO] [stderr] | [INFO] [stderr] 347 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:363:26 [INFO] [stderr] | [INFO] [stderr] 363 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:371:26 [INFO] [stderr] | [INFO] [stderr] 371 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:379:26 [INFO] [stderr] | [INFO] [stderr] 379 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:391:26 [INFO] [stderr] | [INFO] [stderr] 391 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:399:26 [INFO] [stderr] | [INFO] [stderr] 399 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:407:26 [INFO] [stderr] | [INFO] [stderr] 407 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:415:26 [INFO] [stderr] | [INFO] [stderr] 415 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:423:26 [INFO] [stderr] | [INFO] [stderr] 423 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:431:26 [INFO] [stderr] | [INFO] [stderr] 431 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:439:26 [INFO] [stderr] | [INFO] [stderr] 439 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:447:26 [INFO] [stderr] | [INFO] [stderr] 447 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | uniparc_xref_idx: uniparc_xref_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_xref_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | property_idx: property_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `property_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:323:26 [INFO] [stderr] | [INFO] [stderr] 323 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:331:26 [INFO] [stderr] | [INFO] [stderr] 331 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:339:26 [INFO] [stderr] | [INFO] [stderr] 339 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:347:26 [INFO] [stderr] | [INFO] [stderr] 347 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:363:26 [INFO] [stderr] | [INFO] [stderr] 363 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:371:26 [INFO] [stderr] | [INFO] [stderr] 371 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:379:26 [INFO] [stderr] | [INFO] [stderr] 379 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:391:26 [INFO] [stderr] | [INFO] [stderr] 391 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:399:26 [INFO] [stderr] | [INFO] [stderr] 399 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:407:26 [INFO] [stderr] | [INFO] [stderr] 407 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:415:26 [INFO] [stderr] | [INFO] [stderr] 415 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:423:26 [INFO] [stderr] | [INFO] [stderr] 423 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:431:26 [INFO] [stderr] | [INFO] [stderr] 431 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:439:26 [INFO] [stderr] | [INFO] [stderr] 439 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:447:26 [INFO] [stderr] | [INFO] [stderr] 447 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:232:10 [INFO] [stderr] | [INFO] [stderr] 232 | let (mut property, mut uniparc_xref2property) = match attr_type.as_ref() { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:232:24 [INFO] [stderr] | [INFO] [stderr] 232 | let (mut property, mut uniparc_xref2property) = match attr_type.as_ref() { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:220:32 [INFO] [stderr] | [INFO] [stderr] 220 | uniparc_xrefs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | / if !property.contains_key(&attr_value) { [INFO] [stderr] 251 | | property_idx = (property.len() + 1) as i32; [INFO] [stderr] 252 | | property.insert(attr_value, property_idx); [INFO] [stderr] 253 | | } else { [INFO] [stderr] 254 | | property_idx = *property.get(&attr_value).unwrap(); [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____^ help: consider using: `property.entry(attr_value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:283:31 [INFO] [stderr] | [INFO] [stderr] 283 | uniparc_xrefs: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:232:24 [INFO] [stderr] | [INFO] [stderr] 232 | let (mut property, mut uniparc_xref2property) = match attr_type.as_ref() { [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:232:10 [INFO] [stderr] | [INFO] [stderr] 232 | let (mut property, mut uniparc_xref2property) = match attr_type.as_ref() { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:506:17 [INFO] [stderr] | [INFO] [stderr] 506 | / match name.local_name.as_ref() { [INFO] [stderr] 507 | | "entry" => { [INFO] [stderr] 508 | | println!("Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] 509 | | uniparc.id, [INFO] [stderr] ... | [INFO] [stderr] 515 | | _ => {} [INFO] [stderr] 516 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 506 | if let "entry" = name.local_name.as_ref() { [INFO] [stderr] 507 | println!("Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] 508 | uniparc.id, [INFO] [stderr] 509 | uniparc.sequence); [INFO] [stderr] 510 | write_entry(&mut handlers, &uniparc, &uniparc_xrefs); [INFO] [stderr] 511 | write_properties(&mut handlers, &properties, uniparc.id.clone()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:220:32 [INFO] [stderr] | [INFO] [stderr] 220 | uniparc_xrefs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | / if !property.contains_key(&attr_value) { [INFO] [stderr] 251 | | property_idx = (property.len() + 1) as i32; [INFO] [stderr] 252 | | property.insert(attr_value, property_idx); [INFO] [stderr] 253 | | } else { [INFO] [stderr] 254 | | property_idx = *property.get(&attr_value).unwrap(); [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____^ help: consider using: `property.entry(attr_value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:283:31 [INFO] [stderr] | [INFO] [stderr] 283 | uniparc_xrefs: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:506:17 [INFO] [stderr] | [INFO] [stderr] 506 | / match name.local_name.as_ref() { [INFO] [stderr] 507 | | "entry" => { [INFO] [stderr] 508 | | println!("Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] 509 | | uniparc.id, [INFO] [stderr] ... | [INFO] [stderr] 515 | | _ => {} [INFO] [stderr] 516 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 506 | if let "entry" = name.local_name.as_ref() { [INFO] [stderr] 507 | println!("Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] 508 | uniparc.id, [INFO] [stderr] 509 | uniparc.sequence); [INFO] [stderr] 510 | write_entry(&mut handlers, &uniparc, &uniparc_xrefs); [INFO] [stderr] 511 | write_properties(&mut handlers, &properties, uniparc.id.clone()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "9097c69c0d4b2ee619a524c2ec1ecf96ca05bd5480482ddb041f098f3c418100"` [INFO] running `"docker" "rm" "-f" "9097c69c0d4b2ee619a524c2ec1ecf96ca05bd5480482ddb041f098f3c418100"` [INFO] [stdout] 9097c69c0d4b2ee619a524c2ec1ecf96ca05bd5480482ddb041f098f3c418100