[INFO] crate bigmaths 0.0.2 is already in cache [INFO] extracting crate bigmaths 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/bigmaths/0.0.2 [INFO] extracting crate bigmaths 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bigmaths/0.0.2 [INFO] validating manifest of bigmaths-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bigmaths-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bigmaths-0.0.2 [INFO] finished frobbing bigmaths-0.0.2 [INFO] frobbed toml for bigmaths-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/bigmaths/0.0.2/Cargo.toml [INFO] started frobbing bigmaths-0.0.2 [INFO] finished frobbing bigmaths-0.0.2 [INFO] frobbed toml for bigmaths-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bigmaths/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bigmaths-0.0.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bigmaths/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 76303ce4663b7cddc9ec83e1f5f9dfeae60a3a6720ddb8db895d97f98cf6ea6c [INFO] running `"docker" "start" "-a" "76303ce4663b7cddc9ec83e1f5f9dfeae60a3a6720ddb8db895d97f98cf6ea6c"` [INFO] [stderr] Checking bigmaths v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | modulus: modulus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modulus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | modulus: modulus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modulus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | modulus: modulus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modulus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:207:25 [INFO] [stderr] | [INFO] [stderr] 207 | modulus: modulus, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `modulus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if self.sign == Sign::Negative { [INFO] [stderr] 53 | | let modulus_max = (std::isize::MAX as usize) + 1; [INFO] [stderr] 54 | | [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if self.sign == Sign::Negative { [INFO] [stderr] 52 | let modulus_max = (std::isize::MAX as usize) + 1; [INFO] [stderr] 53 | [INFO] [stderr] 54 | if self.modulus[0] > modulus_max { [INFO] [stderr] 55 | None [INFO] [stderr] 56 | } else if self.modulus[0] == modulus_max { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | self.sign.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sign` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | sign : match num.is_negative() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 98 | | true => Sign::Negative, [INFO] [stderr] 99 | | false => Sign::Positive, [INFO] [stderr] 100 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if num.is_negative() { Sign::Negative } else { Sign::Positive }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:189:106 [INFO] [stderr] | [INFO] [stderr] 189 | let (mut modulus, final_carry) = limb_pairs_iter.fold((Vec::with_capacity(self.len() + 1), false), |(mut limbs, carry), (&self_limb, &other_limb)| { [INFO] [stderr] | ^ [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if self.sign == Sign::Negative { [INFO] [stderr] 53 | | let modulus_max = (std::isize::MAX as usize) + 1; [INFO] [stderr] 54 | | [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if self.sign == Sign::Negative { [INFO] [stderr] 52 | let modulus_max = (std::isize::MAX as usize) + 1; [INFO] [stderr] 53 | [INFO] [stderr] 54 | if self.modulus[0] > modulus_max { [INFO] [stderr] 55 | None [INFO] [stderr] 56 | } else if self.modulus[0] == modulus_max { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | assert!(final_carry == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!final_carry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bigmaths`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | self.sign.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sign` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | sign : match num.is_negative() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 98 | | true => Sign::Negative, [INFO] [stderr] 99 | | false => Sign::Positive, [INFO] [stderr] 100 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if num.is_negative() { Sign::Negative } else { Sign::Positive }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:189:106 [INFO] [stderr] | [INFO] [stderr] 189 | let (mut modulus, final_carry) = limb_pairs_iter.fold((Vec::with_capacity(self.len() + 1), false), |(mut limbs, carry), (&self_limb, &other_limb)| { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:203:29 [INFO] [stderr] | [INFO] [stderr] 203 | assert!(final_carry == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!final_carry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bigmaths`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "76303ce4663b7cddc9ec83e1f5f9dfeae60a3a6720ddb8db895d97f98cf6ea6c"` [INFO] running `"docker" "rm" "-f" "76303ce4663b7cddc9ec83e1f5f9dfeae60a3a6720ddb8db895d97f98cf6ea6c"` [INFO] [stdout] 76303ce4663b7cddc9ec83e1f5f9dfeae60a3a6720ddb8db895d97f98cf6ea6c