[INFO] crate bidrag 0.1.0 is already in cache [INFO] extracting crate bidrag 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bidrag/0.1.0 [INFO] extracting crate bidrag 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bidrag/0.1.0 [INFO] validating manifest of bidrag-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bidrag-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bidrag-0.1.0 [INFO] finished frobbing bidrag-0.1.0 [INFO] frobbed toml for bidrag-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bidrag/0.1.0/Cargo.toml [INFO] started frobbing bidrag-0.1.0 [INFO] finished frobbing bidrag-0.1.0 [INFO] frobbed toml for bidrag-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bidrag/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bidrag-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bidrag/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a06ae55da9f294a930233ebaba1428e5b20b64f36da54ecc329f7c0f1ac68717 [INFO] running `"docker" "start" "-a" "a06ae55da9f294a930233ebaba1428e5b20b64f36da54ecc329f7c0f1ac68717"` [INFO] [stderr] Checking bidrag v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::sync::mpsc::Receiver` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::sync::mpsc::Receiver; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | Binding::KBKey(key) => return self.keyBindings.get(&key), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keyBindings.get(&key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | Binding::MAxis(axis) => return Some(&self.mouseAxisBindings[axis as usize]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.mouseAxisBindings[axis as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | Binding::MButton(btn) => return Some(&self.mouseButtonBindings[btn as usize]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.mouseButtonBindings[btn as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | /// Even if we can't find a key for it, the show must go on! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | return self.axisNames[name]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.axisNames[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return self.axes[index][0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.axes[index][0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return self.axes[index][1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.axes[index][1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return self.get(index) - self.get_prev(index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(index) - self.get_prev(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | _ => panic!("NOT YET IMPLEMENTED!") [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `keyBindings` should have a snake case name such as `key_bindings` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | keyBindings: BTreeMap>, // TODO: Seems like this one could be optimized [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `mouseButtonBindings` should have a snake case name such as `mouse_button_bindings` [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | mouseButtonBindings: [Vec; NUM_MOUSE_BUTTONS], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `mouseAxisBindings` should have a snake case name such as `mouse_axis_bindings` [INFO] [stderr] --> src/lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | mouseAxisBindings: [Vec; 2] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `typeOf` should have a snake case name such as `type_of` [INFO] [stderr] --> src/lib.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | fn get_indicies(&self, typeOf: Binding) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:63:45 [INFO] [stderr] | [INFO] [stderr] 63 | self.keyBindings.insert(key.clone(), vec![index]); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: structure field `prevMousePos` should have a snake case name such as `prev_mouse_pos` [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | prevMousePos: (f64, f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `mouseSens` should have a snake case name such as `mouse_sens` [INFO] [stderr] --> src/lib.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | mouseSens: (f64, f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `axisNames` should have a snake case name such as `axis_names` [INFO] [stderr] --> src/lib.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | axisNames: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `axisBindings` should have a snake case name such as `axis_bindings` [INFO] [stderr] --> src/lib.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | axisBindings: BindingTree, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `mouseSens` should have a snake case name such as `mouse_sens` [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new(mouseSens: (f64, f64)) -> InputSubsystem { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `newVal` should have a snake case name such as `new_val` [INFO] [stderr] --> src/lib.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | let newVal = (axes.0 - self.prevMousePos.0) * self.mouseSens.1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `newVal` should have a snake case name such as `new_val` [INFO] [stderr] --> src/lib.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | let newVal = (axes.1 - self.prevMousePos.1) * self.mouseSens.1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `boundTo` should have a snake case name such as `bound_to` [INFO] [stderr] --> src/lib.rs:154:49 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn add_binding(&mut self, name: String, boundTo: Binding)-> usize { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:168:35 [INFO] [stderr] | [INFO] [stderr] 168 | pub fn get_index(&self, name: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::Receiver` [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::sync::mpsc::Receiver; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Range` [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ops::Range; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | Binding::KBKey(key) => return self.keyBindings.get(&key), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.keyBindings.get(&key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | Binding::MAxis(axis) => return Some(&self.mouseAxisBindings[axis as usize]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.mouseAxisBindings[axis as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | Binding::MButton(btn) => return Some(&self.mouseButtonBindings[btn as usize]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.mouseButtonBindings[btn as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | /// Even if we can't find a key for it, the show must go on! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return index; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | return self.axisNames[name]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.axisNames[name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return self.axes[index][0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.axes[index][0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return self.axes[index][1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.axes[index][1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return self.get(index) - self.get_prev(index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get(index) - self.get_prev(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/lib.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | _ => panic!("NOT YET IMPLEMENTED!") [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `keyBindings` should have a snake case name such as `key_bindings` [INFO] [stderr] --> src/lib.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | keyBindings: BTreeMap>, // TODO: Seems like this one could be optimized [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `mouseButtonBindings` should have a snake case name such as `mouse_button_bindings` [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | mouseButtonBindings: [Vec; NUM_MOUSE_BUTTONS], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `mouseAxisBindings` should have a snake case name such as `mouse_axis_bindings` [INFO] [stderr] --> src/lib.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | mouseAxisBindings: [Vec; 2] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `typeOf` should have a snake case name such as `type_of` [INFO] [stderr] --> src/lib.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | fn get_indicies(&self, typeOf: Binding) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:63:45 [INFO] [stderr] | [INFO] [stderr] 63 | self.keyBindings.insert(key.clone(), vec![index]); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: structure field `prevMousePos` should have a snake case name such as `prev_mouse_pos` [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | prevMousePos: (f64, f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `mouseSens` should have a snake case name such as `mouse_sens` [INFO] [stderr] --> src/lib.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | mouseSens: (f64, f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `axisNames` should have a snake case name such as `axis_names` [INFO] [stderr] --> src/lib.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | axisNames: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `axisBindings` should have a snake case name such as `axis_bindings` [INFO] [stderr] --> src/lib.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | axisBindings: BindingTree, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `mouseSens` should have a snake case name such as `mouse_sens` [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new(mouseSens: (f64, f64)) -> InputSubsystem { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `newVal` should have a snake case name such as `new_val` [INFO] [stderr] --> src/lib.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | let newVal = (axes.0 - self.prevMousePos.0) * self.mouseSens.1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `newVal` should have a snake case name such as `new_val` [INFO] [stderr] --> src/lib.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | let newVal = (axes.1 - self.prevMousePos.1) * self.mouseSens.1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `boundTo` should have a snake case name such as `bound_to` [INFO] [stderr] --> src/lib.rs:154:49 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn add_binding(&mut self, name: String, boundTo: Binding)-> usize { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:168:35 [INFO] [stderr] | [INFO] [stderr] 168 | pub fn get_index(&self, name: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "a06ae55da9f294a930233ebaba1428e5b20b64f36da54ecc329f7c0f1ac68717"` [INFO] running `"docker" "rm" "-f" "a06ae55da9f294a930233ebaba1428e5b20b64f36da54ecc329f7c0f1ac68717"` [INFO] [stdout] a06ae55da9f294a930233ebaba1428e5b20b64f36da54ecc329f7c0f1ac68717