[INFO] crate bencoders 0.1.0 is already in cache [INFO] extracting crate bencoders 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bencoders/0.1.0 [INFO] extracting crate bencoders 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bencoders/0.1.0 [INFO] validating manifest of bencoders-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bencoders-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bencoders-0.1.0 [INFO] finished frobbing bencoders-0.1.0 [INFO] frobbed toml for bencoders-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bencoders/0.1.0/Cargo.toml [INFO] started frobbing bencoders-0.1.0 [INFO] finished frobbing bencoders-0.1.0 [INFO] frobbed toml for bencoders-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bencoders/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bencoders-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bencoders/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85ce6ce467e36053de2ac6278a18dd8553c2252a8a60a1fbf712fcf257b25c5b [INFO] running `"docker" "start" "-a" "85ce6ce467e36053de2ac6278a18dd8553c2252a8a60a1fbf712fcf257b25c5b"` [INFO] [stderr] Checking bencoders v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | assert_eq!("spam".as_bytes(), &b[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"spam"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:102:20 [INFO] [stderr] | [INFO] [stderr] 102 | assert_eq!("".as_bytes(), &b[..]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match d.get(&b"count".to_vec()).unwrap() { [INFO] [stderr] 169 | | &Bencode::Int(i) => assert_eq!(12345, i), [INFO] [stderr] 170 | | _ => panic!("Wrong"), [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 168 | match *d.get(&b"count".to_vec()).unwrap() { [INFO] [stderr] 169 | Bencode::Int(i) => assert_eq!(12345, i), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:168:15 [INFO] [stderr] | [INFO] [stderr] 168 | match d.get(&b"count".to_vec()).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&d[&b"count".to_vec()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "85ce6ce467e36053de2ac6278a18dd8553c2252a8a60a1fbf712fcf257b25c5b"` [INFO] running `"docker" "rm" "-f" "85ce6ce467e36053de2ac6278a18dd8553c2252a8a60a1fbf712fcf257b25c5b"` [INFO] [stdout] 85ce6ce467e36053de2ac6278a18dd8553c2252a8a60a1fbf712fcf257b25c5b