[INFO] crate beautician 0.1.1 is already in cache [INFO] extracting crate beautician 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/beautician/0.1.1 [INFO] extracting crate beautician 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/beautician/0.1.1 [INFO] validating manifest of beautician-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of beautician-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing beautician-0.1.1 [INFO] finished frobbing beautician-0.1.1 [INFO] frobbed toml for beautician-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/beautician/0.1.1/Cargo.toml [INFO] started frobbing beautician-0.1.1 [INFO] finished frobbing beautician-0.1.1 [INFO] frobbed toml for beautician-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/beautician/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting beautician-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/beautician/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d19bec66294b8c010d6bedf89c1355755b30d4fa830e708bc9421cf81770ff93 [INFO] running `"docker" "start" "-a" "d19bec66294b8c010d6bedf89c1355755b30d4fa830e708bc9421cf81770ff93"` [INFO] [stderr] Checking beautician v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | const BUF: &'static [u8] = b" "; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / return match self.token.take() { [INFO] [stderr] 96 | | Some(json::JsonEvent::NullValue) => {try!(write!(dest, "null")); Ok(())}, [INFO] [stderr] 97 | | Some(json::JsonEvent::I64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 98 | | Some(json::JsonEvent::U64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] ... | [INFO] [stderr] 121 | | json::ErrorCode::EOFWhileParsingValue, 0, 0)), [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | match self.token.take() { [INFO] [stderr] 96 | Some(json::JsonEvent::NullValue) => {try!(write!(dest, "null")); Ok(())}, [INFO] [stderr] 97 | Some(json::JsonEvent::I64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 98 | Some(json::JsonEvent::U64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 99 | Some(json::JsonEvent::F64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 100 | Some(json::JsonEvent::BooleanValue(b)) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | const BUF: &'static [u8] = b" "; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / return match self.token.take() { [INFO] [stderr] 96 | | Some(json::JsonEvent::NullValue) => {try!(write!(dest, "null")); Ok(())}, [INFO] [stderr] 97 | | Some(json::JsonEvent::I64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 98 | | Some(json::JsonEvent::U64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] ... | [INFO] [stderr] 121 | | json::ErrorCode::EOFWhileParsingValue, 0, 0)), [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | match self.token.take() { [INFO] [stderr] 96 | Some(json::JsonEvent::NullValue) => {try!(write!(dest, "null")); Ok(())}, [INFO] [stderr] 97 | Some(json::JsonEvent::I64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 98 | Some(json::JsonEvent::U64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 99 | Some(json::JsonEvent::F64Value(n)) => {try!(write!(dest, "{}", n)); Ok(())}, [INFO] [stderr] 100 | Some(json::JsonEvent::BooleanValue(b)) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/lib.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{self,Read,Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | try!(wr.write(BUF)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | try!(wr.write(&BUF[..n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Prettifier` [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn new() -> Prettifier { [INFO] [stderr] 68 | | Prettifier { token: None, } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `beautician`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/lib.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{self,Read,Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | try!(wr.write(BUF)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | try!(wr.write(&BUF[..n])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Prettifier` [INFO] [stderr] --> src/lib.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / pub fn new() -> Prettifier { [INFO] [stderr] 68 | | Prettifier { token: None, } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `beautician`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d19bec66294b8c010d6bedf89c1355755b30d4fa830e708bc9421cf81770ff93"` [INFO] running `"docker" "rm" "-f" "d19bec66294b8c010d6bedf89c1355755b30d4fa830e708bc9421cf81770ff93"` [INFO] [stdout] d19bec66294b8c010d6bedf89c1355755b30d4fa830e708bc9421cf81770ff93