[INFO] crate bdf 0.5.5 is already in cache [INFO] extracting crate bdf 0.5.5 into work/ex/clippy-test-run/sources/stable/reg/bdf/0.5.5 [INFO] extracting crate bdf 0.5.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bdf/0.5.5 [INFO] validating manifest of bdf-0.5.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bdf-0.5.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bdf-0.5.5 [INFO] finished frobbing bdf-0.5.5 [INFO] frobbed toml for bdf-0.5.5 written to work/ex/clippy-test-run/sources/stable/reg/bdf/0.5.5/Cargo.toml [INFO] started frobbing bdf-0.5.5 [INFO] finished frobbing bdf-0.5.5 [INFO] frobbed toml for bdf-0.5.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bdf/0.5.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bdf-0.5.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bdf/0.5.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a60e8edd9484ceaeff17db43372fdce92cfcd19f8f71ee590c89dfb9f937afb7 [INFO] running `"docker" "start" "-a" "a60e8edd9484ceaeff17db43372fdce92cfcd19f8f71ee590c89dfb9f937afb7"` [INFO] [stderr] Checking bit-set v0.3.0 [INFO] [stderr] Checking bdf v0.5.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | font.set_size(font::Size { pt: pt, x: x, y: y }), [INFO] [stderr] | ^^^^^^ help: replace it with: `pt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:146:41 [INFO] [stderr] | [INFO] [stderr] 146 | font.set_size(font::Size { pt: pt, x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:146:47 [INFO] [stderr] | [INFO] [stderr] 146 | font.set_size(font::Size { pt: pt, x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | write!(self.stream, "STARTFONT {}\n", string), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | write!(self.stream, "COMMENT \"{}\"\n", string.replace("\"", "\"\"")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | write!(self.stream, "CONTENTVERSION {}\n", string), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | write!(self.stream, "FONT {}\n", string), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | write!(self.stream, "SIZE {} {} {}\n", pt, x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | write!(self.stream, "CHARS {}\n", chars), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | write!(self.stream, "FONTBOUNDINGBOX {} {} {} {}\n", bbx.width, bbx.height, bbx.x, bbx.y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | write!(self.stream, "ENDFONT\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | write!(self.stream, "STARTPROPERTIES {}\n", len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:58:7 [INFO] [stderr] | [INFO] [stderr] 58 | write!(self.stream, "{} \"{}\"\n", name, string.replace("\"", "\"\"")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | write!(self.stream, "{} {}\n", name, value), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | write!(self.stream, "ENDPROPERTIES\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | write!(self.stream, "STARTCHAR {}\n", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | write!(self.stream, "ENCODING {}\n", value as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | write!(self.stream, "METRICSSET 0\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:79:7 [INFO] [stderr] | [INFO] [stderr] 79 | write!(self.stream, "METRICSSET 1\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | write!(self.stream, "METRICSSET 2\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | write!(self.stream, "SWIDTH {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | write!(self.stream, "DWIDTH {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | write!(self.stream, "SWIDTH1 {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | write!(self.stream, "DWIDTH1 {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | write!(self.stream, "VVECTOR {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | write!(self.stream, "BBX {} {} {} {}\n", bbx.width, bbx.height, bbx.x, bbx.y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | write!(self.stream, "BITMAP\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | write!(self.stream, "ENDCHAR\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:25:4 [INFO] [stderr] | [INFO] [stderr] 25 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitmap.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | font.set_size(font::Size { pt: pt, x: x, y: y }), [INFO] [stderr] | ^^^^^^ help: replace it with: `pt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:146:41 [INFO] [stderr] | [INFO] [stderr] 146 | font.set_size(font::Size { pt: pt, x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader/mod.rs:146:47 [INFO] [stderr] | [INFO] [stderr] 146 | font.set_size(font::Size { pt: pt, x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | write!(self.stream, "STARTFONT {}\n", string), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | write!(self.stream, "COMMENT \"{}\"\n", string.replace("\"", "\"\"")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | write!(self.stream, "CONTENTVERSION {}\n", string), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | write!(self.stream, "FONT {}\n", string), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | write!(self.stream, "SIZE {} {} {}\n", pt, x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | write!(self.stream, "CHARS {}\n", chars), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | write!(self.stream, "FONTBOUNDINGBOX {} {} {} {}\n", bbx.width, bbx.height, bbx.x, bbx.y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | write!(self.stream, "ENDFONT\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | write!(self.stream, "STARTPROPERTIES {}\n", len), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:58:7 [INFO] [stderr] | [INFO] [stderr] 58 | write!(self.stream, "{} \"{}\"\n", name, string.replace("\"", "\"\"")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | write!(self.stream, "{} {}\n", name, value), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | write!(self.stream, "ENDPROPERTIES\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | write!(self.stream, "STARTCHAR {}\n", name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | write!(self.stream, "ENCODING {}\n", value as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | write!(self.stream, "METRICSSET 0\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:79:7 [INFO] [stderr] | [INFO] [stderr] 79 | write!(self.stream, "METRICSSET 1\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | write!(self.stream, "METRICSSET 2\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | write!(self.stream, "SWIDTH {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | write!(self.stream, "DWIDTH {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | write!(self.stream, "SWIDTH1 {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | write!(self.stream, "DWIDTH1 {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | write!(self.stream, "VVECTOR {} {}\n", x, y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | write!(self.stream, "BBX {} {} {} {}\n", bbx.width, bbx.height, bbx.x, bbx.y), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | write!(self.stream, "BITMAP\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/writer/writer.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | write!(self.stream, "ENDCHAR\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/bitmap.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | self.bits.contains(((y * self.width + x) as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bitmap.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | self.bits.contains(((y * self.width + x) as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/bitmap.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | self.bits.remove(((y * self.width + x) as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bitmap.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | self.bits.remove(((y * self.width + x) as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/reader/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod reader; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/writer/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod writer; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/bitmap.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | self.bits.contains(((y * self.width + x) as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bitmap.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | self.bits.contains(((y * self.width + x) as usize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/bitmap.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | self.bits.remove(((y * self.width + x) as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bitmap.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | self.bits.remove(((y * self.width + x) as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/reader/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod reader; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/writer/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod writer; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | &Error::IO(ref err) => [INFO] [stderr] 62 | | err.description(), [INFO] [stderr] 63 | | [INFO] [stderr] ... | [INFO] [stderr] 89 | | "Malformed character definition.", [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | Error::IO(ref err) => [INFO] [stderr] 62 | err.description(), [INFO] [stderr] 63 | [INFO] [stderr] 64 | Error::Parse(ref err) => [INFO] [stderr] 65 | error::Error::description(err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer/writer.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | match entry { [INFO] [stderr] | _________^ [INFO] [stderr] 28 | | &Entry::StartFont(ref string) => [INFO] [stderr] 29 | | write!(self.stream, "STARTFONT {}\n", string), [INFO] [stderr] 30 | | [INFO] [stderr] ... | [INFO] [stderr] 130 | | unreachable!(), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *entry { [INFO] [stderr] 28 | Entry::StartFont(ref string) => [INFO] [stderr] 29 | write!(self.stream, "STARTFONT {}\n", string), [INFO] [stderr] 30 | [INFO] [stderr] 31 | Entry::Comment(ref string) => [INFO] [stderr] 32 | write!(self.stream, "COMMENT \"{}\"\n", string.replace("\"", "\"\"")), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer/writer.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | match value { [INFO] [stderr] | _________________^ [INFO] [stderr] 57 | | &Property::String(ref string) => [INFO] [stderr] 58 | | write!(self.stream, "{} \"{}\"\n", name, string.replace("\"", "\"\"")), [INFO] [stderr] 59 | | [INFO] [stderr] 60 | | &Property::Integer(value) => [INFO] [stderr] 61 | | write!(self.stream, "{} {}\n", name, value), [INFO] [stderr] 62 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *value { [INFO] [stderr] 57 | Property::String(ref string) => [INFO] [stderr] 58 | write!(self.stream, "{} \"{}\"\n", name, string.replace("\"", "\"\"")), [INFO] [stderr] 59 | [INFO] [stderr] 60 | Property::Integer(value) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:40:44 [INFO] [stderr] | [INFO] [stderr] 40 | try!(writer.entry(&Entry::FontBoundingBox(font.bounds().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*font.bounds()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | try!(writer.entry(&Entry::Direction(font.direction().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `font.direction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/mod.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | if font.properties().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!font.properties().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:84:40 [INFO] [stderr] | [INFO] [stderr] 84 | try!(writer.entry(&Entry::Direction(glyph.direction().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `glyph.direction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:107:41 [INFO] [stderr] | [INFO] [stderr] 107 | try!(writer.entry(&Entry::BoundingBox(glyph.bounds().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*glyph.bounds()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | &Error::IO(ref err) => [INFO] [stderr] 62 | | err.description(), [INFO] [stderr] 63 | | [INFO] [stderr] ... | [INFO] [stderr] 89 | | "Malformed character definition.", [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | Error::IO(ref err) => [INFO] [stderr] 62 | err.description(), [INFO] [stderr] 63 | [INFO] [stderr] 64 | Error::Parse(ref err) => [INFO] [stderr] 65 | error::Error::description(err), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer/writer.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | match entry { [INFO] [stderr] | _________^ [INFO] [stderr] 28 | | &Entry::StartFont(ref string) => [INFO] [stderr] 29 | | write!(self.stream, "STARTFONT {}\n", string), [INFO] [stderr] 30 | | [INFO] [stderr] ... | [INFO] [stderr] 130 | | unreachable!(), [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *entry { [INFO] [stderr] 28 | Entry::StartFont(ref string) => [INFO] [stderr] 29 | write!(self.stream, "STARTFONT {}\n", string), [INFO] [stderr] 30 | [INFO] [stderr] 31 | Entry::Comment(ref string) => [INFO] [stderr] 32 | write!(self.stream, "COMMENT \"{}\"\n", string.replace("\"", "\"\"")), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer/writer.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | match value { [INFO] [stderr] | _________________^ [INFO] [stderr] 57 | | &Property::String(ref string) => [INFO] [stderr] 58 | | write!(self.stream, "{} \"{}\"\n", name, string.replace("\"", "\"\"")), [INFO] [stderr] 59 | | [INFO] [stderr] 60 | | &Property::Integer(value) => [INFO] [stderr] 61 | | write!(self.stream, "{} {}\n", name, value), [INFO] [stderr] 62 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *value { [INFO] [stderr] 57 | Property::String(ref string) => [INFO] [stderr] 58 | write!(self.stream, "{} \"{}\"\n", name, string.replace("\"", "\"\"")), [INFO] [stderr] 59 | [INFO] [stderr] 60 | Property::Integer(value) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:40:44 [INFO] [stderr] | [INFO] [stderr] 40 | try!(writer.entry(&Entry::FontBoundingBox(font.bounds().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*font.bounds()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | try!(writer.entry(&Entry::Direction(font.direction().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `font.direction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/writer/mod.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | if font.properties().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!font.properties().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:84:40 [INFO] [stderr] | [INFO] [stderr] 84 | try!(writer.entry(&Entry::Direction(glyph.direction().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `glyph.direction()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/writer/mod.rs:107:41 [INFO] [stderr] | [INFO] [stderr] 107 | try!(writer.entry(&Entry::BoundingBox(glyph.bounds().clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*glyph.bounds()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> examples/draw.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> examples/draw.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> examples/draw.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.87s [INFO] running `"docker" "inspect" "a60e8edd9484ceaeff17db43372fdce92cfcd19f8f71ee590c89dfb9f937afb7"` [INFO] running `"docker" "rm" "-f" "a60e8edd9484ceaeff17db43372fdce92cfcd19f8f71ee590c89dfb9f937afb7"` [INFO] [stdout] a60e8edd9484ceaeff17db43372fdce92cfcd19f8f71ee590c89dfb9f937afb7