[INFO] crate base58 0.1.0 is already in cache [INFO] extracting crate base58 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/base58/0.1.0 [INFO] extracting crate base58 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base58/0.1.0 [INFO] validating manifest of base58-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of base58-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing base58-0.1.0 [INFO] finished frobbing base58-0.1.0 [INFO] frobbed toml for base58-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/base58/0.1.0/Cargo.toml [INFO] started frobbing base58-0.1.0 [INFO] finished frobbing base58-0.1.0 [INFO] frobbed toml for base58-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base58/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting base58-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/base58/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c29f7b5892decdf92f0605c82023b517d25b1ddb3b368629d8129a4382add4b6 [INFO] running `"docker" "start" "-a" "c29f7b5892decdf92f0605c82023b517d25b1ddb3b368629d8129a4382add4b6"` [INFO] [stderr] Checking base58 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | const ALPHABET: &'static [u8] = b"123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const B58_DIGITS_MAP: &'static [i8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | _ => 0xffffffff << (bytesleft * 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:117:14 [INFO] [stderr] | [INFO] [stderr] 117 | c = (t & 0x3f00000000) >> 32; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x003f_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | out[j] = (t & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | 3 => ((out[0] & 0xff0000) >> 16) as u8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | const ALPHABET: &'static [u8] = b"123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const B58_DIGITS_MAP: &'static [i8] = &[ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | _ => 0xffffffff << (bytesleft * 8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:117:14 [INFO] [stderr] | [INFO] [stderr] 117 | c = (t & 0x3f00000000) >> 32; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x003f_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | out[j] = (t & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | 3 => ((out[0] & 0xff0000) >> 16) as u8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let mut carry = self[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(self[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | carry += 256 * buffer[j] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | let t = out[j] as u64 * 58 + c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(out[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `out[j]` [INFO] [stderr] --> src/lib.rs:154:18 [INFO] [stderr] | [INFO] [stderr] 154 | bin[i + 3] = ((out[j] >> 0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | let mut carry = self[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(self[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | carry += 256 * buffer[j] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buffer[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | let t = out[j] as u64 * 58 + c; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(out[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `out[j]` [INFO] [stderr] --> src/lib.rs:154:18 [INFO] [stderr] | [INFO] [stderr] 154 | bin[i + 3] = ((out[j] >> 0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "c29f7b5892decdf92f0605c82023b517d25b1ddb3b368629d8129a4382add4b6"` [INFO] running `"docker" "rm" "-f" "c29f7b5892decdf92f0605c82023b517d25b1ddb3b368629d8129a4382add4b6"` [INFO] [stdout] c29f7b5892decdf92f0605c82023b517d25b1ddb3b368629d8129a4382add4b6