[INFO] crate barrel 0.4.0 is already in cache
[INFO] extracting crate barrel 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/barrel/0.4.0
[INFO] extracting crate barrel 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/barrel/0.4.0
[INFO] validating manifest of barrel-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of barrel-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing barrel-0.4.0
[INFO] removed 2 missing examples
[INFO] finished frobbing barrel-0.4.0
[INFO] frobbed toml for barrel-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/barrel/0.4.0/Cargo.toml
[INFO] started frobbing barrel-0.4.0
[INFO] removed 2 missing examples
[INFO] finished frobbing barrel-0.4.0
[INFO] frobbed toml for barrel-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/barrel/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting barrel-0.4.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/barrel/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fe9b96ec789873fa31df4185e237dea924759f6c8495df1bcf4a41de643dfa49
[INFO] running `"docker" "start" "-a" "fe9b96ec789873fa31df4185e237dea924759f6c8495df1bcf4a41de643dfa49"`
[INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other example targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a example target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/examples/sqlite_strings.rs
[INFO] [stderr] * /opt/crater/workdir/examples/pg_strings.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr]     Checking barrel v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/table.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 _type: _type,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/table.rs:113:13
[INFO] [stderr]     |
[INFO] [stderr] 113 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/table.rs:61:17
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 _type: _type,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/table.rs:113:13
[INFO] [stderr]     |
[INFO] [stderr] 113 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         return Table {
[INFO] [stderr] 29 | |             meta: TableMeta::new(name.into()),
[INFO] [stderr] 30 | |             changes: Vec::new(),
[INFO] [stderr] 31 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 28 |         Table {
[INFO] [stderr] 29 |             meta: TableMeta::new(name.into()),
[INFO] [stderr] 30 |             changes: Vec::new(),
[INFO] [stderr] 31 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 48 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 49 | |             _ => unreachable!(),
[INFO] [stderr] 50 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 47 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 48 |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 49 |             _ => unreachable!(),
[INFO] [stderr] 50 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 67 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 68 | |             _ => unreachable!(),
[INFO] [stderr] 69 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 66 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 67 |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 68 |             _ => unreachable!(),
[INFO] [stderr] 69 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/table.rs:89:21
[INFO] [stderr]    |
[INFO] [stderr] 89 |                     s
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/table.rs:88:33
[INFO] [stderr]    |
[INFO] [stderr] 88 |                     let mut s = T::add_column(ex, name, &col);
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 | /         return TableMeta {
[INFO] [stderr] 113 | |             name: name,
[INFO] [stderr] 114 | |             has_id: true,
[INFO] [stderr] 115 | |             encoding: "utf-8".to_owned(),
[INFO] [stderr] 116 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 112 |         TableMeta {
[INFO] [stderr] 113 |             name: name,
[INFO] [stderr] 114 |             has_id: true,
[INFO] [stderr] 115 |             encoding: "utf-8".to_owned(),
[INFO] [stderr] 116 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         return self.name.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.name.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:139:9
[INFO] [stderr]     |
[INFO] [stderr] 139 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 | /         return Column {
[INFO] [stderr] 168 | |             indexed: false,
[INFO] [stderr] 169 | |             unique: false,
[INFO] [stderr] 170 | |             nullable: false,
[INFO] [stderr] ...   |
[INFO] [stderr] 173 | |             def: None,
[INFO] [stderr] 174 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 167 |         Column {
[INFO] [stderr] 168 |             indexed: false,
[INFO] [stderr] 169 |             unique: false,
[INFO] [stderr] 170 |             nullable: false,
[INFO] [stderr] 171 |             increments: false,
[INFO] [stderr] 172 |             _type: t,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:180:9
[INFO] [stderr]     |
[INFO] [stderr] 180 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:186:9
[INFO] [stderr]     |
[INFO] [stderr] 186 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:194:9
[INFO] [stderr]     |
[INFO] [stderr] 194 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:213:9
[INFO] [stderr]     |
[INFO] [stderr] 213 |         return ColumnDefault::Text(data.into());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Text(data.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:219:9
[INFO] [stderr]     |
[INFO] [stderr] 219 |         return ColumnDefault::Integer(data);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Integer(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:225:9
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return ColumnDefault::Integer(data as i64);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Integer(data as i64)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return ColumnDefault::Integer(data as i64);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Integer(data as i64)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 |         return ColumnDefault::Float(data);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Float(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 |         return ColumnDefault::Boolean(data);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Boolean(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/migration.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         return Migration {
[INFO] [stderr] 33 | |             schema: String::new(),
[INFO] [stderr] 34 | |             changes: Vec::new(),
[INFO] [stderr] 35 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 32 |         Migration {
[INFO] [stderr] 33 |             schema: String::new(),
[INFO] [stderr] 34 |             changes: Vec::new(),
[INFO] [stderr] 35 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/migration.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         return self;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/migration.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/migration.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 111 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 112 | |             _ => unreachable!(),
[INFO] [stderr] 113 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 110 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 111 |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 112 |             _ => unreachable!(),
[INFO] [stderr] 113 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/migration.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 131 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 132 | |             _ => unreachable!(),
[INFO] [stderr] 133 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 130 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 131 |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 132 |             _ => unreachable!(),
[INFO] [stderr] 133 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         return Table {
[INFO] [stderr] 29 | |             meta: TableMeta::new(name.into()),
[INFO] [stderr] 30 | |             changes: Vec::new(),
[INFO] [stderr] 31 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 28 |         Table {
[INFO] [stderr] 29 |             meta: TableMeta::new(name.into()),
[INFO] [stderr] 30 |             changes: Vec::new(),
[INFO] [stderr] 31 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 48 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 49 | |             _ => unreachable!(),
[INFO] [stderr] 50 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 47 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 48 |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 49 |             _ => unreachable!(),
[INFO] [stderr] 50 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 67 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 68 | |             _ => unreachable!(),
[INFO] [stderr] 69 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 66 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 67 |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 68 |             _ => unreachable!(),
[INFO] [stderr] 69 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/table.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/table.rs:89:21
[INFO] [stderr]    |
[INFO] [stderr] 89 |                     s
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/table.rs:88:33
[INFO] [stderr]    |
[INFO] [stderr] 88 |                     let mut s = T::add_column(ex, name, &col);
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 | /         return TableMeta {
[INFO] [stderr] 113 | |             name: name,
[INFO] [stderr] 114 | |             has_id: true,
[INFO] [stderr] 115 | |             encoding: "utf-8".to_owned(),
[INFO] [stderr] 116 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 112 |         TableMeta {
[INFO] [stderr] 113 |             name: name,
[INFO] [stderr] 114 |             has_id: true,
[INFO] [stderr] 115 |             encoding: "utf-8".to_owned(),
[INFO] [stderr] 116 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:121:9
[INFO] [stderr]     |
[INFO] [stderr] 121 |         return self.name.clone();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.name.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:139:9
[INFO] [stderr]     |
[INFO] [stderr] 139 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:167:9
[INFO] [stderr]     |
[INFO] [stderr] 167 | /         return Column {
[INFO] [stderr] 168 | |             indexed: false,
[INFO] [stderr] 169 | |             unique: false,
[INFO] [stderr] 170 | |             nullable: false,
[INFO] [stderr] ...   |
[INFO] [stderr] 173 | |             def: None,
[INFO] [stderr] 174 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 167 |         Column {
[INFO] [stderr] 168 |             indexed: false,
[INFO] [stderr] 169 |             unique: false,
[INFO] [stderr] 170 |             nullable: false,
[INFO] [stderr] 171 |             increments: false,
[INFO] [stderr] 172 |             _type: t,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:180:9
[INFO] [stderr]     |
[INFO] [stderr] 180 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:186:9
[INFO] [stderr]     |
[INFO] [stderr] 186 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:194:9
[INFO] [stderr]     |
[INFO] [stderr] 194 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:213:9
[INFO] [stderr]     |
[INFO] [stderr] 213 |         return ColumnDefault::Text(data.into());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Text(data.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:219:9
[INFO] [stderr]     |
[INFO] [stderr] 219 |         return ColumnDefault::Integer(data);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Integer(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:225:9
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return ColumnDefault::Integer(data as i64);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Integer(data as i64)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return ColumnDefault::Integer(data as i64);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Integer(data as i64)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 |         return ColumnDefault::Float(data);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Float(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/table.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 |         return ColumnDefault::Boolean(data);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ColumnDefault::Boolean(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/migration.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         return Migration {
[INFO] [stderr] 33 | |             schema: String::new(),
[INFO] [stderr] 34 | |             changes: Vec::new(),
[INFO] [stderr] 35 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 32 |         Migration {
[INFO] [stderr] 33 |             schema: String::new(),
[INFO] [stderr] 34 |             changes: Vec::new(),
[INFO] [stderr] 35 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/migration.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         return self;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/migration.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 |         return s;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/migration.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 111 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 112 | |             _ => unreachable!(),
[INFO] [stderr] 113 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 110 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 111 |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 112 |             _ => unreachable!(),
[INFO] [stderr] 113 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/migration.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 | /         return match self.changes.last_mut().unwrap() {
[INFO] [stderr] 131 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 132 | |             _ => unreachable!(),
[INFO] [stderr] 133 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 130 |         match self.changes.last_mut().unwrap() {
[INFO] [stderr] 131 |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 132 |             _ => unreachable!(),
[INFO] [stderr] 133 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/table.rs:47:16
[INFO] [stderr]    |
[INFO] [stderr] 47 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 48 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 49 | |             _ => unreachable!(),
[INFO] [stderr] 50 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 48 |             TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/table.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 67 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 68 | |             _ => unreachable!(),
[INFO] [stderr] 69 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 67 |             TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/table.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 |               s.push(match change {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 87 | |                 &mut AddColumn(ref name, ref col) => {
[INFO] [stderr] 88 | |                     let mut s = T::add_column(ex, name, &col);
[INFO] [stderr] 89 | |                     s
[INFO] [stderr] ...  |
[INFO] [stderr] 93 | |                 &mut ChangeColumn(ref mut name, _, _) => T::alter_table(name),
[INFO] [stderr] 94 | |             });
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |             s.push(match *change {
[INFO] [stderr] 87 |                 AddColumn(ref name, ref col) => {
[INFO] [stderr] 88 |                     let mut s = T::add_column(ex, name, &col);
[INFO] [stderr] 89 |                     s
[INFO] [stderr] 90 |                 }
[INFO] [stderr] 91 |                 DropColumn(ref name) => T::drop_column(name),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/table.rs:225:39
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return ColumnDefault::Integer(data as i64);
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: try: `i64::from(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:254:34
[INFO] [stderr]     |
[INFO] [stderr] 254 |                 Text(ref val) => format!("{}", val),
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/table.rs:258:37
[INFO] [stderr]     |
[INFO] [stderr] 258 |                   Boolean(ref val) => match val {
[INFO] [stderr]     |  _____________________________________^
[INFO] [stderr] 259 | |                     &true => format!("t"),
[INFO] [stderr] 260 | |                     &false => format!("f"),
[INFO] [stderr] 261 | |                 },
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 258 |                 Boolean(ref val) => match *val {
[INFO] [stderr] 259 |                     true => format!("t"),
[INFO] [stderr] 260 |                     false => format!("f"),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:259:30
[INFO] [stderr]     |
[INFO] [stderr] 259 |                     &true => format!("t"),
[INFO] [stderr]     |                              ^^^^^^^^^^^^ help: consider using .to_string(): `"t".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:260:31
[INFO] [stderr]     |
[INFO] [stderr] 260 |                     &false => format!("f"),
[INFO] [stderr]     |                               ^^^^^^^^^^^^ help: consider using .to_string(): `"f".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:262:40
[INFO] [stderr]     |
[INFO] [stderr] 262 |                 Foreign(ref val, _) => format!("{}", val),
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `migration::Migration`
[INFO] [stderr]   --> src/migration.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     pub fn new() -> Migration {
[INFO] [stderr] 32 | |         return Migration {
[INFO] [stderr] 33 | |             schema: String::new(),
[INFO] [stderr] 34 | |             changes: Vec::new(),
[INFO] [stderr] 35 | |         };
[INFO] [stderr] 36 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/migration.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 | /             match change {
[INFO] [stderr] 57 | |                 &mut CreateTable(ref mut t, ref mut cb) => {
[INFO] [stderr] 58 | |                     if t.meta.has_id {
[INFO] [stderr] 59 | |                         t.add_column("id", Type::Primary).increments();
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |                 _ => {}
[INFO] [stderr] 80 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 56 |             match *change {
[INFO] [stderr] 57 |                 CreateTable(ref mut t, ref mut cb) => {
[INFO] [stderr] 58 |                     if t.meta.has_id {
[INFO] [stderr] 59 |                         t.add_column("id", Type::Primary).increments();
[INFO] [stderr] 60 |                     }
[INFO] [stderr] 61 | 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/migration.rs:110:16
[INFO] [stderr]     |
[INFO] [stderr] 110 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 111 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 112 | |             _ => unreachable!(),
[INFO] [stderr] 113 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 110 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 111 |             DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/migration.rs:130:16
[INFO] [stderr]     |
[INFO] [stderr] 130 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 131 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 132 | |             _ => unreachable!(),
[INFO] [stderr] 133 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 130 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 131 |             DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/table.rs:47:16
[INFO] [stderr]    |
[INFO] [stderr] 47 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 48 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 49 | |             _ => unreachable!(),
[INFO] [stderr] 50 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 48 |             TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/table.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 67 | |             &mut TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr] 68 | |             _ => unreachable!(),
[INFO] [stderr] 69 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 67 |             TableChange::AddColumn(_, ref mut c) => c,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/table.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 |               s.push(match change {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 87 | |                 &mut AddColumn(ref name, ref col) => {
[INFO] [stderr] 88 | |                     let mut s = T::add_column(ex, name, &col);
[INFO] [stderr] 89 | |                     s
[INFO] [stderr] ...  |
[INFO] [stderr] 93 | |                 &mut ChangeColumn(ref mut name, _, _) => T::alter_table(name),
[INFO] [stderr] 94 | |             });
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 86 |             s.push(match *change {
[INFO] [stderr] 87 |                 AddColumn(ref name, ref col) => {
[INFO] [stderr] 88 |                     let mut s = T::add_column(ex, name, &col);
[INFO] [stderr] 89 |                     s
[INFO] [stderr] 90 |                 }
[INFO] [stderr] 91 |                 DropColumn(ref name) => T::drop_column(name),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]    --> src/table.rs:225:39
[INFO] [stderr]     |
[INFO] [stderr] 225 |         return ColumnDefault::Integer(data as i64);
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: try: `i64::from(data)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:254:34
[INFO] [stderr]     |
[INFO] [stderr] 254 |                 Text(ref val) => format!("{}", val),
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/table.rs:258:37
[INFO] [stderr]     |
[INFO] [stderr] 258 |                   Boolean(ref val) => match val {
[INFO] [stderr]     |  _____________________________________^
[INFO] [stderr] 259 | |                     &true => format!("t"),
[INFO] [stderr] 260 | |                     &false => format!("f"),
[INFO] [stderr] 261 | |                 },
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 258 |                 Boolean(ref val) => match *val {
[INFO] [stderr] 259 |                     true => format!("t"),
[INFO] [stderr] 260 |                     false => format!("f"),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:259:30
[INFO] [stderr]     |
[INFO] [stderr] 259 |                     &true => format!("t"),
[INFO] [stderr]     |                              ^^^^^^^^^^^^ help: consider using .to_string(): `"t".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:260:31
[INFO] [stderr]     |
[INFO] [stderr] 260 |                     &false => format!("f"),
[INFO] [stderr]     |                               ^^^^^^^^^^^^ help: consider using .to_string(): `"f".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/table.rs:262:40
[INFO] [stderr]     |
[INFO] [stderr] 262 |                 Foreign(ref val, _) => format!("{}", val),
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `migration::Migration`
[INFO] [stderr]   --> src/migration.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     pub fn new() -> Migration {
[INFO] [stderr] 32 | |         return Migration {
[INFO] [stderr] 33 | |             schema: String::new(),
[INFO] [stderr] 34 | |             changes: Vec::new(),
[INFO] [stderr] 35 | |         };
[INFO] [stderr] 36 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 23 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/migration.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 | /             match change {
[INFO] [stderr] 57 | |                 &mut CreateTable(ref mut t, ref mut cb) => {
[INFO] [stderr] 58 | |                     if t.meta.has_id {
[INFO] [stderr] 59 | |                         t.add_column("id", Type::Primary).increments();
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |                 _ => {}
[INFO] [stderr] 80 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 56 |             match *change {
[INFO] [stderr] 57 |                 CreateTable(ref mut t, ref mut cb) => {
[INFO] [stderr] 58 |                     if t.meta.has_id {
[INFO] [stderr] 59 |                         t.add_column("id", Type::Primary).increments();
[INFO] [stderr] 60 |                     }
[INFO] [stderr] 61 | 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/migration.rs:110:16
[INFO] [stderr]     |
[INFO] [stderr] 110 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 111 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 112 | |             _ => unreachable!(),
[INFO] [stderr] 113 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 110 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 111 |             DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/migration.rs:130:16
[INFO] [stderr]     |
[INFO] [stderr] 130 |           return match self.changes.last_mut().unwrap() {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 131 | |             &mut DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr] 132 | |             _ => unreachable!(),
[INFO] [stderr] 133 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 130 |         return match *self.changes.last_mut().unwrap() {
[INFO] [stderr] 131 |             DatabaseChange::CreateTable(ref mut t, _) => &mut t.meta,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.83s
[INFO] running `"docker" "inspect" "fe9b96ec789873fa31df4185e237dea924759f6c8495df1bcf4a41de643dfa49"`
[INFO] running `"docker" "rm" "-f" "fe9b96ec789873fa31df4185e237dea924759f6c8495df1bcf4a41de643dfa49"`
[INFO] [stdout] fe9b96ec789873fa31df4185e237dea924759f6c8495df1bcf4a41de643dfa49