[INFO] crate avr 0.0.2 is already in cache [INFO] extracting crate avr 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/avr/0.0.2 [INFO] extracting crate avr 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avr/0.0.2 [INFO] validating manifest of avr-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of avr-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing avr-0.0.2 [INFO] finished frobbing avr-0.0.2 [INFO] frobbed toml for avr-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/avr/0.0.2/Cargo.toml [INFO] started frobbing avr-0.0.2 [INFO] finished frobbing avr-0.0.2 [INFO] frobbed toml for avr-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avr/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting avr-0.0.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avr/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f705c14eef52cb887950109a0e5a845602510da49cb7a486b95d0585792ccc28 [INFO] running `"docker" "start" "-a" "f705c14eef52cb887950109a0e5a845602510da49cb7a486b95d0585792ccc28"` [INFO] [stderr] Checking avr v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mcu.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/regs.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | registers: registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/addons/uart.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | cpu_frequency: cpu_frequency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/addons/uart.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | baud: baud, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `baud` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/addons/uart.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | ticks_between_bits: ticks_between_bits, // TODO: set this variable [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ticks_between_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mcu.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | core: core, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/regs.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | registers: registers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mem.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/addons/uart.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | cpu_frequency: cpu_frequency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/addons/uart.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | baud: baud, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `baud` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/addons/uart.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | ticks_between_bits: ticks_between_bits, // TODO: set this variable [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ticks_between_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:369:22 [INFO] [stderr] | [INFO] [stderr] 369 | assert!(a <= 0b111111); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:380:22 [INFO] [stderr] | [INFO] [stderr] 380 | assert!(a <= 0b111111); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:617:29 [INFO] [stderr] | [INFO] [stderr] 617 | let is_carry = (val&0b100000000)>0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:629:34 [INFO] [stderr] | [INFO] [stderr] 629 | let is_negative = (val & 0b10000000)>0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | let opcode = ((bits & 0b1111111000000000) >> 5) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | (bits & 0b0000000000001111); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let rd = ((bits & 0b0000000111110000) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | 0b10010100011 => Some(Instruction::Inc(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | 0b10010101010 => Some(Instruction::Dec(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | 0b10010100000 => Some(Instruction::Com(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | 0b10010100001 => Some(Instruction::Neg(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | 0b10010011111 => Some(Instruction::Push(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | 0b10010001111 => Some(Instruction::Pop(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | 0b10010100010 => Some(Instruction::Swap(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | let opcode = (bits & 0b1111000000000000) >> 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | let mut rd = ((bits & 0b0000000011110000) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | let k = (((bits & 0b0000111100000000) >> 4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1111_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | ((bits & 0b0000000000001111) >> 0)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | let opcode = (bits & 0b1111110000000000) >> 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1100_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | let rd = ((bits & 0b0000000111110000) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | let rr = (((bits & 0b0000001000000000) >> 4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0010_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | (bits & 0b0000000000001111)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | 0b000011 => Some(Instruction::Add(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | 0b000111 => Some(Instruction::Adc(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | 0b000110 => Some(Instruction::Sub(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | 0b000010 => Some(Instruction::Sbc(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | 0b100111 => Some(Instruction::Mul(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | 0b001000 => Some(Instruction::And(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | 0b001010 => Some(Instruction::Or(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | 0b001001 => Some(Instruction::Eor(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | 0b000100 => Some(Instruction::Cpse(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | 0b000101 => Some(Instruction::Cp(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | 0b000001 => Some(Instruction::Cpc(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | 0b001011 => Some(Instruction::Mov(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | let subopcode = (bits & 0b100000000000) >> 11; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let reg = ((0b111110000 & bits) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | let a = (((0b11000000000 & bits) >> 5) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | let a = ((bits & 0b0000000011111000) >> 3) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | 0b10011010 => Some(Instruction::Sbi(a, b)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | 0b10011000 => Some(Instruction::Cbi(a, b)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:181:26 [INFO] [stderr] | [INFO] [stderr] 181 | let opcode = (bits & 0b1111111000000000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | 0b1001000 => Some(Instruction::Lpm(rd, 30, postinc)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:210:26 [INFO] [stderr] | [INFO] [stderr] 210 | let opcode = (bits & 0xfe000000) >> 25; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfe00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:213:26 [INFO] [stderr] | [INFO] [stderr] 213 | let mut k = ((bits & 0x1f00000) >> 20) | [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x01f0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | if opcode != 0b1001010 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:232:26 [INFO] [stderr] | [INFO] [stderr] 232 | let opcode = (bits & 0b1111111000000000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:238:10 [INFO] [stderr] | [INFO] [stderr] 238 | (0b1001001, 0b1100) => Some(Instruction::St(26, reg, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:239:10 [INFO] [stderr] | [INFO] [stderr] 239 | (0b1001001, 0b1101) => Some(Instruction::St(26, reg, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:240:10 [INFO] [stderr] | [INFO] [stderr] 240 | (0b1001001, 0b1110) => Some(Instruction::St(26, reg, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:241:10 [INFO] [stderr] | [INFO] [stderr] 241 | (0b1000001, 0b1000) => Some(Instruction::St(28, reg, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:242:10 [INFO] [stderr] | [INFO] [stderr] 242 | (0b1001001, 0b1001) => Some(Instruction::St(28, reg, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:243:10 [INFO] [stderr] | [INFO] [stderr] 243 | (0b1001001, 0b1010) => Some(Instruction::St(28, reg, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:244:10 [INFO] [stderr] | [INFO] [stderr] 244 | (0b1000001, 0b0000) => Some(Instruction::St(30, reg, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:245:10 [INFO] [stderr] | [INFO] [stderr] 245 | (0b1001001, 0b0001) => Some(Instruction::St(30, reg, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:246:10 [INFO] [stderr] | [INFO] [stderr] 246 | (0b1001001, 0b0010) => Some(Instruction::St(30, reg, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:248:10 [INFO] [stderr] | [INFO] [stderr] 248 | (0b1001000, 0b1100) => Some(Instruction::Ld(reg, 26, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:249:10 [INFO] [stderr] | [INFO] [stderr] 249 | (0b1001000, 0b1101) => Some(Instruction::Ld(reg, 26, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:250:10 [INFO] [stderr] | [INFO] [stderr] 250 | (0b1001000, 0b1110) => Some(Instruction::Ld(reg, 26, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:251:10 [INFO] [stderr] | [INFO] [stderr] 251 | (0b1000000, 0b1000) => Some(Instruction::Ld(reg, 28, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:252:10 [INFO] [stderr] | [INFO] [stderr] 252 | (0b1001000, 0b1001) => Some(Instruction::Ld(reg, 28, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:253:10 [INFO] [stderr] | [INFO] [stderr] 253 | (0b1001000, 0b1010) => Some(Instruction::Ld(reg, 28, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:254:10 [INFO] [stderr] | [INFO] [stderr] 254 | (0b1000000, 0b0000) => Some(Instruction::Ld(reg, 30, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:255:10 [INFO] [stderr] | [INFO] [stderr] 255 | (0b1001000, 0b0001) => Some(Instruction::Ld(reg, 30, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:256:10 [INFO] [stderr] | [INFO] [stderr] 256 | (0b1001000, 0b0010) => Some(Instruction::Ld(reg, 30, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/inst/binary/mod.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | let f = (bits & 0b0000_00010_0000_0000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0_0000_0010_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:306:18 [INFO] [stderr] | [INFO] [stderr] 306 | if opcode != 0b00000001 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:369:22 [INFO] [stderr] | [INFO] [stderr] 369 | assert!(a <= 0b111111); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:380:22 [INFO] [stderr] | [INFO] [stderr] 380 | assert!(a <= 0b111111); [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:617:29 [INFO] [stderr] | [INFO] [stderr] 617 | let is_carry = (val&0b100000000)>0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:629:34 [INFO] [stderr] | [INFO] [stderr] 629 | let is_negative = (val & 0b10000000)>0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | let opcode = ((bits & 0b1111111000000000) >> 5) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | (bits & 0b0000000000001111); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:79:23 [INFO] [stderr] | [INFO] [stderr] 79 | let rd = ((bits & 0b0000000111110000) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | 0b10010100011 => Some(Instruction::Inc(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | 0b10010101010 => Some(Instruction::Dec(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | 0b10010100000 => Some(Instruction::Com(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | 0b10010100001 => Some(Instruction::Neg(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | 0b10010011111 => Some(Instruction::Push(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | 0b10010001111 => Some(Instruction::Pop(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | 0b10010100010 => Some(Instruction::Swap(rd)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b100_1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | let opcode = (bits & 0b1111000000000000) >> 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:97:27 [INFO] [stderr] | [INFO] [stderr] 97 | let mut rd = ((bits & 0b0000000011110000) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | let k = (((bits & 0b0000111100000000) >> 4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1111_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | ((bits & 0b0000000000001111) >> 0)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | let opcode = (bits & 0b1111110000000000) >> 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1100_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | let rd = ((bits & 0b0000000111110000) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | let rr = (((bits & 0b0000001000000000) >> 4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0010_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | (bits & 0b0000000000001111)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | 0b000011 => Some(Instruction::Add(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | 0b000111 => Some(Instruction::Adc(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | 0b000110 => Some(Instruction::Sub(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | 0b000010 => Some(Instruction::Sbc(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | 0b100111 => Some(Instruction::Mul(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | 0b001000 => Some(Instruction::And(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | 0b001010 => Some(Instruction::Or(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | 0b001001 => Some(Instruction::Eor(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | 0b000100 => Some(Instruction::Cpse(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | 0b000101 => Some(Instruction::Cp(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | 0b000001 => Some(Instruction::Cpc(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | 0b001011 => Some(Instruction::Mov(rd, rr)), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | let subopcode = (bits & 0b100000000000) >> 11; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let reg = ((0b111110000 & bits) >> 4) as u8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | let a = (((0b11000000000 & bits) >> 5) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | let a = ((bits & 0b0000000011111000) >> 3) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | 0b10011010 => Some(Instruction::Sbi(a, b)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | 0b10011000 => Some(Instruction::Cbi(a, b)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:181:26 [INFO] [stderr] | [INFO] [stderr] 181 | let opcode = (bits & 0b1111111000000000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | 0b1001000 => Some(Instruction::Lpm(rd, 30, postinc)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:210:26 [INFO] [stderr] | [INFO] [stderr] 210 | let opcode = (bits & 0xfe000000) >> 25; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfe00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:213:26 [INFO] [stderr] | [INFO] [stderr] 213 | let mut k = ((bits & 0x1f00000) >> 20) | [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x01f0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | if opcode != 0b1001010 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:232:26 [INFO] [stderr] | [INFO] [stderr] 232 | let opcode = (bits & 0b1111111000000000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:238:10 [INFO] [stderr] | [INFO] [stderr] 238 | (0b1001001, 0b1100) => Some(Instruction::St(26, reg, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:239:10 [INFO] [stderr] | [INFO] [stderr] 239 | (0b1001001, 0b1101) => Some(Instruction::St(26, reg, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:240:10 [INFO] [stderr] | [INFO] [stderr] 240 | (0b1001001, 0b1110) => Some(Instruction::St(26, reg, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:241:10 [INFO] [stderr] | [INFO] [stderr] 241 | (0b1000001, 0b1000) => Some(Instruction::St(28, reg, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:242:10 [INFO] [stderr] | [INFO] [stderr] 242 | (0b1001001, 0b1001) => Some(Instruction::St(28, reg, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:243:10 [INFO] [stderr] | [INFO] [stderr] 243 | (0b1001001, 0b1010) => Some(Instruction::St(28, reg, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:244:10 [INFO] [stderr] | [INFO] [stderr] 244 | (0b1000001, 0b0000) => Some(Instruction::St(30, reg, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:245:10 [INFO] [stderr] | [INFO] [stderr] 245 | (0b1001001, 0b0001) => Some(Instruction::St(30, reg, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:246:10 [INFO] [stderr] | [INFO] [stderr] 246 | (0b1001001, 0b0010) => Some(Instruction::St(30, reg, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:248:10 [INFO] [stderr] | [INFO] [stderr] 248 | (0b1001000, 0b1100) => Some(Instruction::Ld(reg, 26, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:249:10 [INFO] [stderr] | [INFO] [stderr] 249 | (0b1001000, 0b1101) => Some(Instruction::Ld(reg, 26, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:250:10 [INFO] [stderr] | [INFO] [stderr] 250 | (0b1001000, 0b1110) => Some(Instruction::Ld(reg, 26, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:251:10 [INFO] [stderr] | [INFO] [stderr] 251 | (0b1000000, 0b1000) => Some(Instruction::Ld(reg, 28, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:252:10 [INFO] [stderr] | [INFO] [stderr] 252 | (0b1001000, 0b1001) => Some(Instruction::Ld(reg, 28, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:253:10 [INFO] [stderr] | [INFO] [stderr] 253 | (0b1001000, 0b1010) => Some(Instruction::Ld(reg, 28, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:254:10 [INFO] [stderr] | [INFO] [stderr] 254 | (0b1000000, 0b0000) => Some(Instruction::Ld(reg, 30, inst::Variant::Normal)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:255:10 [INFO] [stderr] | [INFO] [stderr] 255 | (0b1001000, 0b0001) => Some(Instruction::Ld(reg, 30, inst::Variant::Postincrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:256:10 [INFO] [stderr] | [INFO] [stderr] 256 | (0b1001000, 0b0010) => Some(Instruction::Ld(reg, 30, inst::Variant::Predecrement)), [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/inst/binary/mod.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | let f = (bits & 0b0000_00010_0000_0000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0_0000_0010_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/inst/binary/mod.rs:306:18 [INFO] [stderr] | [INFO] [stderr] 306 | if opcode != 0b00000001 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | let diff = self.do_rdi(rd, |d| d-imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:99:42 [INFO] [stderr] | [INFO] [stderr] 99 | let diff = self.do_rdi(rd, |d| d-imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | let product = (rd as u16) * (rr as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(rd)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:105:37 [INFO] [stderr] | [INFO] [stderr] 105 | let product = (rd as u16) * (rr as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(rr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:122:31 [INFO] [stderr] | [INFO] [stderr] 122 | self.do_rdi(rd, |d| d&imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:132:31 [INFO] [stderr] | [INFO] [stderr] 132 | self.do_rdi(rd, |d| d&imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | let rd_val = self.register_file.gpr_val(rd).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr_val(rd).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:208:22 [INFO] [stderr] | [INFO] [stderr] 208 | let rr_val = self.register_file.gpr_val(rr).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr_val(rr).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | let pc = self.pc as i32 + k as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:350:19 [INFO] [stderr] | [INFO] [stderr] 350 | self.pc = return_addr as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(return_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:371:39 [INFO] [stderr] | [INFO] [stderr] 371 | let offset = SRAM_IO_OFFSET + a as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:382:39 [INFO] [stderr] | [INFO] [stderr] 382 | let offset = SRAM_IO_OFFSET + a as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:419:68 [INFO] [stderr] | [INFO] [stderr] 419 | let addr = self.register_file.gpr_pair_val(ptr).unwrap() + imm as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:426:68 [INFO] [stderr] | [INFO] [stderr] 426 | let addr = self.register_file.gpr_pair_val(ptr).unwrap() + imm as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:435:21 [INFO] [stderr] | [INFO] [stderr] 435 | let bytes = self.program_space.bytes() [INFO] [stderr] | _____________________^ [INFO] [stderr] 436 | | .skip(self.pc as usize) [INFO] [stderr] 437 | | .map(|&a| a); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 435 | let bytes = self.program_space.bytes() [INFO] [stderr] 436 | .skip(self.pc as usize).cloned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:445:20 [INFO] [stderr] | [INFO] [stderr] 445 | self.pc += inst.size() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(inst.size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:527:22 [INFO] [stderr] | [INFO] [stderr] 527 | let rr_val = self.register_file.gpr(rr).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rr).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:529:22 [INFO] [stderr] | [INFO] [stderr] 529 | let rd_val = (*rd_reg) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from((*rd_reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:540:22 [INFO] [stderr] | [INFO] [stderr] 540 | let rd_val = *rd_reg as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*rd_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:552:25 [INFO] [stderr] | [INFO] [stderr] 552 | let rr_val_lo = self.register_file.gpr(rr).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rr).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:553:25 [INFO] [stderr] | [INFO] [stderr] 553 | let rr_val_hi = self.register_file.gpr(rr+1).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rr+1).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:556:25 [INFO] [stderr] | [INFO] [stderr] 556 | let rd_val_lo = self.register_file.gpr(rd).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rd).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:557:25 [INFO] [stderr] | [INFO] [stderr] 557 | let rd_val_hi = self.register_file.gpr(rd+1).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rd+1).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(val & 0x0f)` [INFO] [stderr] --> src/core.rs:561:22 [INFO] [stderr] | [INFO] [stderr] 561 | let val_lo = (val & 0x0f) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:571:48 [INFO] [stderr] | [INFO] [stderr] 571 | let memory_address = (SRAM_IO_OFFSET + a as u16) as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:581:32 [INFO] [stderr] | [INFO] [stderr] 581 | if f(sreg) { self.rjmp(k as i16)? }; [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/regs.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | let val = ((hi as u16) << 8) | lo as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/regs.rs:72:40 [INFO] [stderr] | [INFO] [stderr] 72 | let val = ((hi as u16) << 8) | lo as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(val & 0x00ff)` [INFO] [stderr] --> src/regs.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | let val_lo = ((val & 0x00ff) >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | let hi = self.get_u8(addr+0)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_u8(addr+0)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr` [INFO] [stderr] --> src/mem.rs:46:30 [INFO] [stderr] | [INFO] [stderr] 46 | let hi = self.get_u8(addr+0)? as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | let lo = self.get_u8(addr+1)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_u8(addr+1)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mem.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn bytes<'a>(&'a self) -> std::slice::Iter<'a,u8> { [INFO] [stderr] 53 | | self.data.iter() [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mem.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn bytes_mut<'a>(&'a mut self) -> std::slice::IterMut<'a,u8> { [INFO] [stderr] 57 | | self.data.iter_mut() [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | let bits16 = ((b2 as u16)<<8) | (b1 as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | let bits16 = ((b2 as u16)<<8) | (b1 as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | let b3 = bytes.next().unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | let b4 = bytes.next().unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | let bits32 = ((bits16 as u32) << 16) | (b4<<8) | (b3<<0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(bits16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `b3` [INFO] [stderr] --> src/inst/binary/mod.rs:20:54 [INFO] [stderr] | [INFO] [stderr] 20 | let bits32 = ((bits16 as u32) << 16) | (b4<<8) | (b3<<0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | let diff = self.do_rdi(rd, |d| d-imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:99:42 [INFO] [stderr] | [INFO] [stderr] 99 | let diff = self.do_rdi(rd, |d| d-imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bits & 0b0000000000001111)` [INFO] [stderr] --> src/inst/binary/mod.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | ((bits & 0b0000000000001111) >> 0)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | let product = (rd as u16) * (rr as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(rd)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:105:37 [INFO] [stderr] | [INFO] [stderr] 105 | let product = (rd as u16) * (rr as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(rr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0b1111 & bits)` [INFO] [stderr] --> src/inst/binary/mod.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | ((0b1111 & bits) >> 0)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:122:31 [INFO] [stderr] | [INFO] [stderr] 122 | self.do_rdi(rd, |d| d&imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:132:31 [INFO] [stderr] | [INFO] [stderr] 132 | self.do_rdi(rd, |d| d&imm as u16)?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bits & 0b0000_0000_0000_0111)` [INFO] [stderr] --> src/inst/binary/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | ((bits & 0b0000_0000_0000_0111) >> 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bits & 0x000f)` [INFO] [stderr] --> src/inst/binary/mod.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | let mut rr = (bits & 0x000f) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | let rd_val = self.register_file.gpr_val(rd).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr_val(rd).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:208:22 [INFO] [stderr] | [INFO] [stderr] 208 | let rr_val = self.register_file.gpr_val(rr).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr_val(rr).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | let pc = self.pc as i32 + k as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:350:19 [INFO] [stderr] | [INFO] [stderr] 350 | self.pc = return_addr as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(return_addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:371:39 [INFO] [stderr] | [INFO] [stderr] 371 | let offset = SRAM_IO_OFFSET + a as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:382:39 [INFO] [stderr] | [INFO] [stderr] 382 | let offset = SRAM_IO_OFFSET + a as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:419:68 [INFO] [stderr] | [INFO] [stderr] 419 | let addr = self.register_file.gpr_pair_val(ptr).unwrap() + imm as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:426:68 [INFO] [stderr] | [INFO] [stderr] 426 | let addr = self.register_file.gpr_pair_val(ptr).unwrap() + imm as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/core.rs:435:21 [INFO] [stderr] | [INFO] [stderr] 435 | let bytes = self.program_space.bytes() [INFO] [stderr] | _____________________^ [INFO] [stderr] 436 | | .skip(self.pc as usize) [INFO] [stderr] 437 | | .map(|&a| a); [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 435 | let bytes = self.program_space.bytes() [INFO] [stderr] 436 | .skip(self.pc as usize).cloned(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/sreg.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | pub const CARRY_FLAG: u8 = (1<<0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sreg::SReg` [INFO] [stderr] --> src/sreg.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | SReg(Register { [INFO] [stderr] 20 | | name: "SREG".into(), [INFO] [stderr] 21 | | value: 0, [INFO] [stderr] 22 | | }) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:445:20 [INFO] [stderr] | [INFO] [stderr] 445 | self.pc += inst.size() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(inst.size())` [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for sreg::SReg { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/sreg.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if state == true { self.0.value |= flag } else { self.0.value &= !flag }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:527:22 [INFO] [stderr] | [INFO] [stderr] 527 | let rr_val = self.register_file.gpr(rr).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rr).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:529:22 [INFO] [stderr] | [INFO] [stderr] 529 | let rd_val = (*rd_reg) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from((*rd_reg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:540:22 [INFO] [stderr] | [INFO] [stderr] 540 | let rd_val = *rd_reg as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*rd_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:552:25 [INFO] [stderr] | [INFO] [stderr] 552 | let rr_val_lo = self.register_file.gpr(rr).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rr).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:553:25 [INFO] [stderr] | [INFO] [stderr] 553 | let rr_val_hi = self.register_file.gpr(rr+1).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rr+1).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:556:25 [INFO] [stderr] | [INFO] [stderr] 556 | let rd_val_lo = self.register_file.gpr(rd).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rd).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:557:25 [INFO] [stderr] | [INFO] [stderr] 557 | let rd_val_hi = self.register_file.gpr(rd+1).unwrap() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_file.gpr(rd+1).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(val & 0x0f)` [INFO] [stderr] --> src/core.rs:561:22 [INFO] [stderr] | [INFO] [stderr] 561 | let val_lo = (val & 0x0f) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:571:48 [INFO] [stderr] | [INFO] [stderr] 571 | let memory_address = (SRAM_IO_OFFSET + a as u16) as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:581:32 [INFO] [stderr] | [INFO] [stderr] 581 | if f(sreg) { self.rjmp(k as i16)? }; [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/regs.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | let val = ((hi as u16) << 8) | lo as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/regs.rs:72:40 [INFO] [stderr] | [INFO] [stderr] 72 | let val = ((hi as u16) << 8) | lo as u16; [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(val & 0x00ff)` [INFO] [stderr] --> src/regs.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | let val_lo = ((val & 0x00ff) >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | let hi = self.get_u8(addr+0)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_u8(addr+0)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr` [INFO] [stderr] --> src/mem.rs:46:30 [INFO] [stderr] | [INFO] [stderr] 46 | let hi = self.get_u8(addr+0)? as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/mem.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | let lo = self.get_u8(addr+1)? as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.get_u8(addr+1)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mem.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn bytes<'a>(&'a self) -> std::slice::Iter<'a,u8> { [INFO] [stderr] 53 | | self.data.iter() [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mem.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn bytes_mut<'a>(&'a mut self) -> std::slice::IterMut<'a,u8> { [INFO] [stderr] 57 | | self.data.iter_mut() [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | let bits16 = ((b2 as u16)<<8) | (b1 as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | let bits16 = ((b2 as u16)<<8) | (b1 as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(b1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | let b3 = bytes.next().unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:18:14 [INFO] [stderr] | [INFO] [stderr] 18 | let b4 = bytes.next().unwrap() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/inst/binary/mod.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | let bits32 = ((bits16 as u32) << 16) | (b4<<8) | (b3<<0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(bits16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `b3` [INFO] [stderr] --> src/inst/binary/mod.rs:20:54 [INFO] [stderr] | [INFO] [stderr] 20 | let bits32 = ((bits16 as u32) << 16) | (b4<<8) | (b3<<0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bits & 0b0000000000001111)` [INFO] [stderr] --> src/inst/binary/mod.rs:99:19 [INFO] [stderr] | [INFO] [stderr] 99 | ((bits & 0b0000000000001111) >> 0)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(0b1111 & bits)` [INFO] [stderr] --> src/inst/binary/mod.rs:149:14 [INFO] [stderr] | [INFO] [stderr] 149 | ((0b1111 & bits) >> 0)) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bits & 0b0000_0000_0000_0111)` [INFO] [stderr] --> src/inst/binary/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | ((bits & 0b0000_0000_0000_0111) >> 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(bits & 0x000f)` [INFO] [stderr] --> src/inst/binary/mod.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | let mut rr = (bits & 0x000f) >> 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/sreg.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | pub const CARRY_FLAG: u8 = (1<<0); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sreg::SReg` [INFO] [stderr] --> src/sreg.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | SReg(Register { [INFO] [stderr] 20 | | name: "SREG".into(), [INFO] [stderr] 21 | | value: 0, [INFO] [stderr] 22 | | }) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for sreg::SReg { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/sreg.rs:29:12 [INFO] [stderr] | [INFO] [stderr] 29 | if state == true { self.0.value |= flag } else { self.0.value &= !flag }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tools/emulator.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | 16000000, // CPU frequency [INFO] [stderr] | ^^^^^^^^ help: consider: `16_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tools/emulator.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | 187000, // Baud rate [INFO] [stderr] | ^^^^^^ help: consider: `187_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tools/emulator.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | 16000000, // CPU frequency [INFO] [stderr] | ^^^^^^^^ help: consider: `16_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tools/emulator.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | 187000, // Baud rate [INFO] [stderr] | ^^^^^^ help: consider: `187_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `"docker" "inspect" "f705c14eef52cb887950109a0e5a845602510da49cb7a486b95d0585792ccc28"` [INFO] running `"docker" "rm" "-f" "f705c14eef52cb887950109a0e5a845602510da49cb7a486b95d0585792ccc28"` [INFO] [stdout] f705c14eef52cb887950109a0e5a845602510da49cb7a486b95d0585792ccc28