[INFO] crate avec 0.1.0 is already in cache [INFO] extracting crate avec 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/avec/0.1.0 [INFO] extracting crate avec 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avec/0.1.0 [INFO] validating manifest of avec-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of avec-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing avec-0.1.0 [INFO] finished frobbing avec-0.1.0 [INFO] frobbed toml for avec-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/avec/0.1.0/Cargo.toml [INFO] started frobbing avec-0.1.0 [INFO] finished frobbing avec-0.1.0 [INFO] frobbed toml for avec-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avec/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting avec-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/avec/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 662e28a0d7a29c6809bf4119856021d7091ac3436516a7634e2e467c6a596dc1 [INFO] running `"docker" "start" "-a" "662e28a0d7a29c6809bf4119856021d7091ac3436516a7634e2e467c6a596dc1"` [INFO] [stderr] Checking avec v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/avec.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | size : size, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/avec.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | start : start, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/avec.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | size : size, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/avec.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | size : size, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/avec.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | start : start, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/avec.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | size : size, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/avec.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | let mut data = &mut *self.data.get(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/avec.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let mut data = &mut *self.data.get(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/avec.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | let mut data = &mut *self.data.get(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/avec.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | let mut data = &mut *self.data.get(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: item `avec::AVecMapGuard<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/avec.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl<'a, T> AVecMapGuard<'a, T> { [INFO] [stderr] 48 | | [INFO] [stderr] 49 | | fn new(owner: &'a AVec, start: usize, size: usize) -> AVecMapGuard<'a, T> { [INFO] [stderr] 50 | | AVecMapGuard { [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: item `avec::AVecMapGuard<'a, T>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/avec.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / impl<'a, T> AVecMapGuard<'a, T> { [INFO] [stderr] 48 | | [INFO] [stderr] 49 | | fn new(owner: &'a AVec, start: usize, size: usize) -> AVecMapGuard<'a, T> { [INFO] [stderr] 50 | | AVecMapGuard { [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `avec::AVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/avec.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / impl AVec { [INFO] [stderr] 111 | | [INFO] [stderr] 112 | | /// Creates a new instance with given inital capacity [INFO] [stderr] 113 | | pub fn new(initial_capacity: usize) -> AVec { [INFO] [stderr] ... | [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `avec::AVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/avec.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / impl AVec { [INFO] [stderr] 111 | | [INFO] [stderr] 112 | | /// Creates a new instance with given inital capacity [INFO] [stderr] 113 | | pub fn new(initial_capacity: usize) -> AVec { [INFO] [stderr] ... | [INFO] [stderr] 281 | | } [INFO] [stderr] 282 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/avec.rs:120:27 [INFO] [stderr] | [INFO] [stderr] 120 | grow : Mutex::new(initial_capacity), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/avec.rs:120:27 [INFO] [stderr] | [INFO] [stderr] 120 | grow : Mutex::new(initial_capacity), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/avec.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn map<'a>(&'a self, size: usize) -> AVecMapGuard<'a, T> { [INFO] [stderr] 140 | | self.begin_write(); [INFO] [stderr] 141 | | let insert_pos = self.insert.fetch_add(size, Ordering::Relaxed); [INFO] [stderr] 142 | | let required_capacity = insert_pos + size; [INFO] [stderr] ... | [INFO] [stderr] 146 | | AVecMapGuard::new(&self, insert_pos, size) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/avec.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / pub fn map<'a>(&'a self, size: usize) -> AVecMapGuard<'a, T> { [INFO] [stderr] 140 | | self.begin_write(); [INFO] [stderr] 141 | | let insert_pos = self.insert.fetch_add(size, Ordering::Relaxed); [INFO] [stderr] 142 | | let required_capacity = insert_pos + size; [INFO] [stderr] ... | [INFO] [stderr] 146 | | AVecMapGuard::new(&self, insert_pos, size) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/avec.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | let mut guard = self.grow.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/avec.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | let mut guard = self.grow.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/avec.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / pub fn get<'a>(&'a self) -> AVecReadGuard<'a, T> { [INFO] [stderr] 188 | | self.begin_read(); [INFO] [stderr] 189 | | let size = self.insert.load(Ordering::SeqCst); [INFO] [stderr] 190 | | AVecReadGuard::new(&self, size) [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/avec.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / pub fn get<'a>(&'a self) -> AVecReadGuard<'a, T> { [INFO] [stderr] 188 | | self.begin_read(); [INFO] [stderr] 189 | | let size = self.insert.load(Ordering::SeqCst); [INFO] [stderr] 190 | | AVecReadGuard::new(&self, size) [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/avec.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | let mut guard = self.grow.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/avec.rs:200:25 [INFO] [stderr] | [INFO] [stderr] 200 | let mut guard = self.grow.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `"docker" "inspect" "662e28a0d7a29c6809bf4119856021d7091ac3436516a7634e2e467c6a596dc1"` [INFO] running `"docker" "rm" "-f" "662e28a0d7a29c6809bf4119856021d7091ac3436516a7634e2e467c6a596dc1"` [INFO] [stdout] 662e28a0d7a29c6809bf4119856021d7091ac3436516a7634e2e467c6a596dc1