[INFO] crate assert_float_eq 1.1.3 is already in cache [INFO] extracting crate assert_float_eq 1.1.3 into work/ex/clippy-test-run/sources/stable/reg/assert_float_eq/1.1.3 [INFO] extracting crate assert_float_eq 1.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assert_float_eq/1.1.3 [INFO] validating manifest of assert_float_eq-1.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of assert_float_eq-1.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing assert_float_eq-1.1.3 [INFO] finished frobbing assert_float_eq-1.1.3 [INFO] frobbed toml for assert_float_eq-1.1.3 written to work/ex/clippy-test-run/sources/stable/reg/assert_float_eq/1.1.3/Cargo.toml [INFO] started frobbing assert_float_eq-1.1.3 [INFO] finished frobbing assert_float_eq-1.1.3 [INFO] frobbed toml for assert_float_eq-1.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assert_float_eq/1.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting assert_float_eq-1.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assert_float_eq/1.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1809b1fda425da116ba25d33d100029892673040c7d68874df58247dc3142e99 [INFO] running `"docker" "start" "-a" "1809b1fda425da116ba25d33d100029892673040c7d68874df58247dc3142e99"` [INFO] [stderr] Checking assert_float_eq v1.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:25 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:31 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:37 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:43 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `previous` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:63 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:25 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:31 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:37 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:43 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `previous` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:309:63 [INFO] [stderr] | [INFO] [stderr] 309 | FloatNearError{ a: a, b: b, n: n, previous: previous, next: next } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | const U32_SIGN_MASK: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | const U32_EXPONENT_MASK: u32 = 0x7F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | const U32_HIDDEN_BIT: u32 = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | const U32_SIGNIFICAND_MASK: u32 = 0x007FFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | const U32_INFINITY: u32 = 0x7F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:155:37 [INFO] [stderr] | [INFO] [stderr] 155 | const U64_SIGN_MASK: u64 = 0x8000000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:156:37 [INFO] [stderr] | [INFO] [stderr] 156 | const U64_EXPONENT_MASK: u64 = 0x7FF0000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:157:37 [INFO] [stderr] | [INFO] [stderr] 157 | const U64_HIDDEN_BIT: u64 = 0x0010000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0010_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:158:37 [INFO] [stderr] | [INFO] [stderr] 158 | const U64_SIGNIFICAND_MASK: u64 = 0x000FFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x000F_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | const U64_INFINITY: u64 = 0x7FF0000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | const U32_SIGN_MASK: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | const U32_EXPONENT_MASK: u32 = 0x7F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:61:37 [INFO] [stderr] | [INFO] [stderr] 61 | const U32_HIDDEN_BIT: u32 = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:62:37 [INFO] [stderr] | [INFO] [stderr] 62 | const U32_SIGNIFICAND_MASK: u32 = 0x007FFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | const U32_INFINITY: u32 = 0x7F800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7F80_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:155:37 [INFO] [stderr] | [INFO] [stderr] 155 | const U64_SIGN_MASK: u64 = 0x8000000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:156:37 [INFO] [stderr] | [INFO] [stderr] 156 | const U64_EXPONENT_MASK: u64 = 0x7FF0000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:157:37 [INFO] [stderr] | [INFO] [stderr] 157 | const U64_HIDDEN_BIT: u64 = 0x0010000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0010_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:158:37 [INFO] [stderr] | [INFO] [stderr] 158 | const U64_SIGNIFICAND_MASK: u64 = 0x000FFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x000F_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | const U64_INFINITY: u64 = 0x7FF0000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7FF0_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | / match r { [INFO] [stderr] 325 | | true => Ok(()), [INFO] [stderr] 326 | | false => Err(err), [INFO] [stderr] 327 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if r { Ok(()) } else { Err(err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | / match r { [INFO] [stderr] 325 | | true => Ok(()), [INFO] [stderr] 326 | | false => Err(err), [INFO] [stderr] 327 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if r { Ok(()) } else { Err(err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "1809b1fda425da116ba25d33d100029892673040c7d68874df58247dc3142e99"` [INFO] running `"docker" "rm" "-f" "1809b1fda425da116ba25d33d100029892673040c7d68874df58247dc3142e99"` [INFO] [stdout] 1809b1fda425da116ba25d33d100029892673040c7d68874df58247dc3142e99