[INFO] crate assayer 0.2.2 is already in cache [INFO] extracting crate assayer 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/assayer/0.2.2 [INFO] extracting crate assayer 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assayer/0.2.2 [INFO] validating manifest of assayer-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of assayer-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing assayer-0.2.2 [INFO] finished frobbing assayer-0.2.2 [INFO] frobbed toml for assayer-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/assayer/0.2.2/Cargo.toml [INFO] started frobbing assayer-0.2.2 [INFO] finished frobbing assayer-0.2.2 [INFO] frobbed toml for assayer-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assayer/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting assayer-0.2.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/assayer/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de91b21e20ea108dd464c8a789870a3f1b001515c767941b95759247a7f4ba78 [INFO] running `"docker" "start" "-a" "de91b21e20ea108dd464c8a789870a3f1b001515c767941b95759247a7f4ba78"` [INFO] [stderr] Checking assayer v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | pub const MSG_ERR_VALIDATION_VALUE_EMPTY: &'static str = "Empty Value Error"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:12:51 [INFO] [stderr] | [INFO] [stderr] 12 | pub const MSG_ERR_VALIDATION_VALUE_OUT_OF_RANGE: &'static str = "Value Out of Range Error"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:13:46 [INFO] [stderr] | [INFO] [stderr] 13 | pub const MSG_ERR_VALIDATION_VALUE_INVALID: &'static str = "Invalid Value Error"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:14:41 [INFO] [stderr] | [INFO] [stderr] 14 | pub const MSG_ERR_VALIDATION_MULTIPLE: &'static str = "Multiple Validation Errors"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:11:44 [INFO] [stderr] | [INFO] [stderr] 11 | pub const MSG_ERR_VALIDATION_VALUE_EMPTY: &'static str = "Empty Value Error"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:12:51 [INFO] [stderr] | [INFO] [stderr] 12 | pub const MSG_ERR_VALIDATION_VALUE_OUT_OF_RANGE: &'static str = "Value Out of Range Error"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:13:46 [INFO] [stderr] | [INFO] [stderr] 13 | pub const MSG_ERR_VALIDATION_VALUE_INVALID: &'static str = "Invalid Value Error"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/consts/msgs/en_us.rs:14:41 [INFO] [stderr] | [INFO] [stderr] 14 | pub const MSG_ERR_VALIDATION_MULTIPLE: &'static str = "Multiple Validation Errors"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/unit_tests.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | .and_then(|input| match !input.is_empty() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 24 | | true => Ok(input), [INFO] [stderr] 25 | | false => Err(Error::ValueEmpty(MSG_ERR_VALIDATION_VALUE_EMPTY.to_string())), [INFO] [stderr] 26 | | }) [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if !input.is_empty() { Ok(input) } else { Err(Error::ValueEmpty(MSG_ERR_VALIDATION_VALUE_EMPTY.to_string())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "de91b21e20ea108dd464c8a789870a3f1b001515c767941b95759247a7f4ba78"` [INFO] running `"docker" "rm" "-f" "de91b21e20ea108dd464c8a789870a3f1b001515c767941b95759247a7f4ba78"` [INFO] [stdout] de91b21e20ea108dd464c8a789870a3f1b001515c767941b95759247a7f4ba78