[INFO] crate arthroprod 0.1.3 is already in cache [INFO] extracting crate arthroprod 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/arthroprod/0.1.3 [INFO] extracting crate arthroprod 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arthroprod/0.1.3 [INFO] validating manifest of arthroprod-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arthroprod-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arthroprod-0.1.3 [INFO] finished frobbing arthroprod-0.1.3 [INFO] frobbed toml for arthroprod-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/arthroprod/0.1.3/Cargo.toml [INFO] started frobbing arthroprod-0.1.3 [INFO] finished frobbing arthroprod-0.1.3 [INFO] frobbed toml for arthroprod-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arthroprod/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arthroprod-0.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arthroprod/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b9e97656d9d6bdac3b7a507bf7d5ad7f6613ffb5755195af1f8e6f3ad71ab88 [INFO] running `"docker" "start" "-a" "9b9e97656d9d6bdac3b7a507bf7d5ad7f6613ffb5755195af1f8e6f3ad71ab88"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking arthroprod v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/types.rs:142:62 [INFO] [stderr] | [INFO] [stderr] 142 | Component::Quadrivector(ref i, ref j, ref k, ref l) => write!(f, "{}{}{}{}", i, j, k, l), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types.rs:242:18 [INFO] [stderr] | [INFO] [stderr] 242 | _ => return Err(ArError::InvalidComponentOrder(String::from(ix))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ArError::InvalidComponentOrder(String::from(ix)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ops.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | return Alpha::from_index(&index, &sign); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Alpha::from_index(&index, &sign)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:94:25 [INFO] [stderr] | [INFO] [stderr] 94 | point = point + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `point += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | vectors = vectors + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vectors += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:99:22 [INFO] [stderr] | [INFO] [stderr] 99 | 2 => bivectors = bivectors + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bivectors += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | 3 => trivectors = trivectors + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trivectors += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | 4 => quadrivector = quadrivector + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quadrivector += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config.rs:121:51 [INFO] [stderr] | [INFO] [stderr] 121 | return Err(ArError::InvalidConfig(String::from(format!( [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 122 | | "ALLOWED contained wrong number of {}: {} != {}", [INFO] [stderr] 123 | | name, [INFO] [stderr] 124 | | have, [INFO] [stderr] 125 | | want [INFO] [stderr] 126 | | )))); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 121 | return Err(ArError::InvalidConfig(format!( [INFO] [stderr] 122 | "ALLOWED contained wrong number of {}: {} != {}", [INFO] [stderr] 123 | name, [INFO] [stderr] 124 | have, [INFO] [stderr] 125 | want [INFO] [stderr] 126 | ))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/types.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / impl Hash for KeyVec { [INFO] [stderr] 26 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 27 | | let KeyVec(ref elems) = *self; [INFO] [stderr] 28 | | for elem in elems.iter() { [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/types.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Eq, PartialEq, Debug, Clone)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn combine_with(&self, j: &Sign) -> Sign { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:178:35 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn combine_with(&self, j: &Sign) -> Sign { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Sign` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:248:19 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn as_vec(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/types.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | let sign = match ix.starts_with("-") { [INFO] [stderr] | ____________________^ [INFO] [stderr] 267 | | true => Sign::Neg, [INFO] [stderr] 268 | | false => Sign::Pos, [INFO] [stderr] 269 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ix.starts_with("-") { Sign::Neg } else { Sign::Pos }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types.rs:266:41 [INFO] [stderr] | [INFO] [stderr] 266 | let sign = match ix.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:285:30 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn from_index(index: &Component, sign: &Sign) -> Alpha { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Component` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:285:48 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn from_index(index: &Component, sign: &Sign) -> Alpha { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Sign` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | index: index.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types.rs:288:19 [INFO] [stderr] | [INFO] [stderr] 288 | sign: sign.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*sign` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | pub fn is_point(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:308:19 [INFO] [stderr] | [INFO] [stderr] 308 | pub fn as_vec(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn find_prod(i: &Alpha, j: &Alpha) -> Alpha { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops.rs:74:32 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn find_prod(i: &Alpha, j: &Alpha) -> Alpha { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/ops.rs:98:58 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 98 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops.rs:98:30 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ops.rs:98:41 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ops.rs:161:8 [INFO] [stderr] | [INFO] [stderr] 161 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ops.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | let index = targets.get(&KeyVec::new(components.clone())) [INFO] [stderr] | _________________^ [INFO] [stderr] 171 | | .expect(&format!("{:?} not in TARGETS.", components)) [INFO] [stderr] 172 | | .clone(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 170 | let index = *targets.get(&KeyVec::new(components.clone())) [INFO] [stderr] 171 | .expect(&format!("{:?} not in TARGETS.", components)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ops.rs:171:25 [INFO] [stderr] | [INFO] [stderr] 171 | .expect(&format!("{:?} not in TARGETS.", components)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{:?} not in TARGETS.", components))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arthroprod`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9b9e97656d9d6bdac3b7a507bf7d5ad7f6613ffb5755195af1f8e6f3ad71ab88"` [INFO] running `"docker" "rm" "-f" "9b9e97656d9d6bdac3b7a507bf7d5ad7f6613ffb5755195af1f8e6f3ad71ab88"` [INFO] [stdout] 9b9e97656d9d6bdac3b7a507bf7d5ad7f6613ffb5755195af1f8e6f3ad71ab88