[INFO] crate arithmancy 0.0.1 is already in cache [INFO] extracting crate arithmancy 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/arithmancy/0.0.1 [INFO] extracting crate arithmancy 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arithmancy/0.0.1 [INFO] validating manifest of arithmancy-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arithmancy-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arithmancy-0.0.1 [INFO] finished frobbing arithmancy-0.0.1 [INFO] frobbed toml for arithmancy-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/arithmancy/0.0.1/Cargo.toml [INFO] started frobbing arithmancy-0.0.1 [INFO] finished frobbing arithmancy-0.0.1 [INFO] frobbed toml for arithmancy-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arithmancy/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arithmancy-0.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arithmancy/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 195a09d814db1ac9f41108fc9aec66a1d8bd7829244ea3d3a4b8d48cfa4b1957 [INFO] running `"docker" "start" "-a" "195a09d814db1ac9f41108fc9aec66a1d8bd7829244ea3d3a4b8d48cfa4b1957"` [INFO] [stderr] Checking arithmancy v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/arithmancy.rs:2:3 [INFO] [stderr] | [INFO] [stderr] 2 | return n + 2; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `n + 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/arithmancy.rs:2:3 [INFO] [stderr] | [INFO] [stderr] 2 | return n + 2; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `n + 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/add_two.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | fn usage(brief : &String, opts : &getopts::Options) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/add_two.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | fn usage(brief : &String, opts : &getopts::Options) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "195a09d814db1ac9f41108fc9aec66a1d8bd7829244ea3d3a4b8d48cfa4b1957"` [INFO] running `"docker" "rm" "-f" "195a09d814db1ac9f41108fc9aec66a1d8bd7829244ea3d3a4b8d48cfa4b1957"` [INFO] [stdout] 195a09d814db1ac9f41108fc9aec66a1d8bd7829244ea3d3a4b8d48cfa4b1957