[INFO] crate amf 0.1.1 is already in cache [INFO] extracting crate amf 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/amf/0.1.1 [INFO] extracting crate amf 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amf/0.1.1 [INFO] validating manifest of amf-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amf-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amf-0.1.1 [INFO] finished frobbing amf-0.1.1 [INFO] frobbed toml for amf-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/amf/0.1.1/Cargo.toml [INFO] started frobbing amf-0.1.1 [INFO] finished frobbing amf-0.1.1 [INFO] frobbed toml for amf-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amf/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amf-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amf/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4aa8717642f5ea301ff0561141b0f375582bd5e38b57d7386e0347f44bd07c9a [INFO] running `"docker" "start" "-a" "4aa8717642f5ea301ff0561141b0f375582bd5e38b57d7386e0347f44bd07c9a"` [INFO] [stderr] Checking amf v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:49:65 [INFO] [stderr] | [INFO] [stderr] 49 | marker::MOVIECLIP => Err(DecodeError::Unsupported { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:58:67 [INFO] [stderr] | [INFO] [stderr] 58 | marker::UNSUPPORTED => Err(DecodeError::Unsupported { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | marker::RECORDSET => Err(DecodeError::Unsupported { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:63:45 [INFO] [stderr] | [INFO] [stderr] 63 | _ => Err(DecodeError::Unknown { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:91:55 [INFO] [stderr] | [INFO] [stderr] 91 | .ok_or(DecodeError::OutOfRangeReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:93:54 [INFO] [stderr] | [INFO] [stderr] 93 | Err(DecodeError::CircularReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | Ok(Value::EcmaArray { entries: entries }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:49:65 [INFO] [stderr] | [INFO] [stderr] 49 | marker::MOVIECLIP => Err(DecodeError::Unsupported { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:58:67 [INFO] [stderr] | [INFO] [stderr] 58 | marker::UNSUPPORTED => Err(DecodeError::Unsupported { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | marker::RECORDSET => Err(DecodeError::Unsupported { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:63:45 [INFO] [stderr] | [INFO] [stderr] 63 | _ => Err(DecodeError::Unknown { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:91:55 [INFO] [stderr] | [INFO] [stderr] 91 | .ok_or(DecodeError::OutOfRangeReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:93:54 [INFO] [stderr] | [INFO] [stderr] 93 | Err(DecodeError::CircularReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | Ok(Value::EcmaArray { entries: entries }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(Value::Array { entries: entries }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:118:44 [INFO] [stderr] | [INFO] [stderr] 118 | Err(DecodeError::InvalidDate { millis: millis }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/encode.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Encoder { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/mod.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | Value::Array { entries: entries } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | _ => Err(DecodeError::Unknown { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(Value::Array { entries: entries }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:118:44 [INFO] [stderr] | [INFO] [stderr] 118 | Err(DecodeError::InvalidDate { millis: millis }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/decode.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/encode.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | Encoder { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf0/mod.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | Value::Array { entries: entries } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:82:45 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:106:48 [INFO] [stderr] | [INFO] [stderr] 106 | Err(DecodeError::InvalidDate { millis: millis }) [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `millis` [INFO] [stderr] 82 | _ => Err(DecodeError::Unknown { marker: marker }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `marker` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:106:48 [INFO] [stderr] | [INFO] [stderr] 106 | Err(DecodeError::InvalidDate { millis: millis }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `millis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | entries: entries, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | entries: entries, [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:176:17 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] 176 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | is_weak: is_weak, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_weak` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:262:63 [INFO] [stderr] | [INFO] [stderr] 262 | .ok_or(DecodeError::OutOfRangeReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:264:62 [INFO] [stderr] | [INFO] [stderr] 264 | Err(DecodeError::CircularReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:287:17 [INFO] [stderr] | [INFO] [stderr] 287 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:312:17 [INFO] [stderr] | [INFO] [stderr] 312 | is_dynamic: is_dynamic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_dynamic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:313:17 [INFO] [stderr] | [INFO] [stderr] 313 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:599:13 [INFO] [stderr] | [INFO] [stderr] 599 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/encode.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | Encoder { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | is_fixed: is_fixed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_fixed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:192:17 [INFO] [stderr] | [INFO] [stderr] 192 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:208:17 [INFO] [stderr] | [INFO] [stderr] 208 | is_weak: is_weak, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_weak` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/encode.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:262:63 [INFO] [stderr] | [INFO] [stderr] 262 | .ok_or(DecodeError::OutOfRangeReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:264:62 [INFO] [stderr] | [INFO] [stderr] 264 | Err(DecodeError::CircularReference { index: index }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:287:17 [INFO] [stderr] | [INFO] [stderr] 287 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:312:17 [INFO] [stderr] | [INFO] [stderr] 312 | is_dynamic: is_dynamic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_dynamic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:313:17 [INFO] [stderr] | [INFO] [stderr] 313 | fields: fields, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/decode.rs:599:13 [INFO] [stderr] | [INFO] [stderr] 599 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/encode.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | Encoder { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/amf3/encode.rs:420:13 [INFO] [stderr] | [INFO] [stderr] 420 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf0/encode.rs:107:87 [INFO] [stderr] | [INFO] [stderr] 107 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf3/encode.rs:104:87 [INFO] [stderr] | [INFO] [stderr] 104 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/amf3/encode.rs:233:31 [INFO] [stderr] | [INFO] [stderr] 233 | let b2 = ((u29 >> 07) | 0b1000_0000) as u8; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 233 | let b2 = ((u29 >> 7) | 0b1000_0000) as u8; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 233 | let b2 = ((u29 >> 0o7) | 0b1000_0000) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/amf3/encode.rs:240:31 [INFO] [stderr] | [INFO] [stderr] 240 | let b2 = ((u29 >> 08) | 0b1000_0000) as u8; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 240 | let b2 = ((u29 >> 8) | 0b1000_0000) as u8; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 240 | let b2 = ((u29 >> 0o8) | 0b1000_0000) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf0/decode.rs:335:73 [INFO] [stderr] | [INFO] [stderr] 335 | Value::Date { unix_time: time::Duration::from_millis(1590796800_000) }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_590_796_800_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf0/decode.rs:337:73 [INFO] [stderr] | [INFO] [stderr] 337 | Value::Date { unix_time: time::Duration::from_millis(1045112400_000) }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_045_112_400_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf0/encode.rs:107:87 [INFO] [stderr] | [INFO] [stderr] 107 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf0/encode.rs:220:73 [INFO] [stderr] | [INFO] [stderr] 220 | encode_eq!(Value::Date { unix_time: time::Duration::from_millis(1590796800_000) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_590_796_800_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf0/encode.rs:222:73 [INFO] [stderr] | [INFO] [stderr] 222 | encode_eq!(Value::Date { unix_time: time::Duration::from_millis(1045112400_000) }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_045_112_400_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/amf3/decode.rs:384:61 [INFO] [stderr] | [INFO] [stderr] 384 | decode_eq!("amf3-integer-2byte.bin", Value::Integer(0b10000000)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/amf3/decode.rs:385:61 [INFO] [stderr] | [INFO] [stderr] 385 | decode_eq!("amf3-integer-3byte.bin", Value::Integer(0b100000000000000)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0b100_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/amf3/encode.rs:104:87 [INFO] [stderr] | [INFO] [stderr] 104 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/amf3/encode.rs:233:31 [INFO] [stderr] | [INFO] [stderr] 233 | let b2 = ((u29 >> 07) | 0b1000_0000) as u8; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 233 | let b2 = ((u29 >> 7) | 0b1000_0000) as u8; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 233 | let b2 = ((u29 >> 0o7) | 0b1000_0000) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/amf3/encode.rs:240:31 [INFO] [stderr] | [INFO] [stderr] 240 | let b2 = ((u29 >> 08) | 0b1000_0000) as u8; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 240 | let b2 = ((u29 >> 8) | 0b1000_0000) as u8; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 240 | let b2 = ((u29 >> 0o8) | 0b1000_0000) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/amf0/encode.rs:107:51 [INFO] [stderr] | [INFO] [stderr] 107 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unix_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/amf3/decode.rs:235:21 [INFO] [stderr] | [INFO] [stderr] 235 | let b = try!(self.inner.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 235 | let b = u32::from(match $ expr { [INFO] [stderr] 236 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 237 | :: Err ( err ) => { [INFO] [stderr] 238 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 239 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/amf3/decode.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | let b = try!(self.inner.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 241 | let b = u32::from(match $ expr { [INFO] [stderr] 242 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 243 | :: Err ( err ) => { [INFO] [stderr] 244 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 245 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/encode.rs:104:51 [INFO] [stderr] | [INFO] [stderr] 104 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unix_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u29` [INFO] [stderr] --> src/amf3/encode.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | let b1 = ((u29 >> 0) & 0b0111_1111) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u29` [INFO] [stderr] --> src/amf3/encode.rs:232:23 [INFO] [stderr] | [INFO] [stderr] 232 | let b1 = ((u29 >> 00) & 0b0111_1111) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u29` [INFO] [stderr] --> src/amf3/encode.rs:239:23 [INFO] [stderr] | [INFO] [stderr] 239 | let b1 = ((u29 >> 00) & 0b1111_1111) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/mod.rs:224:39 [INFO] [stderr] | [INFO] [stderr] 224 | Value::Integer(x) => Some(x as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/mod.rs:238:71 [INFO] [stderr] | [INFO] [stderr] 238 | Ok(Box::new(entries.into_iter().map(|n| Value::Double(n as f64)))) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/amf0/decode.rs:281:68 [INFO] [stderr] | [INFO] [stderr] 281 | &[("", s("")), ("foo", s("baz")), ("bar", n(3.14))][..])); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/amf0/decode.rs:322:63 [INFO] [stderr] | [INFO] [stderr] 322 | let object = obj(None, &[("foo", s("baz")), ("bar", n(3.14))][..]); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/amf0/encode.rs:107:51 [INFO] [stderr] | [INFO] [stderr] 107 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unix_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/amf0/encode.rs:194:68 [INFO] [stderr] | [INFO] [stderr] 194 | &[("", s("")), ("foo", s("baz")), ("bar", n(3.14))][..]), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/amf3/decode.rs:235:21 [INFO] [stderr] | [INFO] [stderr] 235 | let b = try!(self.inner.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 235 | let b = u32::from(match $ expr { [INFO] [stderr] 236 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 237 | :: Err ( err ) => { [INFO] [stderr] 238 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 239 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/amf3/decode.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | let b = try!(self.inner.read_u8()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 241 | let b = u32::from(match $ expr { [INFO] [stderr] 242 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 243 | :: Err ( err ) => { [INFO] [stderr] 244 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 245 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/decode.rs:391:56 [INFO] [stderr] | [INFO] [stderr] 391 | decode_eq!("amf3-large-min.bin", Value::Double(-0x1000_0001 as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-0x1000_0001)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/decode.rs:392:56 [INFO] [stderr] | [INFO] [stderr] 392 | decode_eq!("amf3-large-max.bin", Value::Double(0x1000_0000 as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(0x1000_0000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/amf3/decode.rs:506:34 [INFO] [stderr] | [INFO] [stderr] 506 | let b = Value::ByteArray("ASDF".as_bytes().iter().cloned().collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/amf3/decode.rs:506:34 [INFO] [stderr] | [INFO] [stderr] 506 | let b = Value::ByteArray("ASDF".as_bytes().iter().cloned().collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ASDF"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/amf3/decode.rs:557:5 [INFO] [stderr] | [INFO] [stderr] 557 | / fn other_errors() { [INFO] [stderr] 558 | | assert_eq!(decode!("amf3-graph-member.bin"), [INFO] [stderr] 559 | | Err(DecodeError::CircularReference { index: 0 })); [INFO] [stderr] 560 | | assert_eq!(decode!("amf3-bad-object-ref.bin"), [INFO] [stderr] ... | [INFO] [stderr] 581 | | decode_unexpected_eof!("amf3-u29-partial.bin"); [INFO] [stderr] 582 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/amf3/decode.rs:593:28 [INFO] [stderr] | [INFO] [stderr] 593 | dense_entries: entries.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/encode.rs:104:51 [INFO] [stderr] | [INFO] [stderr] 104 | let millis = unix_time.as_secs() * 1000 + (unix_time.subsec_nanos() as u64) / 1000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unix_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u29` [INFO] [stderr] --> src/amf3/encode.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | let b1 = ((u29 >> 0) & 0b0111_1111) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u29` [INFO] [stderr] --> src/amf3/encode.rs:232:23 [INFO] [stderr] | [INFO] [stderr] 232 | let b1 = ((u29 >> 00) & 0b0111_1111) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u29` [INFO] [stderr] --> src/amf3/encode.rs:239:23 [INFO] [stderr] | [INFO] [stderr] 239 | let b1 = ((u29 >> 00) & 0b1111_1111) as u8; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/encode.rs:320:34 [INFO] [stderr] | [INFO] [stderr] 320 | encode_eq!(Value::Double(-0x1000_0001 as f64), "amf3-large-min.bin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-0x1000_0001)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/encode.rs:321:34 [INFO] [stderr] | [INFO] [stderr] 321 | encode_eq!(Value::Double(0x1000_0000 as f64), "amf3-large-max.bin"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(0x1000_0000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/amf3/encode.rs:426:28 [INFO] [stderr] | [INFO] [stderr] 426 | dense_entries: entries.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/mod.rs:224:39 [INFO] [stderr] | [INFO] [stderr] 224 | Value::Integer(x) => Some(x as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/amf3/mod.rs:238:71 [INFO] [stderr] | [INFO] [stderr] 238 | Ok(Box::new(entries.into_iter().map(|n| Value::Double(n as f64)))) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `amf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4aa8717642f5ea301ff0561141b0f375582bd5e38b57d7386e0347f44bd07c9a"` [INFO] running `"docker" "rm" "-f" "4aa8717642f5ea301ff0561141b0f375582bd5e38b57d7386e0347f44bd07c9a"` [INFO] [stdout] 4aa8717642f5ea301ff0561141b0f375582bd5e38b57d7386e0347f44bd07c9a