[INFO] crate alcs 0.1.3 is already in cache [INFO] extracting crate alcs 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/alcs/0.1.3 [INFO] extracting crate alcs 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alcs/0.1.3 [INFO] validating manifest of alcs-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alcs-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alcs-0.1.3 [INFO] finished frobbing alcs-0.1.3 [INFO] frobbed toml for alcs-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/alcs/0.1.3/Cargo.toml [INFO] started frobbing alcs-0.1.3 [INFO] finished frobbing alcs-0.1.3 [INFO] frobbed toml for alcs-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alcs/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alcs-0.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alcs/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b58f0827e9db96084b543f15373861d6cecc25af4a85a7c159cb5272a3934c83 [INFO] running `"docker" "start" "-a" "b58f0827e9db96084b543f15373861d6cecc25af4a85a7c159cb5272a3934c83"` [INFO] [stderr] Checking alcs v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | for j in 0..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=nb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is only used to index `iv`. [INFO] [stderr] --> src/lib.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for l in 0..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 119 | for in iv.iter_mut().take((na + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for l in 0..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | for l in 1..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | for j in 1..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:160:14 [INFO] [stderr] | [INFO] [stderr] 160 | for j in 0..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | for l in 1..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for j in 1..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | ig: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:209:14 [INFO] [stderr] | [INFO] [stderr] 209 | for j in 1..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is only used to index `dg`. [INFO] [stderr] --> src/lib.rs:218:14 [INFO] [stderr] | [INFO] [stderr] 218 | for l in i..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 218 | for in dg.iter_mut().take((na + 1)).skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:218:14 [INFO] [stderr] | [INFO] [stderr] 218 | for l in i..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `i..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | ih: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:287:6 [INFO] [stderr] | [INFO] [stderr] 287 | ) -> ( [INFO] [stderr] | ______^ [INFO] [stderr] 288 | | Vec>, [INFO] [stderr] 289 | | Vec>, [INFO] [stderr] 290 | | Vec, [INFO] [stderr] 291 | | Vec>, [INFO] [stderr] 292 | | Vec>, [INFO] [stderr] 293 | | ) [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | / fn fuzzy_find_str<'a>(&'a self, s: T, tsh: f32) -> Option<(f32, &'a str)> { [INFO] [stderr] 431 | | let r = self.fuzzy_find_pos(s, tsh); [INFO] [stderr] 432 | | r.map(|(tsh, start, end)| (tsh, &self.as_ref()[start..end])) [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:115:14 [INFO] [stderr] | [INFO] [stderr] 115 | for j in 0..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=nb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is only used to index `iv`. [INFO] [stderr] --> src/lib.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for l in 0..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 119 | for in iv.iter_mut().take((na + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | for l in 0..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | for l in 1..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | for j in 1..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:160:14 [INFO] [stderr] | [INFO] [stderr] 160 | for j in 0..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `0..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | for l in 1..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for j in 1..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | ig: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:209:14 [INFO] [stderr] | [INFO] [stderr] 209 | for j in 1..(nb + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is only used to index `dg`. [INFO] [stderr] --> src/lib.rs:218:14 [INFO] [stderr] | [INFO] [stderr] 218 | for l in i..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 218 | for in dg.iter_mut().take((na + 1)).skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:218:14 [INFO] [stderr] | [INFO] [stderr] 218 | for l in i..(na + 1) { [INFO] [stderr] | ^^^^^^^^^^^ help: use: `i..=na` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | ih: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:287:6 [INFO] [stderr] | [INFO] [stderr] 287 | ) -> ( [INFO] [stderr] | ______^ [INFO] [stderr] 288 | | Vec>, [INFO] [stderr] 289 | | Vec>, [INFO] [stderr] 290 | | Vec, [INFO] [stderr] 291 | | Vec>, [INFO] [stderr] 292 | | Vec>, [INFO] [stderr] 293 | | ) [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:430:5 [INFO] [stderr] | [INFO] [stderr] 430 | / fn fuzzy_find_str<'a>(&'a self, s: T, tsh: f32) -> Option<(f32, &'a str)> { [INFO] [stderr] 431 | | let r = self.fuzzy_find_pos(s, tsh); [INFO] [stderr] 432 | | r.map(|(tsh, start, end)| (tsh, &self.as_ref()[start..end])) [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "b58f0827e9db96084b543f15373861d6cecc25af4a85a7c159cb5272a3934c83"` [INFO] running `"docker" "rm" "-f" "b58f0827e9db96084b543f15373861d6cecc25af4a85a7c159cb5272a3934c83"` [INFO] [stdout] b58f0827e9db96084b543f15373861d6cecc25af4a85a7c159cb5272a3934c83