[INFO] crate adts-reader 0.1.0 is already in cache [INFO] extracting crate adts-reader 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/adts-reader/0.1.0 [INFO] extracting crate adts-reader 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adts-reader/0.1.0 [INFO] validating manifest of adts-reader-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of adts-reader-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing adts-reader-0.1.0 [INFO] finished frobbing adts-reader-0.1.0 [INFO] frobbed toml for adts-reader-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/adts-reader/0.1.0/Cargo.toml [INFO] started frobbing adts-reader-0.1.0 [INFO] finished frobbing adts-reader-0.1.0 [INFO] frobbed toml for adts-reader-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adts-reader/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting adts-reader-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/adts-reader/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 506ecbd450a22666362e5acf64b4a908f5a030e2b0c48621f9f7ba037ae4564e [INFO] running `"docker" "start" "-a" "506ecbd450a22666362e5acf64b4a908f5a030e2b0c48621f9f7ba037ae4564e"` [INFO] [stderr] Checking bitstream-io v0.6.5 [INFO] [stderr] Checking adts-reader v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking arrayvec v0.3.25 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:305:33 [INFO] [stderr] | [INFO] [stderr] 305 | u16::from(self.buf[5] & 0b00000011) << 6 | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match self { [INFO] [stderr] 111 | | &SamplingFrequency::Freq96000 => Some(96000), [INFO] [stderr] 112 | | &SamplingFrequency::Freq88200 => Some(88200), [INFO] [stderr] 113 | | &SamplingFrequency::Freq64000 => Some(64000), [INFO] [stderr] ... | [INFO] [stderr] 126 | | &SamplingFrequency::FreqReserved0xf => None, [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | match *self { [INFO] [stderr] 111 | SamplingFrequency::Freq96000 => Some(96000), [INFO] [stderr] 112 | SamplingFrequency::Freq88200 => Some(88200), [INFO] [stderr] 113 | SamplingFrequency::Freq64000 => Some(64000), [INFO] [stderr] 114 | SamplingFrequency::Freq48000 => Some(48000), [INFO] [stderr] 115 | SamplingFrequency::Freq44100 => Some(44100), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Checking hexdump v0.1.0 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:305:33 [INFO] [stderr] | [INFO] [stderr] 305 | u16::from(self.buf[5] & 0b00000011) << 6 | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:370:24 [INFO] [stderr] | [INFO] [stderr] 370 | w.write(8, 0b10000001) // 1 byte of payload data [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:387:43 [INFO] [stderr] | [INFO] [stderr] 387 | assert_eq!(header.payload(), Ok(&[0b10000001][..])); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> examples/dump.rs:51:11 [INFO] [stderr] | [INFO] [stderr] 51 | while reading { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/dump.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | let f = File::open(&name).expect(&format!("file not found: {}", &name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("file not found: {}", &name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/dump.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | run(f).expect(&format!("error reading {}", &name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error reading {}", &name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `adts-reader`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match self { [INFO] [stderr] 111 | | &SamplingFrequency::Freq96000 => Some(96000), [INFO] [stderr] 112 | | &SamplingFrequency::Freq88200 => Some(88200), [INFO] [stderr] 113 | | &SamplingFrequency::Freq64000 => Some(64000), [INFO] [stderr] ... | [INFO] [stderr] 126 | | &SamplingFrequency::FreqReserved0xf => None, [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | match *self { [INFO] [stderr] 111 | SamplingFrequency::Freq96000 => Some(96000), [INFO] [stderr] 112 | SamplingFrequency::Freq88200 => Some(88200), [INFO] [stderr] 113 | SamplingFrequency::Freq64000 => Some(64000), [INFO] [stderr] 114 | SamplingFrequency::Freq48000 => Some(48000), [INFO] [stderr] 115 | SamplingFrequency::Freq44100 => Some(44100), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "506ecbd450a22666362e5acf64b4a908f5a030e2b0c48621f9f7ba037ae4564e"` [INFO] running `"docker" "rm" "-f" "506ecbd450a22666362e5acf64b4a908f5a030e2b0c48621f9f7ba037ae4564e"` [INFO] [stdout] 506ecbd450a22666362e5acf64b4a908f5a030e2b0c48621f9f7ba037ae4564e