[INFO] crate abortable_parser 0.2.2 is already in cache [INFO] extracting crate abortable_parser 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/abortable_parser/0.2.2 [INFO] extracting crate abortable_parser 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abortable_parser/0.2.2 [INFO] validating manifest of abortable_parser-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abortable_parser-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abortable_parser-0.2.2 [INFO] finished frobbing abortable_parser-0.2.2 [INFO] frobbed toml for abortable_parser-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/abortable_parser/0.2.2/Cargo.toml [INFO] started frobbing abortable_parser-0.2.2 [INFO] finished frobbing abortable_parser-0.2.2 [INFO] frobbed toml for abortable_parser-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abortable_parser/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abortable_parser-0.2.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abortable_parser/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a28116e76c357ddc3e609fb8f9d888773c7598cd871d82e5e5ed94a5955f8e14 [INFO] running `"docker" "start" "-a" "a28116e76c357ddc3e609fb8f9d888773c7598cd871d82e5e5ed94a5955f8e14"` [INFO] [stderr] Checking abortable_parser v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return *self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn caused_by<'a, D: Into>(msg: D, cause: Box, ctx: Box) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / pub fn get_msg<'a>(&'a self) -> &str { [INFO] [stderr] 181 | | &self.msg [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match self.cause { [INFO] [stderr] 187 | | Some(ref e) => Some(e), [INFO] [stderr] 188 | | None => None, [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ help: try this: `self.cause.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | / if let &Result::Complete(_, _) = self { [INFO] [stderr] 234 | | return true; [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 233 | if let Result::Complete(_, _) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | / if let &Result::Incomplete(_) = self { [INFO] [stderr] 242 | | return true; [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 241 | if let Result::Incomplete(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / if let &Result::Fail(_) = self { [INFO] [stderr] 250 | | return true; [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 249 | if let Result::Fail(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | / if let &Result::Abort(_) = self { [INFO] [stderr] 258 | | return true; [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 257 | if let Result::Abort(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | return *self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn caused_by<'a, D: Into>(msg: D, cause: Box, ctx: Box) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | / pub fn get_msg<'a>(&'a self) -> &str { [INFO] [stderr] 181 | | &self.msg [INFO] [stderr] 182 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match self.cause { [INFO] [stderr] 187 | | Some(ref e) => Some(e), [INFO] [stderr] 188 | | None => None, [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________^ help: try this: `self.cause.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | / if let &Result::Complete(_, _) = self { [INFO] [stderr] 234 | | return true; [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 233 | if let Result::Complete(_, _) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | / if let &Result::Incomplete(_) = self { [INFO] [stderr] 242 | | return true; [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 241 | if let Result::Incomplete(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / if let &Result::Fail(_) = self { [INFO] [stderr] 250 | | return true; [INFO] [stderr] 251 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 249 | if let Result::Fail(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | / if let &Result::Abort(_) = self { [INFO] [stderr] 258 | | return true; [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 257 | if let Result::Abort(_) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/combinators.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | if let None = _i.next() { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 790 | | return Result::Incomplete(_i.clone()); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_________________- help: try this: `if _i.next().is_none()` [INFO] [stderr] | [INFO] [stderr] ::: src/integration_tests.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / make_fn!(proto, [INFO] [stderr] 18 | | do_each!( [INFO] [stderr] 19 | | proto => until!(text_token!("://")), [INFO] [stderr] 20 | | _ => must!(text_token!("://")), [INFO] [stderr] 21 | | (proto) [INFO] [stderr] 22 | | ) [INFO] [stderr] 23 | | ); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/combinators.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | if let None = _i.next() { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 790 | | return Result::Incomplete(_i.clone()); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_________________- help: try this: `if _i.next().is_none()` [INFO] [stderr] | [INFO] [stderr] ::: src/integration_tests.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / make_fn!(domain, [INFO] [stderr] 26 | | until!(either!( [INFO] [stderr] 27 | | discard!(text_token!("/")), [INFO] [stderr] 28 | | discard!(ascii_ws), [INFO] [stderr] 29 | | eoi)) [INFO] [stderr] 30 | | ); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/combinators.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | if let None = _i.next() { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 790 | | return Result::Incomplete(_i.clone()); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_________________- help: try this: `if _i.next().is_none()` [INFO] [stderr] | [INFO] [stderr] ::: src/integration_tests.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / make_fn!(path, [INFO] [stderr] 33 | | until!(either!(discard!(ascii_ws), eoi)) [INFO] [stderr] 34 | | ); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!('f' as u8, out[0]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'f' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!('o' as u8, out[1]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!('o' as u8, out[2]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | assert_eq!('f' as u8, out[0]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'f' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | assert_eq!('o' as u8, out[1]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | assert_eq!('o' as u8, out[2]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:251:20 [INFO] [stderr] | [INFO] [stderr] 251 | assert_eq!('f' as u8, o.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'f' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:252:20 [INFO] [stderr] | [INFO] [stderr] 252 | assert_eq!('o' as u8, o.1); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:324:20 [INFO] [stderr] | [INFO] [stderr] 324 | assert_eq!('f' as u8, o.unwrap()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'f' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:359:20 [INFO] [stderr] | [INFO] [stderr] 359 | assert_eq!('f' as u8, o[0]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'f' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:360:20 [INFO] [stderr] | [INFO] [stderr] 360 | assert_eq!('o' as u8, o[1]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:361:20 [INFO] [stderr] | [INFO] [stderr] 361 | assert_eq!('o' as u8, o[2]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/combinators.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | if let None = _i.next() { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 790 | | return Result::Incomplete(_i.clone()); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_________________- help: try this: `if _i.next().is_none()` [INFO] [stderr] | [INFO] [stderr] ::: src/test.rs:392:18 [INFO] [stderr] | [INFO] [stderr] 392 | let result = until!(iter, text_token!("; ")); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/combinators.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | if let None = _i.next() { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 790 | | return Result::Incomplete(_i.clone()); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_________________- help: try this: `if _i.next().is_none()` [INFO] [stderr] | [INFO] [stderr] ::: src/test.rs:405:18 [INFO] [stderr] | [INFO] [stderr] 405 | let result = until!(iter, must!(will_fail)); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/combinators.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | if let None = _i.next() { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 790 | | return Result::Incomplete(_i.clone()); [INFO] [stderr] 791 | | } [INFO] [stderr] | |_________________- help: try this: `if _i.next().is_none()` [INFO] [stderr] | [INFO] [stderr] ::: src/test.rs:413:18 [INFO] [stderr] | [INFO] [stderr] 413 | let result = until!(iter, text_token!("; ")); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/test.rs:560:1 [INFO] [stderr] | [INFO] [stderr] 560 | / fn test_separated_trailing_comma() { [INFO] [stderr] 561 | | let input_str = "foo,foo,foo,"; [INFO] [stderr] 562 | | let iter = StrIter::new(input_str); [INFO] [stderr] 563 | | let result = separated!(iter, text_token!(","), text_token!("foo")); [INFO] [stderr] ... | [INFO] [stderr] 571 | | } [INFO] [stderr] 572 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/combinators.rs:951:24 [INFO] [stderr] | [INFO] [stderr] 951 | if let None = _i.next() { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 952 | | return Result::Incomplete(_i.clone()); [INFO] [stderr] 953 | | } [INFO] [stderr] | |_________________- help: try this: `if _i.next().is_none()` [INFO] [stderr] | [INFO] [stderr] ::: src/test.rs:644:18 [INFO] [stderr] | [INFO] [stderr] 644 | let result = consume_all!(iter, ascii_alpha); [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.08s [INFO] running `"docker" "inspect" "a28116e76c357ddc3e609fb8f9d888773c7598cd871d82e5e5ed94a5955f8e14"` [INFO] running `"docker" "rm" "-f" "a28116e76c357ddc3e609fb8f9d888773c7598cd871d82e5e5ed94a5955f8e14"` [INFO] [stdout] a28116e76c357ddc3e609fb8f9d888773c7598cd871d82e5e5ed94a5955f8e14