[INFO] crate abomonation 0.7.0 is already in cache [INFO] extracting crate abomonation 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/abomonation/0.7.0 [INFO] extracting crate abomonation 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abomonation/0.7.0 [INFO] validating manifest of abomonation-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of abomonation-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing abomonation-0.7.0 [INFO] finished frobbing abomonation-0.7.0 [INFO] frobbed toml for abomonation-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/abomonation/0.7.0/Cargo.toml [INFO] started frobbing abomonation-0.7.0 [INFO] finished frobbing abomonation-0.7.0 [INFO] frobbed toml for abomonation-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abomonation/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting abomonation-0.7.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/abomonation/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f14bd6a5ba8792d1d51563236fd608ceadbf5e3a9d9ab9257bfd6d415dfa747c [INFO] running `"docker" "start" "-a" "f14bd6a5ba8792d1d51563236fd608ceadbf5e3a9d9ab9257bfd6d415dfa747c"` [INFO] [stderr] Checking recycler v0.1.4 [INFO] [stderr] Checking abomonation v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/abomonated.rs:124:35 [INFO] [stderr] | [INFO] [stderr] 124 | let result: &T = unsafe { transmute(self.decoded.get_unchecked(0)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self.decoded.get_unchecked(0) as *const u8 as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | let slice = std::slice::from_raw_parts(mem::transmute(typed), mem::size_of::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `typed as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | let result: &mut T = mem::transmute(split1.get_unchecked_mut(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(split1.get_unchecked_mut(0) as *mut u8 as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | / if let &Some(ref inner) = self { [INFO] [stderr] 296 | | inner.entomb(write)?; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 295 | if let Some(ref inner) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:301:9 [INFO] [stderr] | [INFO] [stderr] 301 | / if let &mut Some(ref mut inner) = self { [INFO] [stderr] 302 | | let tmp = bytes; bytes = inner.exhume(tmp)?; [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 301 | if let Some(ref mut inner) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | / match self { [INFO] [stderr] 314 | | &Ok(ref inner) => inner.entomb(write)?, [INFO] [stderr] 315 | | &Err(ref inner) => inner.entomb(write)?, [INFO] [stderr] 316 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 313 | match *self { [INFO] [stderr] 314 | Ok(ref inner) => inner.entomb(write)?, [INFO] [stderr] 315 | Err(ref inner) => inner.entomb(write)?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | / match self { [INFO] [stderr] 321 | | &mut Ok(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] 322 | | &mut Err(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *self { [INFO] [stderr] 321 | Ok(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] 322 | Err(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / match self { [INFO] [stderr] 327 | | &Ok(ref inner) => inner.extent(), [INFO] [stderr] 328 | | &Err(ref inner) => inner.extent(), [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 326 | match *self { [INFO] [stderr] 327 | Ok(ref inner) => inner.extent(), [INFO] [stderr] 328 | Err(ref inner) => inner.extent(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:438:58 [INFO] [stderr] | [INFO] [stderr] 438 | std::ptr::write(self, String::from_raw_parts(mem::transmute(mine.as_ptr()), self.len(), self.len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mine.as_ptr() as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:484:52 [INFO] [stderr] | [INFO] [stderr] 484 | bytes.write_all(std::slice::from_raw_parts(mem::transmute(&**self), mem::size_of::()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&**self as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: the since field must contain a semver-compliant version [INFO] [stderr] --> src/lib.rs:218:14 [INFO] [stderr] | [INFO] [stderr] 218 | #[deprecated(since="0.5", note="please use the abomonation_derive crate")] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::deprecated_semver)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_semver [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/abomonated.rs:124:35 [INFO] [stderr] | [INFO] [stderr] 124 | let result: &T = unsafe { transmute(self.decoded.get_unchecked(0)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self.decoded.get_unchecked(0) as *const u8 as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | let slice = std::slice::from_raw_parts(mem::transmute(typed), mem::size_of::()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `typed as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:126:30 [INFO] [stderr] | [INFO] [stderr] 126 | let result: &mut T = mem::transmute(split1.get_unchecked_mut(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(split1.get_unchecked_mut(0) as *mut u8 as *mut T)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | / if let &Some(ref inner) = self { [INFO] [stderr] 296 | | inner.entomb(write)?; [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 295 | if let Some(ref inner) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:301:9 [INFO] [stderr] | [INFO] [stderr] 301 | / if let &mut Some(ref mut inner) = self { [INFO] [stderr] 302 | | let tmp = bytes; bytes = inner.exhume(tmp)?; [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 301 | if let Some(ref mut inner) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | / match self { [INFO] [stderr] 314 | | &Ok(ref inner) => inner.entomb(write)?, [INFO] [stderr] 315 | | &Err(ref inner) => inner.entomb(write)?, [INFO] [stderr] 316 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 313 | match *self { [INFO] [stderr] 314 | Ok(ref inner) => inner.entomb(write)?, [INFO] [stderr] 315 | Err(ref inner) => inner.entomb(write)?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | / match self { [INFO] [stderr] 321 | | &mut Ok(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] 322 | | &mut Err(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *self { [INFO] [stderr] 321 | Ok(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] 322 | Err(ref mut inner) => inner.exhume(bytes), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / match self { [INFO] [stderr] 327 | | &Ok(ref inner) => inner.extent(), [INFO] [stderr] 328 | | &Err(ref inner) => inner.extent(), [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 326 | match *self { [INFO] [stderr] 327 | Ok(ref inner) => inner.extent(), [INFO] [stderr] 328 | Err(ref inner) => inner.extent(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `abomonation`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:438:58 [INFO] [stderr] | [INFO] [stderr] 438 | std::ptr::write(self, String::from_raw_parts(mem::transmute(mine.as_ptr()), self.len(), self.len())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mine.as_ptr() as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:484:52 [INFO] [stderr] | [INFO] [stderr] 484 | bytes.write_all(std::slice::from_raw_parts(mem::transmute(&**self), mem::size_of::()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&**self as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: the since field must contain a semver-compliant version [INFO] [stderr] --> src/lib.rs:218:14 [INFO] [stderr] | [INFO] [stderr] 218 | #[deprecated(since="0.5", note="please use the abomonation_derive crate")] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::deprecated_semver)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_semver [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `abomonation`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f14bd6a5ba8792d1d51563236fd608ceadbf5e3a9d9ab9257bfd6d415dfa747c"` [INFO] running `"docker" "rm" "-f" "f14bd6a5ba8792d1d51563236fd608ceadbf5e3a9d9ab9257bfd6d415dfa747c"` [INFO] [stdout] f14bd6a5ba8792d1d51563236fd608ceadbf5e3a9d9ab9257bfd6d415dfa747c