[INFO] crate WebFoolKit 0.1.1 is already in cache [INFO] extracting crate WebFoolKit 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/WebFoolKit/0.1.1 [INFO] extracting crate WebFoolKit 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/WebFoolKit/0.1.1 [INFO] validating manifest of WebFoolKit-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of WebFoolKit-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing WebFoolKit-0.1.1 [INFO] finished frobbing WebFoolKit-0.1.1 [INFO] frobbed toml for WebFoolKit-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/WebFoolKit/0.1.1/Cargo.toml [INFO] started frobbing WebFoolKit-0.1.1 [INFO] finished frobbing WebFoolKit-0.1.1 [INFO] frobbed toml for WebFoolKit-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/WebFoolKit/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting WebFoolKit-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/WebFoolKit/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2810d84650b57e0cd93182144466b6c7b8d84b9f22482c75b4b0b2a8a4b609b3 [INFO] running `"docker" "start" "-a" "2810d84650b57e0cd93182144466b6c7b8d84b9f22482c75b4b0b2a8a4b609b3"` [INFO] [stderr] Checking WebFoolKit v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:23 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:35 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:49 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:65 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:77 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:339:3 [INFO] [stderr] | [INFO] [stderr] 339 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:340:3 [INFO] [stderr] | [INFO] [stderr] 340 | cookies: cookies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:23 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:35 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:49 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:65 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:209:77 [INFO] [stderr] | [INFO] [stderr] 209 | cookies.push(Cookie{name: name, value: value, expiry: expiry, path: path, domain: domain, is_new: false}); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `domain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:339:3 [INFO] [stderr] | [INFO] [stderr] 339 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cgi/mod.rs:340:3 [INFO] [stderr] | [INFO] [stderr] 340 | cookies: cookies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:48:2 [INFO] [stderr] | [INFO] [stderr] 48 | return Cookie { [INFO] [stderr] | _____^ [INFO] [stderr] 49 | | name: "".to_string(), [INFO] [stderr] 50 | | path: "".to_string(), [INFO] [stderr] 51 | | domain: "".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 54 | | is_new: true, [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | Cookie { [INFO] [stderr] 49 | name: "".to_string(), [INFO] [stderr] 50 | path: "".to_string(), [INFO] [stderr] 51 | domain: "".to_string(), [INFO] [stderr] 52 | value: "".to_string(), [INFO] [stderr] 53 | expiry: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:94:2 [INFO] [stderr] | [INFO] [stderr] 94 | return parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:142:2 [INFO] [stderr] | [INFO] [stderr] 142 | return request; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/cgi/mod.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | for y in (i..end) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:212:2 [INFO] [stderr] | [INFO] [stderr] 212 | return cookies; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `cookies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:231:2 [INFO] [stderr] | [INFO] [stderr] 231 | return cookie; // empty [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `cookie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:338:2 [INFO] [stderr] | [INFO] [stderr] 338 | return Cgi { [INFO] [stderr] | _____^ [INFO] [stderr] 339 | | params: params, [INFO] [stderr] 340 | | cookies: cookies, [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 338 | Cgi { [INFO] [stderr] 339 | params: params, [INFO] [stderr] 340 | cookies: cookies, [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: crate `WebFoolKit` should have a snake case name such as `web_fool_kit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cgi::Cookie` [INFO] [stderr] --> src/cgi/mod.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Cookie [INFO] [stderr] 47 | | { [INFO] [stderr] 48 | | return Cookie { [INFO] [stderr] 49 | | name: "".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:48:2 [INFO] [stderr] | [INFO] [stderr] 48 | return Cookie { [INFO] [stderr] | _____^ [INFO] [stderr] 49 | | name: "".to_string(), [INFO] [stderr] 50 | | path: "".to_string(), [INFO] [stderr] 51 | | domain: "".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 54 | | is_new: true, [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | Cookie { [INFO] [stderr] 49 | name: "".to_string(), [INFO] [stderr] 50 | path: "".to_string(), [INFO] [stderr] 51 | domain: "".to_string(), [INFO] [stderr] 52 | value: "".to_string(), [INFO] [stderr] 53 | expiry: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:94:2 [INFO] [stderr] | [INFO] [stderr] 94 | return parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:142:2 [INFO] [stderr] | [INFO] [stderr] 142 | return request; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/cgi/mod.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | for y in (i..end) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:212:2 [INFO] [stderr] | [INFO] [stderr] 212 | return cookies; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `cookies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:231:2 [INFO] [stderr] | [INFO] [stderr] 231 | return cookie; // empty [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `cookie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cgi/mod.rs:338:2 [INFO] [stderr] | [INFO] [stderr] 338 | return Cgi { [INFO] [stderr] | _____^ [INFO] [stderr] 339 | | params: params, [INFO] [stderr] 340 | | cookies: cookies, [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 338 | Cgi { [INFO] [stderr] 339 | params: params, [INFO] [stderr] 340 | cookies: cookies, [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cgi::Cgi` [INFO] [stderr] --> src/cgi/mod.rs:333:1 [INFO] [stderr] | [INFO] [stderr] 333 | / pub fn new() -> Cgi [INFO] [stderr] 334 | | { [INFO] [stderr] 335 | | let params = Cgi::get_http_request(); [INFO] [stderr] 336 | | let cookies = Cgi::get_http_cookies(); [INFO] [stderr] ... | [INFO] [stderr] 341 | | } [INFO] [stderr] 342 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cgi/mod.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | if srch.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `srch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:121:4 [INFO] [stderr] | [INFO] [stderr] 121 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:131:4 [INFO] [stderr] | [INFO] [stderr] 131 | end = end + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `end += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `buf`. [INFO] [stderr] --> src/cgi/mod.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | for y in (i..end) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 135 | for in buf.iter().take(end).skip(i) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:182:3 [INFO] [stderr] | [INFO] [stderr] 182 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cgi/mod.rs:203:57 [INFO] [stderr] | [INFO] [stderr] 203 | let expires = Cgi::find_header(&mut line, "expires=", ';' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cgi/mod.rs:206:52 [INFO] [stderr] | [INFO] [stderr] 206 | let path = Cgi::find_header(&mut line, "path=", ';' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cgi/mod.rs:207:55 [INFO] [stderr] | [INFO] [stderr] 207 | let domain = Cgi::find_header(&mut line, "domain=", ';' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/cgi/mod.rs:220:39 [INFO] [stderr] | [INFO] [stderr] 220 | if ! c.name.is_empty() && c.name == name.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: crate `WebFoolKit` should have a snake case name such as `web_fool_kit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cgi::Cookie` [INFO] [stderr] --> src/cgi/mod.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Cookie [INFO] [stderr] 47 | | { [INFO] [stderr] 48 | | return Cookie { [INFO] [stderr] 49 | | name: "".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 55 | | } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cgi::Cgi` [INFO] [stderr] --> src/cgi/mod.rs:333:1 [INFO] [stderr] | [INFO] [stderr] 333 | / pub fn new() -> Cgi [INFO] [stderr] 334 | | { [INFO] [stderr] 335 | | let params = Cgi::get_http_request(); [INFO] [stderr] 336 | | let cookies = Cgi::get_http_cookies(); [INFO] [stderr] ... | [INFO] [stderr] 341 | | } [INFO] [stderr] 342 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cgi/mod.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | if srch.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `srch.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | x = x + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `x += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:121:4 [INFO] [stderr] | [INFO] [stderr] 121 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:131:4 [INFO] [stderr] | [INFO] [stderr] 131 | end = end + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `end += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is only used to index `buf`. [INFO] [stderr] --> src/cgi/mod.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | for y in (i..end) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 135 | for in buf.iter().take(end).skip(i) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cgi/mod.rs:182:3 [INFO] [stderr] | [INFO] [stderr] 182 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cgi/mod.rs:203:57 [INFO] [stderr] | [INFO] [stderr] 203 | let expires = Cgi::find_header(&mut line, "expires=", ';' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cgi/mod.rs:206:52 [INFO] [stderr] | [INFO] [stderr] 206 | let path = Cgi::find_header(&mut line, "path=", ';' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cgi/mod.rs:207:55 [INFO] [stderr] | [INFO] [stderr] 207 | let domain = Cgi::find_header(&mut line, "domain=", ';' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b';' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/cgi/mod.rs:220:39 [INFO] [stderr] | [INFO] [stderr] 220 | if ! c.name.is_empty() && c.name == name.to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "2810d84650b57e0cd93182144466b6c7b8d84b9f22482c75b4b0b2a8a4b609b3"` [INFO] running `"docker" "rm" "-f" "2810d84650b57e0cd93182144466b6c7b8d84b9f22482c75b4b0b2a8a4b609b3"` [INFO] [stdout] 2810d84650b57e0cd93182144466b6c7b8d84b9f22482c75b4b0b2a8a4b609b3