[INFO] updating cached repository zzzsochi/versions [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zzzsochi/versions [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zzzsochi/versions" "work/ex/clippy-test-run/sources/stable/gh/zzzsochi/versions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zzzsochi/versions'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zzzsochi/versions" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzzsochi/versions"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzzsochi/versions'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b4c37cd7cf14f009cde13ae6c8c59a8058541c9d [INFO] sha for GitHub repo zzzsochi/versions: b4c37cd7cf14f009cde13ae6c8c59a8058541c9d [INFO] validating manifest of zzzsochi/versions on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zzzsochi/versions on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zzzsochi/versions [INFO] finished frobbing zzzsochi/versions [INFO] frobbed toml for zzzsochi/versions written to work/ex/clippy-test-run/sources/stable/gh/zzzsochi/versions/Cargo.toml [INFO] started frobbing zzzsochi/versions [INFO] finished frobbing zzzsochi/versions [INFO] frobbed toml for zzzsochi/versions written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzzsochi/versions/Cargo.toml [INFO] crate zzzsochi/versions has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zzzsochi/versions against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zzzsochi/versions:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 807fc7d2340b32bbab767a00dee06eb51f857ae9916ffe66a209a18adc4891d0 [INFO] running `"docker" "start" "-a" "807fc7d2340b32bbab767a00dee06eb51f857ae9916ffe66a209a18adc4891d0"` [INFO] [stderr] Checking libc v0.2.41 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking versions v3.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return string.chars().skip(zeroes_count).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.chars().skip(zeroes_count).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return NUMERALS[0].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NUMERALS[0].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return int2base(num / BASE) + &NUMERALS[num % BASE].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `int2base(num / BASE) + &NUMERALS[num % BASE].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return strip_zeroes(_raw); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strip_zeroes(_raw)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(path) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return string.chars().skip(zeroes_count).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string.chars().skip(zeroes_count).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return NUMERALS[0].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NUMERALS[0].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return int2base(num / BASE) + &NUMERALS[num % BASE].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `int2base(num / BASE) + &NUMERALS[num % BASE].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return strip_zeroes(_raw); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strip_zeroes(_raw)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> versions.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(path) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> versions.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | if value.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> versions.rs:81:38 [INFO] [stderr] | [INFO] [stderr] 81 | fn write_file(path: String, version: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> versions.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | if value.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> versions.rs:81:38 [INFO] [stderr] | [INFO] [stderr] 81 | fn write_file(path: String, version: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.91s [INFO] running `"docker" "inspect" "807fc7d2340b32bbab767a00dee06eb51f857ae9916ffe66a209a18adc4891d0"` [INFO] running `"docker" "rm" "-f" "807fc7d2340b32bbab767a00dee06eb51f857ae9916ffe66a209a18adc4891d0"` [INFO] [stdout] 807fc7d2340b32bbab767a00dee06eb51f857ae9916ffe66a209a18adc4891d0