[INFO] updating cached repository zorocow/AdvOC-01
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/zorocow/AdvOC-01
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/zorocow/AdvOC-01" "work/ex/clippy-test-run/sources/stable/gh/zorocow/AdvOC-01"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zorocow/AdvOC-01'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/zorocow/AdvOC-01" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zorocow/AdvOC-01"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zorocow/AdvOC-01'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 65db0e76ec0a0bdbb1a1e4e96b5a5024d8e1b8f9
[INFO] sha for GitHub repo zorocow/AdvOC-01: 65db0e76ec0a0bdbb1a1e4e96b5a5024d8e1b8f9
[INFO] validating manifest of zorocow/AdvOC-01 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zorocow/AdvOC-01 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zorocow/AdvOC-01
[INFO] finished frobbing zorocow/AdvOC-01
[INFO] frobbed toml for zorocow/AdvOC-01 written to work/ex/clippy-test-run/sources/stable/gh/zorocow/AdvOC-01/Cargo.toml
[INFO] started frobbing zorocow/AdvOC-01
[INFO] finished frobbing zorocow/AdvOC-01
[INFO] frobbed toml for zorocow/AdvOC-01 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zorocow/AdvOC-01/Cargo.toml
[INFO] crate zorocow/AdvOC-01 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zorocow/AdvOC-01 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zorocow/AdvOC-01:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b1a945c289abf876c3ecb2134e182e14b58fe468ad5f0ce6b1e0736ed9b1fa83
[INFO] running `"docker" "start" "-a" "b1a945c289abf876c3ecb2134e182e14b58fe468ad5f0ce6b1e0736ed9b1fa83"`
[INFO] [stderr]     Checking advent_of_code v2.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/adv2.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 | const FILENAME: &'static str = "input_d2";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/adv3.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 | const FILENAME: &'static str = "input_d3";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/adv1.rs:5:18
[INFO] [stderr]   |
[INFO] [stderr] 5 | const FILENAME: &'static str = "input_d1";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/adv2.rs:7:18
[INFO] [stderr]   |
[INFO] [stderr] 7 | const FILENAME: &'static str = "input_d2";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/bin/adv2.rs:30:47
[INFO] [stderr]    |
[INFO] [stderr] 30 |       s.iter().fold(u32::max_value(), |acc, &n| match n < acc {
[INFO] [stderr]    |  _______________________________________________^
[INFO] [stderr] 31 | |         true => n,
[INFO] [stderr] 32 | |         false => acc,
[INFO] [stderr] 33 | |     })
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if n < acc { n } else { acc }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/adv1.rs:5:18
[INFO] [stderr]   |
[INFO] [stderr] 5 | const FILENAME: &'static str = "input_d1";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/adv2.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn move_left(&self) -> Pos {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:16:19
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn move_right(&self) -> Pos {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:20:16
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn move_up(&self) -> Pos {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |     fn move_down(&self) -> Pos {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/bin/adv1.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     f.read_to_string(&mut s).ok().expect("can't read string");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in s.chars().enumerate()` or similar iterators
[INFO] [stderr]   --> src/bin/adv1.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     for c in s.chars() {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/bin/adv3.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     f.read_to_string(&mut s).ok().expect("can't read string");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/bin/adv1.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     f.read_to_string(&mut s).ok().expect("can't read string");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in s.chars().enumerate()` or similar iterators
[INFO] [stderr]   --> src/bin/adv1.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |     for c in s.chars() {
[INFO] [stderr]    |              ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/bin/adv2.rs:30:47
[INFO] [stderr]    |
[INFO] [stderr] 30 |       s.iter().fold(u32::max_value(), |acc, &n| match n < acc {
[INFO] [stderr]    |  _______________________________________________^
[INFO] [stderr] 31 | |         true => n,
[INFO] [stderr] 32 | |         false => acc,
[INFO] [stderr] 33 | |     })
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if n < acc { n } else { acc }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/adv3.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 | const FILENAME: &'static str = "input_d3";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/adv2.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn move_left(&self) -> Pos {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:16:19
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn move_right(&self) -> Pos {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:20:16
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn move_up(&self) -> Pos {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/bin/adv3.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |     fn move_down(&self) -> Pos {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/bin/adv3.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     f.read_to_string(&mut s).ok().expect("can't read string");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.37s
[INFO] running `"docker" "inspect" "b1a945c289abf876c3ecb2134e182e14b58fe468ad5f0ce6b1e0736ed9b1fa83"`
[INFO] running `"docker" "rm" "-f" "b1a945c289abf876c3ecb2134e182e14b58fe468ad5f0ce6b1e0736ed9b1fa83"`
[INFO] [stdout] b1a945c289abf876c3ecb2134e182e14b58fe468ad5f0ce6b1e0736ed9b1fa83