[INFO] updating cached repository zetok/nodes-parser-for-qtox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zetok/nodes-parser-for-qtox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zetok/nodes-parser-for-qtox" "work/ex/clippy-test-run/sources/stable/gh/zetok/nodes-parser-for-qtox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zetok/nodes-parser-for-qtox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zetok/nodes-parser-for-qtox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zetok/nodes-parser-for-qtox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zetok/nodes-parser-for-qtox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 65097e24f4230c31d3fb0cf5025cbb3c7064d9c9 [INFO] sha for GitHub repo zetok/nodes-parser-for-qtox: 65097e24f4230c31d3fb0cf5025cbb3c7064d9c9 [INFO] validating manifest of zetok/nodes-parser-for-qtox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zetok/nodes-parser-for-qtox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zetok/nodes-parser-for-qtox [INFO] finished frobbing zetok/nodes-parser-for-qtox [INFO] frobbed toml for zetok/nodes-parser-for-qtox written to work/ex/clippy-test-run/sources/stable/gh/zetok/nodes-parser-for-qtox/Cargo.toml [INFO] started frobbing zetok/nodes-parser-for-qtox [INFO] finished frobbing zetok/nodes-parser-for-qtox [INFO] frobbed toml for zetok/nodes-parser-for-qtox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zetok/nodes-parser-for-qtox/Cargo.toml [INFO] crate zetok/nodes-parser-for-qtox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zetok/nodes-parser-for-qtox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zetok/nodes-parser-for-qtox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 902aa058d937b69b3388ab8ac75b7f0de5d9c356570f04a3ae935f7dd65a8b3a [INFO] running `"docker" "start" "-a" "902aa058d937b69b3388ab8ac75b7f0de5d9c356570f04a3ae935f7dd65a8b3a"` [INFO] [stderr] Checking nodes-parser-for-qtox v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | fn bootstrap(string: &String, num: usize) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `nodes` [INFO] [stderr] --> src/main.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | for n in 0..nodes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 85 | for (n, ) in nodes.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | fn bootstrap(string: &String, num: usize) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `nodes` [INFO] [stderr] --> src/main.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | for n in 0..nodes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 85 | for (n, ) in nodes.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "902aa058d937b69b3388ab8ac75b7f0de5d9c356570f04a3ae935f7dd65a8b3a"` [INFO] running `"docker" "rm" "-f" "902aa058d937b69b3388ab8ac75b7f0de5d9c356570f04a3ae935f7dd65a8b3a"` [INFO] [stdout] 902aa058d937b69b3388ab8ac75b7f0de5d9c356570f04a3ae935f7dd65a8b3a