[INFO] updating cached repository zeqfreed/rusty-renderer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/zeqfreed/rusty-renderer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/zeqfreed/rusty-renderer" "work/ex/clippy-test-run/sources/stable/gh/zeqfreed/rusty-renderer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zeqfreed/rusty-renderer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/zeqfreed/rusty-renderer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zeqfreed/rusty-renderer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zeqfreed/rusty-renderer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5d8c48339cb7376373236a93480786e44c5a7eb6 [INFO] sha for GitHub repo zeqfreed/rusty-renderer: 5d8c48339cb7376373236a93480786e44c5a7eb6 [INFO] validating manifest of zeqfreed/rusty-renderer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of zeqfreed/rusty-renderer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing zeqfreed/rusty-renderer [INFO] finished frobbing zeqfreed/rusty-renderer [INFO] frobbed toml for zeqfreed/rusty-renderer written to work/ex/clippy-test-run/sources/stable/gh/zeqfreed/rusty-renderer/Cargo.toml [INFO] started frobbing zeqfreed/rusty-renderer [INFO] finished frobbing zeqfreed/rusty-renderer [INFO] frobbed toml for zeqfreed/rusty-renderer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zeqfreed/rusty-renderer/Cargo.toml [INFO] crate zeqfreed/rusty-renderer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting zeqfreed/rusty-renderer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zeqfreed/rusty-renderer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 237ba815c024b3edba1bb3299519603c05676ad34f57bb75161d8ce123fdae8b [INFO] running `"docker" "start" "-a" "237ba815c024b3edba1bb3299519603c05676ad34f57bb75161d8ce123fdae8b"` [INFO] [stderr] Checking renderer v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | let mut c = RgbaColor {r: r, g: g, b: b, a: self.a}; [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | let mut c = RgbaColor {r: r, g: g, b: b, a: self.a}; [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let mut c = RgbaColor {r: r, g: g, b: b, a: self.a}; [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:101:57 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | texture_coords: texture_coords [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | Vec3i {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | Vec3i {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | Vec3i {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | Vec2:: {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | Vec2:: {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | Vec3f { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | Vec3f { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | Vec3f { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | zbuffer: zbuffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `zbuffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let mut i = verts[0].i; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let p = pbc + (pa - pbc) * y_coef; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:156:26 [INFO] [stderr] | [INFO] [stderr] 156 | Some(v) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | RgbaColor {r: r, g: g, b: b, a: a} [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | let mut c = RgbaColor {r: r, g: g, b: b, a: self.a}; [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | let mut c = RgbaColor {r: r, g: g, b: b, a: self.a}; [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let mut c = RgbaColor {r: r, g: g, b: b, a: self.a}; [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tga.rs:101:57 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | texture_coords: texture_coords [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_coords` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:27:16 [INFO] [stderr] | [INFO] [stderr] 27 | Vec3i {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | Vec3i {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | Vec3i {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | Vec2:: {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | Vec2:: {x: x, y: y} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | Vec3f { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | Vec3f { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:66:29 [INFO] [stderr] | [INFO] [stderr] 66 | Vec3f { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | zbuffer: zbuffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `zbuffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let mut i = verts[0].i; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let p = pbc + (pa - pbc) * y_coef; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:156:26 [INFO] [stderr] | [INFO] [stderr] 156 | Some(v) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/tga.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tga.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TgaImage { width: width, height: height, pixels: pixels }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tga.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | return image; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/tga.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if (color_map_type != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return Model { [INFO] [stderr] 72 | | vertices: vertices, [INFO] [stderr] 73 | | normals: normals, [INFO] [stderr] 74 | | faces: faces, [INFO] [stderr] 75 | | texture_coords: texture_coords [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Model { [INFO] [stderr] 72 | vertices: vertices, [INFO] [stderr] 73 | normals: normals, [INFO] [stderr] 74 | faces: faces, [INFO] [stderr] 75 | texture_coords: texture_coords [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return *self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / return Renderer { [INFO] [stderr] 42 | | image: image, [INFO] [stderr] 43 | | zbuffer: zbuffer, [INFO] [stderr] 44 | | diffuse: None, [INFO] [stderr] 45 | | color: RgbaColor::new(1.0, 1.0, 1.0, 1.0), [INFO] [stderr] 46 | | shading: Shading::Flat [INFO] [stderr] 47 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | Renderer { [INFO] [stderr] 42 | image: image, [INFO] [stderr] 43 | zbuffer: zbuffer, [INFO] [stderr] 44 | diffuse: None, [INFO] [stderr] 45 | color: RgbaColor::new(1.0, 1.0, 1.0, 1.0), [INFO] [stderr] 46 | shading: Shading::Flat [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/tga.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tga.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return TgaImage { width: width, height: height, pixels: pixels }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TgaImage { width: width, height: height, pixels: pixels }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tga.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | return image; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/tga.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if (color_map_type != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | / return Model { [INFO] [stderr] 72 | | vertices: vertices, [INFO] [stderr] 73 | | normals: normals, [INFO] [stderr] 74 | | faces: faces, [INFO] [stderr] 75 | | texture_coords: texture_coords [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 71 | Model { [INFO] [stderr] 72 | vertices: vertices, [INFO] [stderr] 73 | normals: normals, [INFO] [stderr] 74 | faces: faces, [INFO] [stderr] 75 | texture_coords: texture_coords [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/math.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return *self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / return Renderer { [INFO] [stderr] 42 | | image: image, [INFO] [stderr] 43 | | zbuffer: zbuffer, [INFO] [stderr] 44 | | diffuse: None, [INFO] [stderr] 45 | | color: RgbaColor::new(1.0, 1.0, 1.0, 1.0), [INFO] [stderr] 46 | | shading: Shading::Flat [INFO] [stderr] 47 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | Renderer { [INFO] [stderr] 42 | image: image, [INFO] [stderr] 43 | zbuffer: zbuffer, [INFO] [stderr] 44 | diffuse: None, [INFO] [stderr] 45 | color: RgbaColor::new(1.0, 1.0, 1.0, 1.0), [INFO] [stderr] 46 | shading: Shading::Flat [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data_type` [INFO] [stderr] --> src/tga.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | let data_type = data.next().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_data_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_origin` [INFO] [stderr] --> src/tga.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let x_origin = data.next().unwrap() | (data.next().unwrap() << 2); [INFO] [stderr] | ^^^^^^^^ help: consider using `_x_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_origin` [INFO] [stderr] --> src/tga.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let y_origin = data.next().unwrap() | (data.next().unwrap() << 2); [INFO] [stderr] | ^^^^^^^^ help: consider using `_y_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bpp` [INFO] [stderr] --> src/tga.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | let bpp = data.next().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_bpp` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `img_desc` [INFO] [stderr] --> src/tga.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | let img_desc = data.next().unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_img_desc` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pa` is never read [INFO] [stderr] --> src/main.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | let mut pa = verts[0].p; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pbc` is never read [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | let mut pbc = verts[0].p; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `t` is never read [INFO] [stderr] --> src/main.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | let mut t = verts[0].t; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tbc` is never read [INFO] [stderr] --> src/main.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | let mut tbc = verts[0].t; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/main.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let mut i = verts[0].i; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `ibc` is never read [INFO] [stderr] --> src/main.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let mut ibc = verts[0].i; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | let mut slice = &mut verts[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data_type` [INFO] [stderr] --> src/tga.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | let data_type = data.next().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_data_type` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_origin` [INFO] [stderr] --> src/tga.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | let x_origin = data.next().unwrap() | (data.next().unwrap() << 2); [INFO] [stderr] | ^^^^^^^^ help: consider using `_x_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_origin` [INFO] [stderr] --> src/tga.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | let y_origin = data.next().unwrap() | (data.next().unwrap() << 2); [INFO] [stderr] | ^^^^^^^^ help: consider using `_y_origin` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bpp` [INFO] [stderr] --> src/tga.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | let bpp = data.next().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_bpp` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `img_desc` [INFO] [stderr] --> src/tga.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | let img_desc = data.next().unwrap(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_img_desc` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pa` is never read [INFO] [stderr] --> src/main.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | let mut pa = verts[0].p; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `pbc` is never read [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | let mut pbc = verts[0].p; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `t` is never read [INFO] [stderr] --> src/main.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | let mut t = verts[0].t; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `tbc` is never read [INFO] [stderr] --> src/main.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | let mut tbc = verts[0].t; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `i` is never read [INFO] [stderr] --> src/main.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let mut i = verts[0].i; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `ibc` is never read [INFO] [stderr] --> src/main.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let mut ibc = verts[0].i; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | let mut slice = &mut verts[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let mut reader = BufReader::new(file); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(x: i32, y: i32, z: i32) -> Vec3i { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `line` [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn line(&mut self, x0: i32, y0: i32, x1: i32, y1: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:60 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:78 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let mut reader = BufReader::new(file); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/math.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new(x: i32, y: i32, z: i32) -> Vec3i { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tga.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | file.write_all(&data[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: method is never used: `line` [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn line(&mut self, x0: i32, y0: i32, x1: i32, y1: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:42 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:60 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:27:78 [INFO] [stderr] | [INFO] [stderr] 27 | RgbaColor::new(r as f32 / 255.0, g as f32 / 255.0, b as f32 / 255.0, a as f32 / 255.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tga.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | file.read_to_end(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | let width:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:164:58 [INFO] [stderr] | [INFO] [stderr] 164 | let width:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:165:26 [INFO] [stderr] | [INFO] [stderr] 165 | let height:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:165:59 [INFO] [stderr] | [INFO] [stderr] 165 | let height:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tga.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | file.write_all(&data[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/tga.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | file.read_to_end(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | let width:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:164:58 [INFO] [stderr] | [INFO] [stderr] 164 | let width:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:165:26 [INFO] [stderr] | [INFO] [stderr] 165 | let height:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/tga.rs:165:59 [INFO] [stderr] | [INFO] [stderr] 165 | let height:i32 = (data.next().unwrap() as i32) | ((data.next().unwrap() as i32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(data.next().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused label `'line` [INFO] [stderr] --> src/model.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / 'line: for line in reader.lines().filter_map(|res| res.ok()) { [INFO] [stderr] 50 | | let mut coords = [0f32; 3]; [INFO] [stderr] 51 | | let mut indices = [0i32; 9]; [INFO] [stderr] 52 | | [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'line` [INFO] [stderr] --> src/model.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / 'line: for line in reader.lines().filter_map(|res| res.ok()) { [INFO] [stderr] 50 | | let mut coords = [0f32; 3]; [INFO] [stderr] 51 | | let mut indices = [0i32; 9]; [INFO] [stderr] 52 | | [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | let v = model.vertices.get(face[i+2*i] as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `model.vertices[face[i+2*i] as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | let t = model.texture_coords.get(face[i+2*i+1] as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `model.texture_coords[face[i+2*i+1] as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:189:34 [INFO] [stderr] | [INFO] [stderr] 189 | let n = *model.normals.get(face[i+2*i+2] as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `model.normals[face[i+2*i+2] as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vertices`. [INFO] [stderr] --> src/main.rs:210:26 [INFO] [stderr] | [INFO] [stderr] 210 | for i in 0..3 { vertices[i].i = intensity; } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 210 | for in &mut vertices { vertices[i].i = intensity; } [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | let v = model.vertices.get(face[i+2*i] as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `model.vertices[face[i+2*i] as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | let t = model.texture_coords.get(face[i+2*i+1] as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `model.texture_coords[face[i+2*i+1] as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:189:34 [INFO] [stderr] | [INFO] [stderr] 189 | let n = *model.normals.get(face[i+2*i+2] as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `model.normals[face[i+2*i+2] as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vertices`. [INFO] [stderr] --> src/main.rs:210:26 [INFO] [stderr] | [INFO] [stderr] 210 | for i in 0..3 { vertices[i].i = intensity; } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 210 | for in &mut vertices { vertices[i].i = intensity; } [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "237ba815c024b3edba1bb3299519603c05676ad34f57bb75161d8ce123fdae8b"` [INFO] running `"docker" "rm" "-f" "237ba815c024b3edba1bb3299519603c05676ad34f57bb75161d8ce123fdae8b"` [INFO] [stdout] 237ba815c024b3edba1bb3299519603c05676ad34f57bb75161d8ce123fdae8b