[INFO] updating cached repository zakrent/Rust-hexdump
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/zakrent/Rust-hexdump
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/zakrent/Rust-hexdump" "work/ex/clippy-test-run/sources/stable/gh/zakrent/Rust-hexdump"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zakrent/Rust-hexdump'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/zakrent/Rust-hexdump" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zakrent/Rust-hexdump"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zakrent/Rust-hexdump'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7a76e428283a1874e9d1e364958fb2c895204d61
[INFO] sha for GitHub repo zakrent/Rust-hexdump: 7a76e428283a1874e9d1e364958fb2c895204d61
[INFO] validating manifest of zakrent/Rust-hexdump on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zakrent/Rust-hexdump on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zakrent/Rust-hexdump
[INFO] finished frobbing zakrent/Rust-hexdump
[INFO] frobbed toml for zakrent/Rust-hexdump written to work/ex/clippy-test-run/sources/stable/gh/zakrent/Rust-hexdump/Cargo.toml
[INFO] started frobbing zakrent/Rust-hexdump
[INFO] finished frobbing zakrent/Rust-hexdump
[INFO] frobbed toml for zakrent/Rust-hexdump written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zakrent/Rust-hexdump/Cargo.toml
[INFO] crate zakrent/Rust-hexdump has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zakrent/Rust-hexdump against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zakrent/Rust-hexdump:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dab0a1f4351d87952b33d9f76ca53af981907a3dbe937677cc566f51268a3582
[INFO] running `"docker" "start" "-a" "dab0a1f4351d87952b33d9f76ca53af981907a3dbe937677cc566f51268a3582"`
[INFO] [stderr]     Checking hexdump v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         return Ok(config);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(config)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         return Ok(config);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(config)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:94:28
[INFO] [stderr]    |
[INFO] [stderr] 94 |         address_counter += config.columns as u64;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.columns)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:99:24
[INFO] [stderr]    |
[INFO] [stderr] 99 | fn byte_to_ascii(byte: &u8) -> char{
[INFO] [stderr]    |                        ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/lib.rs:94:28
[INFO] [stderr]    |
[INFO] [stderr] 94 |         address_counter += config.columns as u64;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.columns)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:99:24
[INFO] [stderr]    |
[INFO] [stderr] 99 | fn byte_to_ascii(byte: &u8) -> char{
[INFO] [stderr]    |                        ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "dab0a1f4351d87952b33d9f76ca53af981907a3dbe937677cc566f51268a3582"`
[INFO] running `"docker" "rm" "-f" "dab0a1f4351d87952b33d9f76ca53af981907a3dbe937677cc566f51268a3582"`
[INFO] [stdout] dab0a1f4351d87952b33d9f76ca53af981907a3dbe937677cc566f51268a3582