[INFO] updating cached repository zackmdavis/Jubilant
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/zackmdavis/Jubilant
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/zackmdavis/Jubilant" "work/ex/clippy-test-run/sources/stable/gh/zackmdavis/Jubilant"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/zackmdavis/Jubilant'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/zackmdavis/Jubilant" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zackmdavis/Jubilant"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zackmdavis/Jubilant'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c2f87566db904e3fc7cef3684171617852ea4267
[INFO] sha for GitHub repo zackmdavis/Jubilant: c2f87566db904e3fc7cef3684171617852ea4267
[INFO] validating manifest of zackmdavis/Jubilant on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of zackmdavis/Jubilant on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing zackmdavis/Jubilant
[INFO] finished frobbing zackmdavis/Jubilant
[INFO] frobbed toml for zackmdavis/Jubilant written to work/ex/clippy-test-run/sources/stable/gh/zackmdavis/Jubilant/Cargo.toml
[INFO] started frobbing zackmdavis/Jubilant
[INFO] finished frobbing zackmdavis/Jubilant
[INFO] frobbed toml for zackmdavis/Jubilant written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zackmdavis/Jubilant/Cargo.toml
[INFO] crate zackmdavis/Jubilant has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting zackmdavis/Jubilant against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/zackmdavis/Jubilant:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 795c69e53717ddd9512b70a899d05d802d6dae1d97557e252d9f125582a36b15
[INFO] running `"docker" "start" "-a" "795c69e53717ddd9512b70a899d05d802d6dae1d97557e252d9f125582a36b15"`
[INFO] [stderr]     Checking either v1.1.0
[INFO] [stderr]     Checking libc v0.2.29
[INFO] [stderr]     Checking itertools v0.6.1
[INFO] [stderr]     Checking rand v0.3.16
[INFO] [stderr]     Checking jubilant_hidden_information_fireworks_game v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/game.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn color(&self, color: card::Color) -> u8 {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `player_index` is used to index `models`
[INFO] [stderr]   --> src/player.rs:54:41
[INFO] [stderr]    |
[INFO] [stderr] 54 |                     for player_index in 0..n {
[INFO] [stderr]    |                                         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 54 |                     for (player_index, <item>) in models.iter_mut().enumerate().take(n) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `prior_distribution`
[INFO] [stderr]   --> src/player.rs:90:13
[INFO] [stderr]    |
[INFO] [stderr] 90 |         let prior_distribution = Distribution::new();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: consider using `_prior_distribution` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/game.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fn color(&self, color: card::Color) -> u8 {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `player_index` is used to index `models`
[INFO] [stderr]   --> src/player.rs:54:41
[INFO] [stderr]    |
[INFO] [stderr] 54 |                     for player_index in 0..n {
[INFO] [stderr]    |                                         ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 54 |                     for (player_index, <item>) in models.iter_mut().enumerate().take(n) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.52s
[INFO] running `"docker" "inspect" "795c69e53717ddd9512b70a899d05d802d6dae1d97557e252d9f125582a36b15"`
[INFO] running `"docker" "rm" "-f" "795c69e53717ddd9512b70a899d05d802d6dae1d97557e252d9f125582a36b15"`
[INFO] [stdout] 795c69e53717ddd9512b70a899d05d802d6dae1d97557e252d9f125582a36b15