[INFO] updating cached repository yuzu441/nlp100-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yuzu441/nlp100-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yuzu441/nlp100-rust" "work/ex/clippy-test-run/sources/stable/gh/yuzu441/nlp100-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yuzu441/nlp100-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yuzu441/nlp100-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuzu441/nlp100-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuzu441/nlp100-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61b2ac3d4be5538dfb4980f6dbfef826fd4d0677 [INFO] sha for GitHub repo yuzu441/nlp100-rust: 61b2ac3d4be5538dfb4980f6dbfef826fd4d0677 [INFO] validating manifest of yuzu441/nlp100-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yuzu441/nlp100-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yuzu441/nlp100-rust [INFO] finished frobbing yuzu441/nlp100-rust [INFO] frobbed toml for yuzu441/nlp100-rust written to work/ex/clippy-test-run/sources/stable/gh/yuzu441/nlp100-rust/Cargo.toml [INFO] started frobbing yuzu441/nlp100-rust [INFO] finished frobbing yuzu441/nlp100-rust [INFO] frobbed toml for yuzu441/nlp100-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuzu441/nlp100-rust/Cargo.toml [INFO] crate yuzu441/nlp100-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yuzu441/nlp100-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yuzu441/nlp100-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c89f7b4f328f939fced7e2c15a6881e7389086116413c21d3678d036c33705c1 [INFO] running `"docker" "start" "-a" "c89f7b4f328f939fced7e2c15a6881e7389086116413c21d3678d036c33705c1"` [INFO] [stderr] Checking nlp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | return x.chars().rev().collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.chars().rev().collect::()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / return x.chars() [INFO] [stderr] 16 | | .enumerate() [INFO] [stderr] 17 | | .filter(|&(idx, _c)| idx % 2 == 0) [INFO] [stderr] 18 | | .map(|(_, c)| c) [INFO] [stderr] 19 | | .collect::(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | x.chars() [INFO] [stderr] 16 | .enumerate() [INFO] [stderr] 17 | .filter(|&(idx, _c)| idx % 2 == 0) [INFO] [stderr] 18 | .map(|(_, c)| c) [INFO] [stderr] 19 | .collect::() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / return in1.chars() [INFO] [stderr] 31 | | .zip(in2.chars()) [INFO] [stderr] 32 | | .map(|(x, y)| format!("{}{}", x, y)) [INFO] [stderr] 33 | | .collect::(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | in1.chars() [INFO] [stderr] 31 | .zip(in2.chars()) [INFO] [stderr] 32 | .map(|(x, y)| format!("{}{}", x, y)) [INFO] [stderr] 33 | .collect::() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / return sentence.split_whitespace() [INFO] [stderr] 46 | | .map(|word| word.trim_right_matches(pat)) [INFO] [stderr] 47 | | .map(|w| w.len()) [INFO] [stderr] 48 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | sentence.split_whitespace() [INFO] [stderr] 46 | .map(|word| word.trim_right_matches(pat)) [INFO] [stderr] 47 | .map(|w| w.len()) [INFO] [stderr] 48 | .collect::>() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return sentence.split_whitespace() [INFO] [stderr] 60 | | .enumerate() [INFO] [stderr] 61 | | .map(|(idx, w)| unsafe { [INFO] [stderr] 62 | | let idx = idx + 1;
 [INFO] [stderr] ... | [INFO] [stderr] 68 | | }) [INFO] [stderr] 69 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | sentence.split_whitespace() [INFO] [stderr] 60 | .enumerate() [INFO] [stderr] 61 | .map(|(idx, w)| unsafe { [INFO] [stderr] 62 | let idx = idx + 1;
 [INFO] [stderr] 63 | let c = match elements_idx.contains(&idx) { [INFO] [stderr] 64 | true => w.slice_unchecked(0, 1), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | return x.chars().rev().collect::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.chars().rev().collect::()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / return x.chars() [INFO] [stderr] 16 | | .enumerate() [INFO] [stderr] 17 | | .filter(|&(idx, _c)| idx % 2 == 0) [INFO] [stderr] 18 | | .map(|(_, c)| c) [INFO] [stderr] 19 | | .collect::(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | x.chars() [INFO] [stderr] 16 | .enumerate() [INFO] [stderr] 17 | .filter(|&(idx, _c)| idx % 2 == 0) [INFO] [stderr] 18 | .map(|(_, c)| c) [INFO] [stderr] 19 | .collect::() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / return in1.chars() [INFO] [stderr] 31 | | .zip(in2.chars()) [INFO] [stderr] 32 | | .map(|(x, y)| format!("{}{}", x, y)) [INFO] [stderr] 33 | | .collect::(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | in1.chars() [INFO] [stderr] 31 | .zip(in2.chars()) [INFO] [stderr] 32 | .map(|(x, y)| format!("{}{}", x, y)) [INFO] [stderr] 33 | .collect::() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / return sentence.split_whitespace() [INFO] [stderr] 46 | | .map(|word| word.trim_right_matches(pat)) [INFO] [stderr] 47 | | .map(|w| w.len()) [INFO] [stderr] 48 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | sentence.split_whitespace() [INFO] [stderr] 46 | .map(|word| word.trim_right_matches(pat)) [INFO] [stderr] 47 | .map(|w| w.len()) [INFO] [stderr] 48 | .collect::>() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chapter01.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / return sentence.split_whitespace() [INFO] [stderr] 60 | | .enumerate() [INFO] [stderr] 61 | | .map(|(idx, w)| unsafe { [INFO] [stderr] 62 | | let idx = idx + 1;
 [INFO] [stderr] ... | [INFO] [stderr] 68 | | }) [INFO] [stderr] 69 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 59 | sentence.split_whitespace() [INFO] [stderr] 60 | .enumerate() [INFO] [stderr] 61 | .map(|(idx, w)| unsafe { [INFO] [stderr] 62 | let idx = idx + 1;
 [INFO] [stderr] 63 | let c = match elements_idx.contains(&idx) { [INFO] [stderr] 64 | true => w.slice_unchecked(0, 1), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/chapter01.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | true => w.slice_unchecked(0, 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/chapter01.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | false => w.slice_unchecked(0, 2) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/chapter01.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | let c = match elements_idx.contains(&idx) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 64 | | true => w.slice_unchecked(0, 1), [INFO] [stderr] 65 | | false => w.slice_unchecked(0, 2) [INFO] [stderr] 66 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if elements_idx.contains(&idx) { w.slice_unchecked(0, 1) } else { w.slice_unchecked(0, 2) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/chapter01.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | true => w.slice_unchecked(0, 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/chapter01.rs:65:28 [INFO] [stderr] | [INFO] [stderr] 65 | false => w.slice_unchecked(0, 2) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/chapter01.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | let c = match elements_idx.contains(&idx) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 64 | | true => w.slice_unchecked(0, 1), [INFO] [stderr] 65 | | false => w.slice_unchecked(0, 2) [INFO] [stderr] 66 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if elements_idx.contains(&idx) { w.slice_unchecked(0, 1) } else { w.slice_unchecked(0, 2) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "c89f7b4f328f939fced7e2c15a6881e7389086116413c21d3678d036c33705c1"` [INFO] running `"docker" "rm" "-f" "c89f7b4f328f939fced7e2c15a6881e7389086116413c21d3678d036c33705c1"` [INFO] [stdout] c89f7b4f328f939fced7e2c15a6881e7389086116413c21d3678d036c33705c1