[INFO] updating cached repository yupferris/kaze [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yupferris/kaze [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yupferris/kaze" "work/ex/clippy-test-run/sources/stable/gh/yupferris/kaze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yupferris/kaze'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yupferris/kaze" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yupferris/kaze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yupferris/kaze'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 42eb5f1d11bf2b84a445e529fe7a0fbea2b5de01 [INFO] sha for GitHub repo yupferris/kaze: 42eb5f1d11bf2b84a445e529fe7a0fbea2b5de01 [INFO] validating manifest of yupferris/kaze on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yupferris/kaze on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yupferris/kaze [INFO] finished frobbing yupferris/kaze [INFO] frobbed toml for yupferris/kaze written to work/ex/clippy-test-run/sources/stable/gh/yupferris/kaze/Cargo.toml [INFO] started frobbing yupferris/kaze [INFO] finished frobbing yupferris/kaze [INFO] frobbed toml for yupferris/kaze written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yupferris/kaze/Cargo.toml [INFO] crate yupferris/kaze has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yupferris/kaze against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yupferris/kaze:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc542d4e132a53eb6d88c47b40ab62f100d5bb3ea55c9ecba86d8c9298241ee4 [INFO] running `"docker" "start" "-a" "bc542d4e132a53eb6d88c47b40ab62f100d5bb3ea55c9ecba86d8c9298241ee4"` [INFO] [stderr] Checking getopts v0.2.15 [INFO] [stderr] Checking ansi_term v0.7.5 [INFO] [stderr] Checking rand v0.3.17 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking serde v0.6.15 [INFO] [stderr] Checking serde_json v0.6.1 [INFO] [stderr] Checking kaze v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | level: level [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | level: level [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/current_directory_helpers.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | old_dir: old_dir [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `old_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | sim_top: sim_top, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sim_top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | devices: devices [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/current_directory_helpers.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | old_dir: old_dir [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `old_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | sim_top: sim_top, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sim_top` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | devices: devices [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `devices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:1:18 [INFO] [stderr] | [INFO] [stderr] 1 | pub const NAME: &'static str = "kaze"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:2:31 [INFO] [stderr] | [INFO] [stderr] 2 | pub const PROJECT_FILE_NAME: &'static str = NAME; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | pub const PROJECT_FILE_EXTENSION: &'static str = "json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:4:30 [INFO] [stderr] | [INFO] [stderr] 4 | pub const WORKING_DIR_NAME: &'static str = NAME; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:1:18 [INFO] [stderr] | [INFO] [stderr] 1 | pub const NAME: &'static str = "kaze"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:2:31 [INFO] [stderr] | [INFO] [stderr] 2 | pub const PROJECT_FILE_NAME: &'static str = NAME; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | pub const PROJECT_FILE_EXTENSION: &'static str = "json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:4:30 [INFO] [stderr] | [INFO] [stderr] 4 | pub const WORKING_DIR_NAME: &'static str = NAME; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(name: &String, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(name: &str, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 19 | let sim_top_name = name.to_string() + "_tb"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | fn create_project_dir(name: &String, logger: &Logger) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:32:34 [INFO] [stderr] | [INFO] [stderr] 32 | fn create_project_dir_impl(name: &String, logger: &Logger) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | fn create_project_file(name: &String, top_name: &String, sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:40:49 [INFO] [stderr] | [INFO] [stderr] 40 | fn create_project_file(name: &String, top_name: &String, sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:40:72 [INFO] [stderr] | [INFO] [stderr] 40 | fn create_project_file(name: &String, top_name: &String, sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | fn create_top_file(top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:80:38 [INFO] [stderr] | [INFO] [stderr] 80 | fn create_sim_top_file(sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(name: &String, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(name: &str, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 19 | let sim_top_name = name.to_string() + "_tb"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | fn create_project_dir(name: &String, logger: &Logger) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:32:34 [INFO] [stderr] | [INFO] [stderr] 32 | fn create_project_dir_impl(name: &String, logger: &Logger) -> io::Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/quartus.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | if project.devices.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project.devices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | fn create_project_file(name: &String, top_name: &String, sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:40:49 [INFO] [stderr] | [INFO] [stderr] 40 | fn create_project_file(name: &String, top_name: &String, sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:40:72 [INFO] [stderr] | [INFO] [stderr] 40 | fn create_project_file(name: &String, top_name: &String, sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | fn create_top_file(top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/new.rs:80:38 [INFO] [stderr] | [INFO] [stderr] 80 | fn create_sim_top_file(sim_top_name: &String, project_dir: &PathBuf, logger: &Logger) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | fn parse_args_matches(args: &Vec, opts: &mut Options) -> Result<(Operation, Logger), String> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:111:63 [INFO] [stderr] | [INFO] [stderr] 111 | println!("{} {}", Red.paint("error:"), White.bold().paint(format!("{}", message))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `message.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/quartus.rs:55:8 [INFO] [stderr] | [INFO] [stderr] 55 | if project.devices.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!project.devices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | fn parse_args_matches(args: &Vec, opts: &mut Options) -> Result<(Operation, Logger), String> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:111:63 [INFO] [stderr] | [INFO] [stderr] 111 | println!("{} {}", Red.paint("error:"), White.bold().paint(format!("{}", message))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `message.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.26s [INFO] running `"docker" "inspect" "bc542d4e132a53eb6d88c47b40ab62f100d5bb3ea55c9ecba86d8c9298241ee4"` [INFO] running `"docker" "rm" "-f" "bc542d4e132a53eb6d88c47b40ab62f100d5bb3ea55c9ecba86d8c9298241ee4"` [INFO] [stdout] bc542d4e132a53eb6d88c47b40ab62f100d5bb3ea55c9ecba86d8c9298241ee4