[INFO] updating cached repository ypypy28/shuffle_files [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ypypy28/shuffle_files [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ypypy28/shuffle_files" "work/ex/clippy-test-run/sources/stable/gh/ypypy28/shuffle_files"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ypypy28/shuffle_files'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ypypy28/shuffle_files" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypypy28/shuffle_files"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypypy28/shuffle_files'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fc4c8005b51e92177a13f0e2451f24c3507eeb3d [INFO] sha for GitHub repo ypypy28/shuffle_files: fc4c8005b51e92177a13f0e2451f24c3507eeb3d [INFO] validating manifest of ypypy28/shuffle_files on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ypypy28/shuffle_files on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ypypy28/shuffle_files [INFO] finished frobbing ypypy28/shuffle_files [INFO] frobbed toml for ypypy28/shuffle_files written to work/ex/clippy-test-run/sources/stable/gh/ypypy28/shuffle_files/Cargo.toml [INFO] started frobbing ypypy28/shuffle_files [INFO] finished frobbing ypypy28/shuffle_files [INFO] frobbed toml for ypypy28/shuffle_files written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypypy28/shuffle_files/Cargo.toml [INFO] crate ypypy28/shuffle_files has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ypypy28/shuffle_files against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypypy28/shuffle_files:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] caade2c9f5840ee1d0b9f67c207d7a47e623dd3fa45e10713a61c8908c70371e [INFO] running `"docker" "start" "-a" "caade2c9f5840ee1d0b9f67c207d7a47e623dd3fa45e10713a61c8908c70371e"` [INFO] [stderr] Checking libc v0.2.11 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking shuffle_files v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if file.path().extension().is_some() { [INFO] [stderr] 31 | | if file.path().extension().unwrap().to_string_lossy() == ext { [INFO] [stderr] 32 | | // println!("UAAAA"); [INFO] [stderr] 33 | | // println!("{:?}", file.path()); [INFO] [stderr] ... | [INFO] [stderr] 38 | | [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if file.path().extension().is_some() && file.path().extension().unwrap().to_string_lossy() == ext { [INFO] [stderr] 31 | // println!("UAAAA"); [INFO] [stderr] 32 | // println!("{:?}", file.path()); [INFO] [stderr] 33 | // println!("FILE_NAME: {}", file.file_name().to_string_lossy()); [INFO] [stderr] 34 | // println!("EXTENTION: {:?}", file.path().extension().unwrap() ); [INFO] [stderr] 35 | files.push(file); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match ren { [INFO] [stderr] 52 | | Ok(_) => count +=1, [INFO] [stderr] 53 | | Err(..) => {} [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = ren { count +=1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if file.path().extension().is_some() { [INFO] [stderr] 31 | | if file.path().extension().unwrap().to_string_lossy() == ext { [INFO] [stderr] 32 | | // println!("UAAAA"); [INFO] [stderr] 33 | | // println!("{:?}", file.path()); [INFO] [stderr] ... | [INFO] [stderr] 38 | | [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if file.path().extension().is_some() && file.path().extension().unwrap().to_string_lossy() == ext { [INFO] [stderr] 31 | // println!("UAAAA"); [INFO] [stderr] 32 | // println!("{:?}", file.path()); [INFO] [stderr] 33 | // println!("FILE_NAME: {}", file.file_name().to_string_lossy()); [INFO] [stderr] 34 | // println!("EXTENTION: {:?}", file.path().extension().unwrap() ); [INFO] [stderr] 35 | files.push(file); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match ren { [INFO] [stderr] 52 | | Ok(_) => count +=1, [INFO] [stderr] 53 | | Err(..) => {} [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = ren { count +=1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.04s [INFO] running `"docker" "inspect" "caade2c9f5840ee1d0b9f67c207d7a47e623dd3fa45e10713a61c8908c70371e"` [INFO] running `"docker" "rm" "-f" "caade2c9f5840ee1d0b9f67c207d7a47e623dd3fa45e10713a61c8908c70371e"` [INFO] [stdout] caade2c9f5840ee1d0b9f67c207d7a47e623dd3fa45e10713a61c8908c70371e