[INFO] updating cached repository ypkulkar/infix_to_postfix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ypkulkar/infix_to_postfix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ypkulkar/infix_to_postfix" "work/ex/clippy-test-run/sources/stable/gh/ypkulkar/infix_to_postfix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ypkulkar/infix_to_postfix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ypkulkar/infix_to_postfix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/infix_to_postfix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/infix_to_postfix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8182f88e20c8d721cef222f0bb8abe55b63614e1 [INFO] sha for GitHub repo ypkulkar/infix_to_postfix: 8182f88e20c8d721cef222f0bb8abe55b63614e1 [INFO] validating manifest of ypkulkar/infix_to_postfix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ypkulkar/infix_to_postfix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ypkulkar/infix_to_postfix [INFO] finished frobbing ypkulkar/infix_to_postfix [INFO] frobbed toml for ypkulkar/infix_to_postfix written to work/ex/clippy-test-run/sources/stable/gh/ypkulkar/infix_to_postfix/Cargo.toml [INFO] started frobbing ypkulkar/infix_to_postfix [INFO] finished frobbing ypkulkar/infix_to_postfix [INFO] frobbed toml for ypkulkar/infix_to_postfix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/infix_to_postfix/Cargo.toml [INFO] crate ypkulkar/infix_to_postfix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ypkulkar/infix_to_postfix against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ypkulkar/infix_to_postfix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e658a117ad980290adb1e735d8b5a84cc2599bdde681fcc991238ffb2cb870e7 [INFO] running `"docker" "start" "-a" "e658a117ad980290adb1e735d8b5a84cc2599bdde681fcc991238ffb2cb870e7"` [INFO] [stderr] Checking your v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | return Some(output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(output)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | return Some(output); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(output)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/lib.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | &InfixToken::Operand(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/lib.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | &InfixToken::Operator(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/lib.rs:172:31 [INFO] [stderr] | [INFO] [stderr] 172 | InfixToken::Operand(x) => break, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn infix_to_postfix(tokens: &[InfixToken]) -> Option> { [INFO] [stderr] 32 | | let mut stack: Vec = vec![]; [INFO] [stderr] 33 | | let mut output: Vec = vec![]; [INFO] [stderr] 34 | | [INFO] [stderr] ... | [INFO] [stderr] 418 | | return Some(output); [INFO] [stderr] 419 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:98:10 [INFO] [stderr] | [INFO] [stderr] 98 | let ref k = tokens[index]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let k = &tokens[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:99:6 [INFO] [stderr] | [INFO] [stderr] 99 | match k{ [INFO] [stderr] | ____________^ [INFO] [stderr] 100 | | &InfixToken::Operand(x) => { [INFO] [stderr] 101 | | if tokens[index+1] == InfixToken::Operand(x){ [INFO] [stderr] 102 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 124 | | [INFO] [stderr] 125 | | } [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *k{ [INFO] [stderr] 100 | InfixToken::Operand(x) => { [INFO] [stderr] 101 | if tokens[index+1] == InfixToken::Operand(x){ [INFO] [stderr] 102 | return None; [INFO] [stderr] 103 | } [INFO] [stderr] 104 | if tokens[index+1] == InfixToken::LeftParen{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:132:10 [INFO] [stderr] | [INFO] [stderr] 132 | let ref k = tokens[index]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let k = &tokens[index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:133:6 [INFO] [stderr] | [INFO] [stderr] 133 | match k{ [INFO] [stderr] | ____________^ [INFO] [stderr] 134 | | &InfixToken::Operand(x) => { [INFO] [stderr] 135 | | [INFO] [stderr] 136 | | if tokens[index-1] == InfixToken::RightParen{ [INFO] [stderr] ... | [INFO] [stderr] 145 | | _ => {}, [INFO] [stderr] 146 | | } [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 133 | match *k{ [INFO] [stderr] 134 | InfixToken::Operand(x) => { [INFO] [stderr] 135 | [INFO] [stderr] 136 | if tokens[index-1] == InfixToken::RightParen{ [INFO] [stderr] 137 | return None; [INFO] [stderr] 138 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:159:6 [INFO] [stderr] | [INFO] [stderr] 159 | match token{ [INFO] [stderr] | _________^ [INFO] [stderr] 160 | | &InfixToken::Operand(x) => output.push(PostfixToken::Operand(x)), [INFO] [stderr] 161 | | &InfixToken::LeftParen => stack.push(InfixToken::LeftParen), [INFO] [stderr] 162 | | [INFO] [stderr] ... | [INFO] [stderr] 404 | | [INFO] [stderr] 405 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *token{ [INFO] [stderr] 160 | InfixToken::Operand(x) => output.push(PostfixToken::Operand(x)), [INFO] [stderr] 161 | InfixToken::LeftParen => stack.push(InfixToken::LeftParen), [INFO] [stderr] 162 | [INFO] [stderr] 163 | InfixToken::RightParen => [INFO] [stderr] 164 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:180:11 [INFO] [stderr] | [INFO] [stderr] 180 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:237:11 [INFO] [stderr] | [INFO] [stderr] 237 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/lib.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | &InfixToken::Operand(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/lib.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | &InfixToken::Operator(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/lib.rs:172:31 [INFO] [stderr] | [INFO] [stderr] 172 | InfixToken::Operand(x) => break, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:292:11 [INFO] [stderr] | [INFO] [stderr] 292 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:349:11 [INFO] [stderr] | [INFO] [stderr] 349 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:408:11 [INFO] [stderr] | [INFO] [stderr] 408 | while stack.len() != 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:410:6 [INFO] [stderr] | [INFO] [stderr] 410 | match x{ [INFO] [stderr] | _________^ [INFO] [stderr] 411 | | InfixToken::Operator(x) => output.push(PostfixToken::Operator(x)), [INFO] [stderr] 412 | | _ => {},//return None,//////////////////////////////////////////////////////////////////////////////// [INFO] [stderr] 413 | | } [INFO] [stderr] | |_________^ help: try this: `if let InfixToken::Operator(x) = x { output.push(PostfixToken::Operator(x)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn infix_to_postfix(tokens: &[InfixToken]) -> Option> { [INFO] [stderr] 32 | | let mut stack: Vec = vec![]; [INFO] [stderr] 33 | | let mut output: Vec = vec![]; [INFO] [stderr] 34 | | [INFO] [stderr] ... | [INFO] [stderr] 418 | | return Some(output); [INFO] [stderr] 419 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:98:10 [INFO] [stderr] | [INFO] [stderr] 98 | let ref k = tokens[index]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let k = &tokens[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:99:6 [INFO] [stderr] | [INFO] [stderr] 99 | match k{ [INFO] [stderr] | ____________^ [INFO] [stderr] 100 | | &InfixToken::Operand(x) => { [INFO] [stderr] 101 | | if tokens[index+1] == InfixToken::Operand(x){ [INFO] [stderr] 102 | | return None; [INFO] [stderr] ... | [INFO] [stderr] 124 | | [INFO] [stderr] 125 | | } [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 99 | match *k{ [INFO] [stderr] 100 | InfixToken::Operand(x) => { [INFO] [stderr] 101 | if tokens[index+1] == InfixToken::Operand(x){ [INFO] [stderr] 102 | return None; [INFO] [stderr] 103 | } [INFO] [stderr] 104 | if tokens[index+1] == InfixToken::LeftParen{ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:132:10 [INFO] [stderr] | [INFO] [stderr] 132 | let ref k = tokens[index]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let k = &tokens[index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:133:6 [INFO] [stderr] | [INFO] [stderr] 133 | match k{ [INFO] [stderr] | ____________^ [INFO] [stderr] 134 | | &InfixToken::Operand(x) => { [INFO] [stderr] 135 | | [INFO] [stderr] 136 | | if tokens[index-1] == InfixToken::RightParen{ [INFO] [stderr] ... | [INFO] [stderr] 145 | | _ => {}, [INFO] [stderr] 146 | | } [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 133 | match *k{ [INFO] [stderr] 134 | InfixToken::Operand(x) => { [INFO] [stderr] 135 | [INFO] [stderr] 136 | if tokens[index-1] == InfixToken::RightParen{ [INFO] [stderr] 137 | return None; [INFO] [stderr] 138 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:159:6 [INFO] [stderr] | [INFO] [stderr] 159 | match token{ [INFO] [stderr] | _________^ [INFO] [stderr] 160 | | &InfixToken::Operand(x) => output.push(PostfixToken::Operand(x)), [INFO] [stderr] 161 | | &InfixToken::LeftParen => stack.push(InfixToken::LeftParen), [INFO] [stderr] 162 | | [INFO] [stderr] ... | [INFO] [stderr] 404 | | [INFO] [stderr] 405 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *token{ [INFO] [stderr] 160 | InfixToken::Operand(x) => output.push(PostfixToken::Operand(x)), [INFO] [stderr] 161 | InfixToken::LeftParen => stack.push(InfixToken::LeftParen), [INFO] [stderr] 162 | [INFO] [stderr] 163 | InfixToken::RightParen => [INFO] [stderr] 164 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:180:11 [INFO] [stderr] | [INFO] [stderr] 180 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:237:11 [INFO] [stderr] | [INFO] [stderr] 237 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:292:11 [INFO] [stderr] | [INFO] [stderr] 292 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:349:11 [INFO] [stderr] | [INFO] [stderr] 349 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:357:13 [INFO] [stderr] | [INFO] [stderr] 357 | if stack.len() == 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:408:11 [INFO] [stderr] | [INFO] [stderr] 408 | while stack.len() != 0{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:410:6 [INFO] [stderr] | [INFO] [stderr] 410 | match x{ [INFO] [stderr] | _________^ [INFO] [stderr] 411 | | InfixToken::Operator(x) => output.push(PostfixToken::Operator(x)), [INFO] [stderr] 412 | | _ => {},//return None,//////////////////////////////////////////////////////////////////////////////// [INFO] [stderr] 413 | | } [INFO] [stderr] | |_________^ help: try this: `if let InfixToken::Operator(x) = x { output.push(PostfixToken::Operator(x)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "e658a117ad980290adb1e735d8b5a84cc2599bdde681fcc991238ffb2cb870e7"` [INFO] running `"docker" "rm" "-f" "e658a117ad980290adb1e735d8b5a84cc2599bdde681fcc991238ffb2cb870e7"` [INFO] [stdout] e658a117ad980290adb1e735d8b5a84cc2599bdde681fcc991238ffb2cb870e7