[INFO] updating cached repository yogaxpto/tic-tac-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yogaxpto/tic-tac-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yogaxpto/tic-tac-rust" "work/ex/clippy-test-run/sources/stable/gh/yogaxpto/tic-tac-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yogaxpto/tic-tac-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yogaxpto/tic-tac-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogaxpto/tic-tac-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogaxpto/tic-tac-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c5a6301fe469a012f3512dc538167d56d6c98353 [INFO] sha for GitHub repo yogaxpto/tic-tac-rust: c5a6301fe469a012f3512dc538167d56d6c98353 [INFO] validating manifest of yogaxpto/tic-tac-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yogaxpto/tic-tac-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yogaxpto/tic-tac-rust [INFO] finished frobbing yogaxpto/tic-tac-rust [INFO] frobbed toml for yogaxpto/tic-tac-rust written to work/ex/clippy-test-run/sources/stable/gh/yogaxpto/tic-tac-rust/Cargo.toml [INFO] started frobbing yogaxpto/tic-tac-rust [INFO] finished frobbing yogaxpto/tic-tac-rust [INFO] frobbed toml for yogaxpto/tic-tac-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogaxpto/tic-tac-rust/Cargo.toml [INFO] crate yogaxpto/tic-tac-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yogaxpto/tic-tac-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yogaxpto/tic-tac-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b56bcdc0984e1fa6ef52ff07dcd6aed9657f43e16028155a668c904f895c485 [INFO] running `"docker" "start" "-a" "7b56bcdc0984e1fa6ef52ff07dcd6aed9657f43e16028155a668c904f895c485"` [INFO] [stderr] Checking tic-tac-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return Some(Coordinate::new(a, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Coordinate::new(a, b))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return State::Empty; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `State::Empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | return result.chars().nth(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.chars().nth(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | return stdin; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `stdin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | return Some(Coordinate::new(a, b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Coordinate::new(a, b))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return State::Empty; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `State::Empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | return result.chars().nth(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.chars().nth(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | return stdin; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `stdin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `bot_symbol` [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let bot_symbol: State = State::opponent_symbol(player_symbol); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_bot_symbol` instead [INFO] [stderr] warning: unused variable: `bot_symbol` [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | let bot_symbol: State = State::opponent_symbol(player_symbol); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_bot_symbol` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `strategy` [INFO] [stderr] --> src/main.rs:169:28 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn bot_play(&self, strategy: Strategy) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_strategy` instead [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `strategy` [INFO] [stderr] --> src/main.rs:169:28 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn bot_play(&self, strategy: Strategy) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_strategy` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `child` [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn child(&mut self, symbol: State, row: usize, col: usize, player: State) -> Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: method is never used: `child` [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn child(&mut self, symbol: State, row: usize, col: usize, player: State) -> Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | fn is_valid(self, board: [[State; 3]; 3]) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | fn is_valid(self, board: [[State; 3]; 3]) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if list_iter.contains(&a) & &list_iter.contains(&b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `list_iter.contains(&b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | / match Coordinate::is_valid(input.clone().unwrap(), self.board) { [INFO] [stderr] 161 | | true => break, [INFO] [stderr] 162 | | false => println!("Invalid Position!") [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if Coordinate::is_valid(input.clone().unwrap(), self.board) { break } else { println!("Invalid Position!") }` [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if list_iter.contains(&a) & &list_iter.contains(&b) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^----------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `list_iter.contains(&b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | io.lock().read_line(&mut stdin); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / let mut game_state: Node; [INFO] [stderr] 226 | | if turn == Turn::Player { [INFO] [stderr] 227 | | game_state = Node::root(player_symbol); [INFO] [stderr] 228 | | } else { [INFO] [stderr] 229 | | game_state = Node::root(player_symbol); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let game_state = if turn == Turn::Player { Node::root(player_symbol) } else { Node::root(player_symbol) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:228:12 [INFO] [stderr] | [INFO] [stderr] 228 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 229 | | game_state = Node::root(player_symbol); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:226:29 [INFO] [stderr] | [INFO] [stderr] 226 | if turn == Turn::Player { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | game_state = Node::root(player_symbol); [INFO] [stderr] 228 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | / match Coordinate::is_valid(input.clone().unwrap(), self.board) { [INFO] [stderr] 161 | | true => break, [INFO] [stderr] 162 | | false => println!("Invalid Position!") [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if Coordinate::is_valid(input.clone().unwrap(), self.board) { break } else { println!("Invalid Position!") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | io.lock().read_line(&mut stdin); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:225:5 [INFO] [stderr] | [INFO] [stderr] 225 | / let mut game_state: Node; [INFO] [stderr] 226 | | if turn == Turn::Player { [INFO] [stderr] 227 | | game_state = Node::root(player_symbol); [INFO] [stderr] 228 | | } else { [INFO] [stderr] 229 | | game_state = Node::root(player_symbol); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let game_state = if turn == Turn::Player { Node::root(player_symbol) } else { Node::root(player_symbol) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:228:12 [INFO] [stderr] | [INFO] [stderr] 228 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 229 | | game_state = Node::root(player_symbol); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:226:29 [INFO] [stderr] | [INFO] [stderr] 226 | if turn == Turn::Player { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 227 | | game_state = Node::root(player_symbol); [INFO] [stderr] 228 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] error: Could not compile `tic-tac-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] [INFO] [stderr] error: Could not compile `tic-tac-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7b56bcdc0984e1fa6ef52ff07dcd6aed9657f43e16028155a668c904f895c485"` [INFO] running `"docker" "rm" "-f" "7b56bcdc0984e1fa6ef52ff07dcd6aed9657f43e16028155a668c904f895c485"` [INFO] [stdout] 7b56bcdc0984e1fa6ef52ff07dcd6aed9657f43e16028155a668c904f895c485