[INFO] updating cached repository ymmtmdk/shadow_cost_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ymmtmdk/shadow_cost_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ymmtmdk/shadow_cost_rust" "work/ex/clippy-test-run/sources/stable/gh/ymmtmdk/shadow_cost_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ymmtmdk/shadow_cost_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ymmtmdk/shadow_cost_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ymmtmdk/shadow_cost_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ymmtmdk/shadow_cost_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3503bcbde45271f3dd4010fb9d0d611e55c51a0a [INFO] sha for GitHub repo ymmtmdk/shadow_cost_rust: 3503bcbde45271f3dd4010fb9d0d611e55c51a0a [INFO] validating manifest of ymmtmdk/shadow_cost_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ymmtmdk/shadow_cost_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ymmtmdk/shadow_cost_rust [INFO] finished frobbing ymmtmdk/shadow_cost_rust [INFO] frobbed toml for ymmtmdk/shadow_cost_rust written to work/ex/clippy-test-run/sources/stable/gh/ymmtmdk/shadow_cost_rust/Cargo.toml [INFO] started frobbing ymmtmdk/shadow_cost_rust [INFO] finished frobbing ymmtmdk/shadow_cost_rust [INFO] frobbed toml for ymmtmdk/shadow_cost_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ymmtmdk/shadow_cost_rust/Cargo.toml [INFO] crate ymmtmdk/shadow_cost_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ymmtmdk/shadow_cost_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ymmtmdk/shadow_cost_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f6f91691b1ce48ffc068cb809aa731f26528c664e159340c1128c1d1fcd4047 [INFO] running `"docker" "start" "-a" "4f6f91691b1ce48ffc068cb809aa731f26528c664e159340c1128c1d1fcd4047"` [INFO] [stderr] Checking shadow_cost_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:17 [INFO] [stderr] | [INFO] [stderr] 228 | hand: hand, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hand` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | deck: deck, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deck` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | turn_max: turn_max, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `turn_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:331:17 [INFO] [stderr] | [INFO] [stderr] 331 | deck_size: deck_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deck_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | turn_max: turn_max, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `turn_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:17 [INFO] [stderr] | [INFO] [stderr] 228 | hand: hand, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hand` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | deck: deck, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deck` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | turn_max: turn_max, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `turn_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:331:17 [INFO] [stderr] | [INFO] [stderr] 331 | deck_size: deck_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `deck_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | turn_max: turn_max, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `turn_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | let mut t = self.cache.get_mut(key).unwrap(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shadow_cost::Cards` [INFO] [stderr] --> src/lib.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Cards{ [INFO] [stderr] 32 | | Cards{ [INFO] [stderr] 33 | | nums: [0; COST_MAX as usize], [INFO] [stderr] 34 | | size: 0, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] 26 | pub struct Cards { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shadow_cost::Score` [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / pub fn new() -> Score{ [INFO] [stderr] 146 | | Score{ [INFO] [stderr] 147 | | count: 0, [INFO] [stderr] 148 | | loss: 0, [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | #[derive(Default)] [INFO] [stderr] 140 | pub struct Score{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | self.loss += loss as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(loss)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:158:32 [INFO] [stderr] | [INFO] [stderr] 158 | self.loss as f64 / self.count as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | for turn in 1..turn_max+1{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=turn_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | let mut t = self.cache.get_mut(key).unwrap(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shadow_cost::Cards` [INFO] [stderr] --> src/lib.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Cards{ [INFO] [stderr] 32 | | Cards{ [INFO] [stderr] 33 | | nums: [0; COST_MAX as usize], [INFO] [stderr] 34 | | size: 0, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Default)] [INFO] [stderr] 26 | pub struct Cards { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shadow_cost::Score` [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / pub fn new() -> Score{ [INFO] [stderr] 146 | | Score{ [INFO] [stderr] 147 | | count: 0, [INFO] [stderr] 148 | | loss: 0, [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 139 | #[derive(Default)] [INFO] [stderr] 140 | pub struct Score{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | self.loss += loss as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(loss)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:158:32 [INFO] [stderr] | [INFO] [stderr] 158 | self.loss as f64 / self.count as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | for turn in 1..turn_max+1{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `1..=turn_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:8:38 [INFO] [stderr] | [INFO] [stderr] 8 | let deck_size: u32 = argv.next().unwrap_or("30".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "30".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | let turn_max: u32 = argv.next().unwrap_or("10".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "10".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:10:39 [INFO] [stderr] | [INFO] [stderr] 10 | let loop_count: u32 = argv.next().unwrap_or("100".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "100".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:11:40 [INFO] [stderr] | [INFO] [stderr] 11 | let trial_count: u32 = argv.next().unwrap_or("100".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "100".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:8:38 [INFO] [stderr] | [INFO] [stderr] 8 | let deck_size: u32 = argv.next().unwrap_or("30".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "30".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | let turn_max: u32 = argv.next().unwrap_or("10".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "10".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:10:39 [INFO] [stderr] | [INFO] [stderr] 10 | let loop_count: u32 = argv.next().unwrap_or("100".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "100".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:11:40 [INFO] [stderr] | [INFO] [stderr] 11 | let trial_count: u32 = argv.next().unwrap_or("100".to_string()).parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "100".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "4f6f91691b1ce48ffc068cb809aa731f26528c664e159340c1128c1d1fcd4047"` [INFO] running `"docker" "rm" "-f" "4f6f91691b1ce48ffc068cb809aa731f26528c664e159340c1128c1d1fcd4047"` [INFO] [stdout] 4f6f91691b1ce48ffc068cb809aa731f26528c664e159340c1128c1d1fcd4047