[INFO] updating cached repository ylabs82/decider [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ylabs82/decider [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ylabs82/decider" "work/ex/clippy-test-run/sources/stable/gh/ylabs82/decider"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ylabs82/decider'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ylabs82/decider" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ylabs82/decider"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ylabs82/decider'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 360d73d65e3367387b84641e1ec05cc2082b0fea [INFO] sha for GitHub repo ylabs82/decider: 360d73d65e3367387b84641e1ec05cc2082b0fea [INFO] validating manifest of ylabs82/decider on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ylabs82/decider on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ylabs82/decider [INFO] finished frobbing ylabs82/decider [INFO] frobbed toml for ylabs82/decider written to work/ex/clippy-test-run/sources/stable/gh/ylabs82/decider/Cargo.toml [INFO] started frobbing ylabs82/decider [INFO] finished frobbing ylabs82/decider [INFO] frobbed toml for ylabs82/decider written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ylabs82/decider/Cargo.toml [INFO] crate ylabs82/decider has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ylabs82/decider against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ylabs82/decider:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6d6673a9d480c00299f38497cb38fc4cbaf6145873ce57307e94b94bc978115 [INFO] running `"docker" "start" "-a" "f6d6673a9d480c00299f38497cb38fc4cbaf6145873ce57307e94b94bc978115"` [INFO] [stderr] Checking libc v0.2.16 [INFO] [stderr] Checking same-file v1.0.2 [INFO] [stderr] Checking getopts v0.2.14 [INFO] [stderr] Checking walkdir v2.1.4 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking decider v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / if entry.path().is_file() && entry.path().extension() != None { [INFO] [stderr] 82 | | if extensions.contains(&entry.path().extension().unwrap().to_str().unwrap()) { [INFO] [stderr] 83 | | entries.push(entry); [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | if entry.path().is_file() && entry.path().extension() != None && extensions.contains(&entry.path().extension().unwrap().to_str().unwrap()) { [INFO] [stderr] 82 | entries.push(entry); [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / if entry.path().is_file() && entry.path().extension() != None { [INFO] [stderr] 82 | | if extensions.contains(&entry.path().extension().unwrap().to_str().unwrap()) { [INFO] [stderr] 83 | | entries.push(entry); [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | if entry.path().is_file() && entry.path().extension() != None && extensions.contains(&entry.path().extension().unwrap().to_str().unwrap()) { [INFO] [stderr] 82 | entries.push(entry); [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.63s [INFO] running `"docker" "inspect" "f6d6673a9d480c00299f38497cb38fc4cbaf6145873ce57307e94b94bc978115"` [INFO] running `"docker" "rm" "-f" "f6d6673a9d480c00299f38497cb38fc4cbaf6145873ce57307e94b94bc978115"` [INFO] [stdout] f6d6673a9d480c00299f38497cb38fc4cbaf6145873ce57307e94b94bc978115