[INFO] updating cached repository ygree/rust_examples [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ygree/rust_examples [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ygree/rust_examples" "work/ex/clippy-test-run/sources/stable/gh/ygree/rust_examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ygree/rust_examples'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ygree/rust_examples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ygree/rust_examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ygree/rust_examples'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 45f23c23ef3c1b360a02cb893a7cf784b2ec8fa9 [INFO] sha for GitHub repo ygree/rust_examples: 45f23c23ef3c1b360a02cb893a7cf784b2ec8fa9 [INFO] validating manifest of ygree/rust_examples on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ygree/rust_examples on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ygree/rust_examples [INFO] finished frobbing ygree/rust_examples [INFO] frobbed toml for ygree/rust_examples written to work/ex/clippy-test-run/sources/stable/gh/ygree/rust_examples/Cargo.toml [INFO] started frobbing ygree/rust_examples [INFO] finished frobbing ygree/rust_examples [INFO] frobbed toml for ygree/rust_examples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ygree/rust_examples/Cargo.toml [INFO] crate ygree/rust_examples has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ygree/rust_examples against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ygree/rust_examples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0cc64934efc385723152e24cedbc618f4d0900661f0dd917beace5b1f4c28b48 [INFO] running `"docker" "start" "-a" "0cc64934efc385723152e24cedbc618f4d0900661f0dd917beace5b1f4c28b48"` [INFO] [stderr] Checking libc v0.2.35 [INFO] [stderr] Checking rust_examples v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/heap_sort.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / if child_i < xs.len() { [INFO] [stderr] 25 | | if xs[child_i] > xs[i] { [INFO] [stderr] 26 | | xs.swap(i, child_i); [INFO] [stderr] 27 | | shift_down(xs, child_i); [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | if child_i < xs.len() && xs[child_i] > xs[i] { [INFO] [stderr] 25 | xs.swap(i, child_i); [INFO] [stderr] 26 | shift_down(xs, child_i); [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `PriorityQueue` [INFO] [stderr] --> src/bin/heap_sort.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / pub fn new() -> PriorityQueue { [INFO] [stderr] 77 | | PriorityQueue { queue: Default::default() } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking rand v0.4.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking quickcheck v0.6.0 [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bin/heap_sort.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / if child_i < xs.len() { [INFO] [stderr] 25 | | if xs[child_i] > xs[i] { [INFO] [stderr] 26 | | xs.swap(i, child_i); [INFO] [stderr] 27 | | shift_down(xs, child_i); [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | if child_i < xs.len() && xs[child_i] > xs[i] { [INFO] [stderr] 25 | xs.swap(i, child_i); [INFO] [stderr] 26 | shift_down(xs, child_i); [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `PriorityQueue` [INFO] [stderr] --> src/bin/heap_sort.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / pub fn new() -> PriorityQueue { [INFO] [stderr] 77 | | PriorityQueue { queue: Default::default() } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.81s [INFO] running `"docker" "inspect" "0cc64934efc385723152e24cedbc618f4d0900661f0dd917beace5b1f4c28b48"` [INFO] running `"docker" "rm" "-f" "0cc64934efc385723152e24cedbc618f4d0900661f0dd917beace5b1f4c28b48"` [INFO] [stdout] 0cc64934efc385723152e24cedbc618f4d0900661f0dd917beace5b1f4c28b48