[INFO] updating cached repository yavrib/rust-tic-tac-toe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/yavrib/rust-tic-tac-toe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/yavrib/rust-tic-tac-toe" "work/ex/clippy-test-run/sources/stable/gh/yavrib/rust-tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yavrib/rust-tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/yavrib/rust-tic-tac-toe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/rust-tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/rust-tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d2051d3c7a219d04517350080360beb49482b6d1 [INFO] sha for GitHub repo yavrib/rust-tic-tac-toe: d2051d3c7a219d04517350080360beb49482b6d1 [INFO] validating manifest of yavrib/rust-tic-tac-toe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of yavrib/rust-tic-tac-toe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing yavrib/rust-tic-tac-toe [INFO] finished frobbing yavrib/rust-tic-tac-toe [INFO] frobbed toml for yavrib/rust-tic-tac-toe written to work/ex/clippy-test-run/sources/stable/gh/yavrib/rust-tic-tac-toe/Cargo.toml [INFO] started frobbing yavrib/rust-tic-tac-toe [INFO] finished frobbing yavrib/rust-tic-tac-toe [INFO] frobbed toml for yavrib/rust-tic-tac-toe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/rust-tic-tac-toe/Cargo.toml [INFO] crate yavrib/rust-tic-tac-toe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting yavrib/rust-tic-tac-toe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/rust-tic-tac-toe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fabaf849f4fc49b069fc2e79f94a8674ea1dc660fd67212b5ff24e073b93d60 [INFO] running `"docker" "start" "-a" "5fabaf849f4fc49b069fc2e79f94a8674ea1dc660fd67212b5ff24e073b93d60"` [INFO] [stderr] Checking tic-tac-toe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | println!("{:?}", game.player1.get(&String::from("Name")).unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player1[&String::from("Name")]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | if game.turn == String::from("player1") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:74:76 [INFO] [stderr] | [INFO] [stderr] 74 | if game.turn == String::from("player1") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | game.board[position] = game.player1.get(&String::from("Faction")).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player1[&String::from("Faction")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | } else if game.turn == String::from("player2") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:76:83 [INFO] [stderr] | [INFO] [stderr] 76 | } else if game.turn == String::from("player2") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | game.board[position] = game.player2.get(&String::from("Faction")).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player2[&String::from("Faction")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | if game.turn == String::from("player1") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:88:32 [INFO] [stderr] | [INFO] [stderr] 88 | } else if game.turn == String::from("player2") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:97:54 [INFO] [stderr] | [INFO] [stderr] 97 | } else if game.winner == String::from("Tie") { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 98 | | break; [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:95:149 [INFO] [stderr] | [INFO] [stderr] 95 | if (game.winner == *game.player1.get(&String::from("Name")).unwrap()) || (game.winner == *game.player2.get(&String::from("Name")).unwrap()) { [INFO] [stderr] | _____________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 96 | | break; [INFO] [stderr] 97 | | } else if game.winner == String::from("Tie") { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | if (game.winner == *game.player1.get(&String::from("Name")).unwrap()) || (game.winner == *game.player2.get(&String::from("Name")).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player1[&String::from("Name")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:95:99 [INFO] [stderr] | [INFO] [stderr] 95 | if (game.winner == *game.player1.get(&String::from("Name")).unwrap()) || (game.winner == *game.player2.get(&String::from("Name")).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player2[&String::from("Name")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:97:34 [INFO] [stderr] | [INFO] [stderr] 97 | } else if game.winner == String::from("Tie") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `"Tie"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tic-tac-toe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | println!("{:?}", game.player1.get(&String::from("Name")).unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player1[&String::from("Name")]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | if game.turn == String::from("player1") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player1"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:74:76 [INFO] [stderr] | [INFO] [stderr] 74 | if game.turn == String::from("player1") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | game.board[position] = game.player1.get(&String::from("Faction")).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player1[&String::from("Faction")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | } else if game.turn == String::from("player2") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:76:83 [INFO] [stderr] | [INFO] [stderr] 76 | } else if game.turn == String::from("player2") && game.board[position] == String::from("None") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | game.board[position] = game.player2.get(&String::from("Faction")).unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player2[&String::from("Faction")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | if game.turn == String::from("player1") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:88:32 [INFO] [stderr] | [INFO] [stderr] 88 | } else if game.turn == String::from("player2") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"player2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:97:54 [INFO] [stderr] | [INFO] [stderr] 97 | } else if game.winner == String::from("Tie") { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 98 | | break; [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:95:149 [INFO] [stderr] | [INFO] [stderr] 95 | if (game.winner == *game.player1.get(&String::from("Name")).unwrap()) || (game.winner == *game.player2.get(&String::from("Name")).unwrap()) { [INFO] [stderr] | _____________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] 96 | | break; [INFO] [stderr] 97 | | } else if game.winner == String::from("Tie") { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | if (game.winner == *game.player1.get(&String::from("Name")).unwrap()) || (game.winner == *game.player2.get(&String::from("Name")).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player1[&String::from("Name")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:95:99 [INFO] [stderr] | [INFO] [stderr] 95 | if (game.winner == *game.player1.get(&String::from("Name")).unwrap()) || (game.winner == *game.player2.get(&String::from("Name")).unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&game.player2[&String::from("Name")]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:97:34 [INFO] [stderr] | [INFO] [stderr] 97 | } else if game.winner == String::from("Tie") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `"Tie"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tic-tac-toe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5fabaf849f4fc49b069fc2e79f94a8674ea1dc660fd67212b5ff24e073b93d60"` [INFO] running `"docker" "rm" "-f" "5fabaf849f4fc49b069fc2e79f94a8674ea1dc660fd67212b5ff24e073b93d60"` [INFO] [stdout] 5fabaf849f4fc49b069fc2e79f94a8674ea1dc660fd67212b5ff24e073b93d60