[INFO] updating cached repository yavrib/adventofcode2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/yavrib/adventofcode2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/yavrib/adventofcode2018" "work/ex/clippy-test-run/sources/stable/gh/yavrib/adventofcode2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yavrib/adventofcode2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/yavrib/adventofcode2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/adventofcode2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/adventofcode2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d8ed473fa51c4f7eca244bed33c44f2fc7fa7e29
[INFO] sha for GitHub repo yavrib/adventofcode2018: d8ed473fa51c4f7eca244bed33c44f2fc7fa7e29
[INFO] validating manifest of yavrib/adventofcode2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of yavrib/adventofcode2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing yavrib/adventofcode2018
[INFO] finished frobbing yavrib/adventofcode2018
[INFO] frobbed toml for yavrib/adventofcode2018 written to work/ex/clippy-test-run/sources/stable/gh/yavrib/adventofcode2018/Cargo.toml
[INFO] started frobbing yavrib/adventofcode2018
[INFO] finished frobbing yavrib/adventofcode2018
[INFO] frobbed toml for yavrib/adventofcode2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/adventofcode2018/Cargo.toml
[INFO] crate yavrib/adventofcode2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting yavrib/adventofcode2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yavrib/adventofcode2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 41a1a502f2acf49a6ee01d49eb611091f9c032a9cf3689b4424b082741b983fb
[INFO] running `"docker" "start" "-a" "41a1a502f2acf49a6ee01d49eb611091f9c032a9cf3689b4424b082741b983fb"`
[INFO] [stderr]     Checking adventofcode2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/first.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return (&add, number);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&add, number)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/first.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return (&subtract, number);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&subtract, number)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/first.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return (&add, number);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&add, number)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/first.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return (&subtract, number);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&subtract, number)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/solutions/first.rs:7:55
[INFO] [stderr]   |
[INFO] [stderr] 7 |   let changes: Vec<&str> = changes_in_frequency.split("\n").collect();
[INFO] [stderr]   |                                                       ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]  --> src/solutions/first.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 |   let new_values: Vec<(&Fn(i64, i64) -> i64, Result<i64, ParseIntError>)> = changes
[INFO] [stderr]   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solutions/first.rs:26:20
[INFO] [stderr]    |
[INFO] [stderr] 26 |   if s.starts_with("+") {
[INFO] [stderr]    |                    ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solutions/first.rs:27:48
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let string_collection: Vec<&str> = s.split("+").collect();
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solutions/first.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let string_collection: Vec<&str> = s.split("-").collect();
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/solutions/first.rs:7:55
[INFO] [stderr]   |
[INFO] [stderr] 7 |   let changes: Vec<&str> = changes_in_frequency.split("\n").collect();
[INFO] [stderr]   |                                                       ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]  --> src/solutions/first.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 |   let new_values: Vec<(&Fn(i64, i64) -> i64, Result<i64, ParseIntError>)> = changes
[INFO] [stderr]   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solutions/first.rs:26:20
[INFO] [stderr]    |
[INFO] [stderr] 26 |   if s.starts_with("+") {
[INFO] [stderr]    |                    ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solutions/first.rs:27:48
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let string_collection: Vec<&str> = s.split("+").collect();
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'+'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solutions/first.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let string_collection: Vec<&str> = s.split("-").collect();
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.60s
[INFO] running `"docker" "inspect" "41a1a502f2acf49a6ee01d49eb611091f9c032a9cf3689b4424b082741b983fb"`
[INFO] running `"docker" "rm" "-f" "41a1a502f2acf49a6ee01d49eb611091f9c032a9cf3689b4424b082741b983fb"`
[INFO] [stdout] 41a1a502f2acf49a6ee01d49eb611091f9c032a9cf3689b4424b082741b983fb