[INFO] updating cached repository yati-sagade/cabl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/yati-sagade/cabl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/yati-sagade/cabl" "work/ex/clippy-test-run/sources/stable/gh/yati-sagade/cabl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/yati-sagade/cabl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/yati-sagade/cabl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yati-sagade/cabl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yati-sagade/cabl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] acb507934928d39ce6f94eaf1dd5642a58a5d6e4
[INFO] sha for GitHub repo yati-sagade/cabl: acb507934928d39ce6f94eaf1dd5642a58a5d6e4
[INFO] validating manifest of yati-sagade/cabl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of yati-sagade/cabl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing yati-sagade/cabl
[INFO] finished frobbing yati-sagade/cabl
[INFO] frobbed toml for yati-sagade/cabl written to work/ex/clippy-test-run/sources/stable/gh/yati-sagade/cabl/Cargo.toml
[INFO] started frobbing yati-sagade/cabl
[INFO] finished frobbing yati-sagade/cabl
[INFO] frobbed toml for yati-sagade/cabl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yati-sagade/cabl/Cargo.toml
[INFO] crate yati-sagade/cabl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting yati-sagade/cabl against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/yati-sagade/cabl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f70ec43db0054e8b0816efe40245901e815d820dc4b632cbf5f9b179f50075f2
[INFO] running `"docker" "start" "-a" "f70ec43db0054e8b0816efe40245901e815d820dc4b632cbf5f9b179f50075f2"`
[INFO] [stderr]     Checking cabl v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:20:31
[INFO] [stderr]    |
[INFO] [stderr] 20 |         let mut cabl = Cabl { stream:  stream,
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:20:31
[INFO] [stderr]    |
[INFO] [stderr] 20 |         let mut cabl = Cabl { stream:  stream,
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `emit`
[INFO] [stderr]   --> src/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     fn emit(&self, msg: &str) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:44:23
[INFO] [stderr]    |
[INFO] [stderr] 44 |             self.look.ok_or(String::from("Inconsistent state"))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| String::from("Inconsistent state"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:54:23
[INFO] [stderr]    |
[INFO] [stderr] 54 |             self.look.ok_or(String::from("Inconsistent state"))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| String::from("Inconsistent state"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:81:26
[INFO] [stderr]    |
[INFO] [stderr] 81 |             self.emitln(&format!("push eax")); // put the numer in ebx
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"push eax".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:97:26
[INFO] [stderr]    |
[INFO] [stderr] 97 |             self.emitln(&format!("push eax"));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"push eax".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: method `Match` should have a snake case name such as `match`
[INFO] [stderr]    --> src/lib.rs:190:5
[INFO] [stderr]     |
[INFO] [stderr] 190 | /     fn Match(&mut self, c: char) -> Result<()> {
[INFO] [stderr] 191 | |         match self.look {
[INFO] [stderr] 192 | |             Some(v) if v == c => {
[INFO] [stderr] 193 | |                 self.read_next_char();
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |         }
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:236:12
[INFO] [stderr]     |
[INFO] [stderr] 236 |         if self.vardefs.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.vardefs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:246:9
[INFO] [stderr]     |
[INFO] [stderr] 246 | /         match result {
[INFO] [stderr] 247 | |             &Err(ref s) => {
[INFO] [stderr] 248 | |                 println!("\n{}\nAborting due to previous errors.", s);
[INFO] [stderr] 249 | |                 process::exit(1);
[INFO] [stderr] 250 | |             },
[INFO] [stderr] 251 | |             &Ok(_)      => { },
[INFO] [stderr] 252 | |         } 
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 246 |         match *result {
[INFO] [stderr] 247 |             Err(ref s) => {
[INFO] [stderr] 248 |                 println!("\n{}\nAborting due to previous errors.", s);
[INFO] [stderr] 249 |                 process::exit(1);
[INFO] [stderr] 250 |             },
[INFO] [stderr] 251 |             Ok(_)      => { },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `emit`
[INFO] [stderr]   --> src/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     fn emit(&self, msg: &str) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:44:23
[INFO] [stderr]    |
[INFO] [stderr] 44 |             self.look.ok_or(String::from("Inconsistent state"))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| String::from("Inconsistent state"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:54:23
[INFO] [stderr]    |
[INFO] [stderr] 54 |             self.look.ok_or(String::from("Inconsistent state"))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| String::from("Inconsistent state"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:81:26
[INFO] [stderr]    |
[INFO] [stderr] 81 |             self.emitln(&format!("push eax")); // put the numer in ebx
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"push eax".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:97:26
[INFO] [stderr]    |
[INFO] [stderr] 97 |             self.emitln(&format!("push eax"));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"push eax".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: method `Match` should have a snake case name such as `match`
[INFO] [stderr]    --> src/lib.rs:190:5
[INFO] [stderr]     |
[INFO] [stderr] 190 | /     fn Match(&mut self, c: char) -> Result<()> {
[INFO] [stderr] 191 | |         match self.look {
[INFO] [stderr] 192 | |             Some(v) if v == c => {
[INFO] [stderr] 193 | |                 self.read_next_char();
[INFO] [stderr] ...   |
[INFO] [stderr] 197 | |         }
[INFO] [stderr] 198 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:236:12
[INFO] [stderr]     |
[INFO] [stderr] 236 |         if self.vardefs.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.vardefs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:246:9
[INFO] [stderr]     |
[INFO] [stderr] 246 | /         match result {
[INFO] [stderr] 247 | |             &Err(ref s) => {
[INFO] [stderr] 248 | |                 println!("\n{}\nAborting due to previous errors.", s);
[INFO] [stderr] 249 | |                 process::exit(1);
[INFO] [stderr] 250 | |             },
[INFO] [stderr] 251 | |             &Ok(_)      => { },
[INFO] [stderr] 252 | |         } 
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 246 |         match *result {
[INFO] [stderr] 247 |             Err(ref s) => {
[INFO] [stderr] 248 |                 println!("\n{}\nAborting due to previous errors.", s);
[INFO] [stderr] 249 |                 process::exit(1);
[INFO] [stderr] 250 |             },
[INFO] [stderr] 251 |             Ok(_)      => { },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]  --> src/main.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         io::stdin().read_to_string(&mut s);
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]   = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]  --> src/main.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |         io::stdin().read_to_string(&mut s);
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]   = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.30s
[INFO] running `"docker" "inspect" "f70ec43db0054e8b0816efe40245901e815d820dc4b632cbf5f9b179f50075f2"`
[INFO] running `"docker" "rm" "-f" "f70ec43db0054e8b0816efe40245901e815d820dc4b632cbf5f9b179f50075f2"`
[INFO] [stdout] f70ec43db0054e8b0816efe40245901e815d820dc4b632cbf5f9b179f50075f2