[INFO] updating cached repository wridgers/wst [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wridgers/wst [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wridgers/wst" "work/ex/clippy-test-run/sources/stable/gh/wridgers/wst"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wridgers/wst'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wridgers/wst" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wridgers/wst"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wridgers/wst'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f0ce4ae6553193734fd37a8bffefc7fcabdd02ef [INFO] sha for GitHub repo wridgers/wst: f0ce4ae6553193734fd37a8bffefc7fcabdd02ef [INFO] validating manifest of wridgers/wst on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wridgers/wst on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wridgers/wst [INFO] finished frobbing wridgers/wst [INFO] frobbed toml for wridgers/wst written to work/ex/clippy-test-run/sources/stable/gh/wridgers/wst/Cargo.toml [INFO] started frobbing wridgers/wst [INFO] finished frobbing wridgers/wst [INFO] frobbed toml for wridgers/wst written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wridgers/wst/Cargo.toml [INFO] crate wridgers/wst has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wridgers/wst against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wridgers/wst:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70834799ffdb92cd21eb2dff9ddeecbcf361a5b9ca4826e5e5a8586280986cbc [INFO] running `"docker" "start" "-a" "70834799ffdb92cd21eb2dff9ddeecbcf361a5b9ca4826e5e5a8586280986cbc"` [INFO] [stderr] Checking sha1 v0.2.0 [INFO] [stderr] Checking httparse v1.2.3 [INFO] [stderr] Checking getopts v0.2.15 [INFO] [stderr] Checking iovec v0.1.1 [INFO] [stderr] Checking rand v0.3.18 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Checking url v1.6.0 [INFO] [stderr] Checking ws v0.7.3 [INFO] [stderr] Checking wst v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:131:21 [INFO] [stderr] | [INFO] [stderr] 131 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:131:21 [INFO] [stderr] | [INFO] [stderr] 131 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/buffer.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / if self.length > 0 { [INFO] [stderr] 22 | | if self.buffer.len() > self.header + self.length { [INFO] [stderr] 23 | | self.buffer.remove(self.header); [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | if self.length > 0 && self.buffer.len() > self.header + self.length { [INFO] [stderr] 22 | self.buffer.remove(self.header); [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/buffer.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / if self.length > 0 { [INFO] [stderr] 22 | | if self.buffer.len() > self.header + self.length { [INFO] [stderr] 23 | | self.buffer.remove(self.header); [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | if self.length > 0 && self.buffer.len() > self.header + self.length { [INFO] [stderr] 22 | self.buffer.remove(self.header); [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.59s [INFO] running `"docker" "inspect" "70834799ffdb92cd21eb2dff9ddeecbcf361a5b9ca4826e5e5a8586280986cbc"` [INFO] running `"docker" "rm" "-f" "70834799ffdb92cd21eb2dff9ddeecbcf361a5b9ca4826e5e5a8586280986cbc"` [INFO] [stdout] 70834799ffdb92cd21eb2dff9ddeecbcf361a5b9ca4826e5e5a8586280986cbc