[INFO] updating cached repository workingJ/dh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/workingJ/dh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/workingJ/dh" "work/ex/clippy-test-run/sources/stable/gh/workingJ/dh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/workingJ/dh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/workingJ/dh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/workingJ/dh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/workingJ/dh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 882a60f904816097d8ba1cdf9534bf5ec7afa4da [INFO] sha for GitHub repo workingJ/dh: 882a60f904816097d8ba1cdf9534bf5ec7afa4da [INFO] validating manifest of workingJ/dh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of workingJ/dh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing workingJ/dh [INFO] finished frobbing workingJ/dh [INFO] frobbed toml for workingJ/dh written to work/ex/clippy-test-run/sources/stable/gh/workingJ/dh/Cargo.toml [INFO] started frobbing workingJ/dh [INFO] finished frobbing workingJ/dh [INFO] frobbed toml for workingJ/dh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/workingJ/dh/Cargo.toml [INFO] crate workingJ/dh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting workingJ/dh against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/workingJ/dh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c3921cbe92068bb25e5e189c95c59e2397fdf8ac35ea81f033c3164351f0153 [INFO] running `"docker" "start" "-a" "9c3921cbe92068bb25e5e189c95c59e2397fdf8ac35ea81f033c3164351f0153"` [INFO] [stderr] Checking dh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const CONFIG_FILE: &'static str = "help.hlp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const CONFIG_FILE: &'static str = "help.hlp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:30:8 [INFO] [stderr] | [INFO] [stderr] 30 | if contains == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `contains` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:30:8 [INFO] [stderr] | [INFO] [stderr] 30 | if contains == true{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `contains` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "9c3921cbe92068bb25e5e189c95c59e2397fdf8ac35ea81f033c3164351f0153"` [INFO] running `"docker" "rm" "-f" "9c3921cbe92068bb25e5e189c95c59e2397fdf8ac35ea81f033c3164351f0153"` [INFO] [stdout] 9c3921cbe92068bb25e5e189c95c59e2397fdf8ac35ea81f033c3164351f0153