[INFO] updating cached repository wlinna/video_splitter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wlinna/video_splitter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wlinna/video_splitter" "work/ex/clippy-test-run/sources/stable/gh/wlinna/video_splitter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wlinna/video_splitter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wlinna/video_splitter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wlinna/video_splitter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wlinna/video_splitter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9cac7ce3c7693cc9e6ac00c6a6c04c27d8a27f45 [INFO] sha for GitHub repo wlinna/video_splitter: 9cac7ce3c7693cc9e6ac00c6a6c04c27d8a27f45 [INFO] validating manifest of wlinna/video_splitter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wlinna/video_splitter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wlinna/video_splitter [INFO] finished frobbing wlinna/video_splitter [INFO] frobbed toml for wlinna/video_splitter written to work/ex/clippy-test-run/sources/stable/gh/wlinna/video_splitter/Cargo.toml [INFO] started frobbing wlinna/video_splitter [INFO] finished frobbing wlinna/video_splitter [INFO] frobbed toml for wlinna/video_splitter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wlinna/video_splitter/Cargo.toml [INFO] crate wlinna/video_splitter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wlinna/video_splitter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wlinna/video_splitter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb2ea6585ef99934062666b6c29cdb7b9b7c8b552cc6860aa206ee0d97804fb0 [INFO] running `"docker" "start" "-a" "bb2ea6585ef99934062666b6c29cdb7b9b7c8b552cc6860aa206ee0d97804fb0"` [INFO] [stderr] Checking video_splitter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `text` [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let text = read_file_to_string(split_info_path); [INFO] [stderr] | ^^^^ help: consider using `_text` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / match file.read_to_string(&mut s) { [INFO] [stderr] 20 | | Err(why) => panic!("Couldn't read {}: {}", [INFO] [stderr] 21 | | display, Error::description(&why)), [INFO] [stderr] 22 | | Ok(_) => {} [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | if let Err(why) = file.read_to_string(&mut s) { panic!("Couldn't read {}: {}", [INFO] [stderr] 20 | display, Error::description(&why)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if !metadata(split_info_path).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(split_info_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused variable: `text` [INFO] [stderr] --> src/main.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let text = read_file_to_string(split_info_path); [INFO] [stderr] | ^^^^ help: consider using `_text` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / match file.read_to_string(&mut s) { [INFO] [stderr] 20 | | Err(why) => panic!("Couldn't read {}: {}", [INFO] [stderr] 21 | | display, Error::description(&why)), [INFO] [stderr] 22 | | Ok(_) => {} [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | if let Err(why) = file.read_to_string(&mut s) { panic!("Couldn't read {}: {}", [INFO] [stderr] 20 | display, Error::description(&why)) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if !metadata(split_info_path).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata(split_info_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `"docker" "inspect" "bb2ea6585ef99934062666b6c29cdb7b9b7c8b552cc6860aa206ee0d97804fb0"` [INFO] running `"docker" "rm" "-f" "bb2ea6585ef99934062666b6c29cdb7b9b7c8b552cc6860aa206ee0d97804fb0"` [INFO] [stdout] bb2ea6585ef99934062666b6c29cdb7b9b7c8b552cc6860aa206ee0d97804fb0