[INFO] updating cached repository wjt/adventofcode2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wjt/adventofcode2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wjt/adventofcode2018" "work/ex/clippy-test-run/sources/stable/gh/wjt/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wjt/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wjt/adventofcode2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjt/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjt/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b47d4cadcfe7e6c70fd898f2556f375e2c0d382 [INFO] sha for GitHub repo wjt/adventofcode2018: 0b47d4cadcfe7e6c70fd898f2556f375e2c0d382 [INFO] validating manifest of wjt/adventofcode2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wjt/adventofcode2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wjt/adventofcode2018 [INFO] finished frobbing wjt/adventofcode2018 [INFO] frobbed toml for wjt/adventofcode2018 written to work/ex/clippy-test-run/sources/stable/gh/wjt/adventofcode2018/Cargo.toml [INFO] started frobbing wjt/adventofcode2018 [INFO] finished frobbing wjt/adventofcode2018 [INFO] frobbed toml for wjt/adventofcode2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjt/adventofcode2018/Cargo.toml [INFO] crate wjt/adventofcode2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wjt/adventofcode2018 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjt/adventofcode2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d86c48834959924fc2424249c36484524cb5256e92a9b5ea9e8bd5d4d15440f5 [INFO] running `"docker" "start" "-a" "d86c48834959924fc2424249c36484524cb5256e92a9b5ea9e8bd5d4d15440f5"` [INFO] [stderr] Checking adventofcode2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/day2.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | for (_c, count) in &counts { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 19 | for count in counts.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day3.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return Claim { elf, x, y, w, h }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Claim { elf, x, y, w, h }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day3.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return self.x..(self.x+self.w); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x..(self.x+self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day3.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return self.y..(self.y+self.h); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y..(self.y+self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day4.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return (min, *frequency); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(min, *frequency)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day3.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return Claim { elf, x, y, w, h }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Claim { elf, x, y, w, h }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day3.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return self.x..(self.x+self.w); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x..(self.x+self.w)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day3.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return self.y..(self.y+self.h); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y..(self.y+self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day4.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return (min, *frequency); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(min, *frequency)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day1.rs:1029:10 [INFO] [stderr] | [INFO] [stderr] 1029 | -137490, [INFO] [stderr] | ^^^^^^ help: consider: `137_490` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/day2.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | for (_c, count) in &counts { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 19 | for count in counts.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day1.rs:1029:10 [INFO] [stderr] | [INFO] [stderr] 1029 | -137490, [INFO] [stderr] | ^^^^^^ help: consider: `137_490` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.86s [INFO] running `"docker" "inspect" "d86c48834959924fc2424249c36484524cb5256e92a9b5ea9e8bd5d4d15440f5"` [INFO] running `"docker" "rm" "-f" "d86c48834959924fc2424249c36484524cb5256e92a9b5ea9e8bd5d4d15440f5"` [INFO] [stdout] d86c48834959924fc2424249c36484524cb5256e92a9b5ea9e8bd5d4d15440f5