[INFO] updating cached repository wjlroe/devbox
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/wjlroe/devbox
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/wjlroe/devbox" "work/ex/clippy-test-run/sources/stable/gh/wjlroe/devbox"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wjlroe/devbox'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/wjlroe/devbox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/devbox"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/devbox'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 46f37f7db9ccce9e5c2ea6c09e704bd82a24c264
[INFO] sha for GitHub repo wjlroe/devbox: 46f37f7db9ccce9e5c2ea6c09e704bd82a24c264
[INFO] validating manifest of wjlroe/devbox on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of wjlroe/devbox on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing wjlroe/devbox
[INFO] finished frobbing wjlroe/devbox
[INFO] frobbed toml for wjlroe/devbox written to work/ex/clippy-test-run/sources/stable/gh/wjlroe/devbox/Cargo.toml
[INFO] started frobbing wjlroe/devbox
[INFO] finished frobbing wjlroe/devbox
[INFO] frobbed toml for wjlroe/devbox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/devbox/Cargo.toml
[INFO] crate wjlroe/devbox has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting wjlroe/devbox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/devbox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b34c77fc0957ff43aa3f260fcde303ccb7461211fa269ae70ed935605c7ff083
[INFO] running `"docker" "start" "-a" "b34c77fc0957ff43aa3f260fcde303ccb7461211fa269ae70ed935605c7ff083"`
[INFO] [stderr]     Checking devbox v0.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/vscode.rs:63:14
[INFO] [stderr]    |
[INFO] [stderr] 63 |         .map(|s| String::from(s))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/vscode.rs:63:18
[INFO] [stderr]    |
[INFO] [stderr] 63 |         .map(|s| String::from(s))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/vscode.rs:92:48
[INFO] [stderr]    |
[INFO] [stderr] 92 |             line.split_whitespace().nth(0).map(|s| String::from(s))
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/vscode.rs:109:38
[INFO] [stderr]     |
[INFO] [stderr] 109 |         .map(|var| env::var(var).map(|home| PathBuf::from(home)))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/vscode.rs:115:72
[INFO] [stderr]     |
[INFO] [stderr] 115 |       let config = find_file_in(find_home_dir(), ".vscode_required.txt").ok_or(
[INFO] [stderr]     |  ________________________________________________________________________^
[INFO] [stderr] 116 | |         ErrString::new(format!(
[INFO] [stderr] 117 | |             "Couldn't find .vscode_required in a home dir!"
[INFO] [stderr] 118 | |         )),
[INFO] [stderr] 119 | |     )?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let config = find_file_in(find_home_dir(), ".vscode_required.txt").ok_or_else(|| ErrString::new(format!(
[INFO] [stderr] 116 |             "Couldn't find .vscode_required in a home dir!"
[INFO] [stderr] 117 |         )))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/vscode.rs:116:24
[INFO] [stderr]     |
[INFO] [stderr] 116 |           ErrString::new(format!(
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 117 | |             "Couldn't find .vscode_required in a home dir!"
[INFO] [stderr] 118 | |         )),
[INFO] [stderr]     | |_________^ help: consider using .to_string(): `"Couldn't find .vscode_required in a home dir!".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/vscode.rs:126:28
[INFO] [stderr]     |
[INFO] [stderr] 126 |         Err(ErrString::new(format!("Config doesn't exist")).into())
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Config doesn't exist".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/vscode.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 | /     let _ = required_packages()
[INFO] [stderr] 132 | |         .map(|packages| {
[INFO] [stderr] 133 | |             println!("we have {} required packages", packages.len());
[INFO] [stderr] 134 | |             ensure_installed(packages);
[INFO] [stderr] 135 | |         }).expect("oh no, required packages didn't work");
[INFO] [stderr]     | |__________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/vscode.rs:63:14
[INFO] [stderr]    |
[INFO] [stderr] 63 |         .map(|s| String::from(s))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/vscode.rs:63:18
[INFO] [stderr]    |
[INFO] [stderr] 63 |         .map(|s| String::from(s))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/vscode.rs:92:48
[INFO] [stderr]    |
[INFO] [stderr] 92 |             line.split_whitespace().nth(0).map(|s| String::from(s))
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/vscode.rs:109:38
[INFO] [stderr]     |
[INFO] [stderr] 109 |         .map(|var| env::var(var).map(|home| PathBuf::from(home)))
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/vscode.rs:115:72
[INFO] [stderr]     |
[INFO] [stderr] 115 |       let config = find_file_in(find_home_dir(), ".vscode_required.txt").ok_or(
[INFO] [stderr]     |  ________________________________________________________________________^
[INFO] [stderr] 116 | |         ErrString::new(format!(
[INFO] [stderr] 117 | |             "Couldn't find .vscode_required in a home dir!"
[INFO] [stderr] 118 | |         )),
[INFO] [stderr] 119 | |     )?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 115 |     let config = find_file_in(find_home_dir(), ".vscode_required.txt").ok_or_else(|| ErrString::new(format!(
[INFO] [stderr] 116 |             "Couldn't find .vscode_required in a home dir!"
[INFO] [stderr] 117 |         )))?;
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/vscode.rs:116:24
[INFO] [stderr]     |
[INFO] [stderr] 116 |           ErrString::new(format!(
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 117 | |             "Couldn't find .vscode_required in a home dir!"
[INFO] [stderr] 118 | |         )),
[INFO] [stderr]     | |_________^ help: consider using .to_string(): `"Couldn't find .vscode_required in a home dir!".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/vscode.rs:126:28
[INFO] [stderr]     |
[INFO] [stderr] 126 |         Err(ErrString::new(format!("Config doesn't exist")).into())
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Config doesn't exist".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/vscode.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 | /     let _ = required_packages()
[INFO] [stderr] 132 | |         .map(|packages| {
[INFO] [stderr] 133 | |             println!("we have {} required packages", packages.len());
[INFO] [stderr] 134 | |             ensure_installed(packages);
[INFO] [stderr] 135 | |         }).expect("oh no, required packages didn't work");
[INFO] [stderr]     | |__________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.99s
[INFO] running `"docker" "inspect" "b34c77fc0957ff43aa3f260fcde303ccb7461211fa269ae70ed935605c7ff083"`
[INFO] running `"docker" "rm" "-f" "b34c77fc0957ff43aa3f260fcde303ccb7461211fa269ae70ed935605c7ff083"`
[INFO] [stdout] b34c77fc0957ff43aa3f260fcde303ccb7461211fa269ae70ed935605c7ff083