[INFO] updating cached repository wjlroe/bim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wjlroe/bim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wjlroe/bim" "work/ex/clippy-test-run/sources/stable/gh/wjlroe/bim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wjlroe/bim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wjlroe/bim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/bim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/bim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 643df080fbf0100c25f365242fd6dcec7280d77c [INFO] sha for GitHub repo wjlroe/bim: 643df080fbf0100c25f365242fd6dcec7280d77c [INFO] validating manifest of wjlroe/bim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wjlroe/bim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wjlroe/bim [INFO] finished frobbing wjlroe/bim [INFO] frobbed toml for wjlroe/bim written to work/ex/clippy-test-run/sources/stable/gh/wjlroe/bim/Cargo.toml [INFO] started frobbing wjlroe/bim [INFO] finished frobbing wjlroe/bim [INFO] frobbed toml for wjlroe/bim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/bim/Cargo.toml [INFO] crate wjlroe/bim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wjlroe/bim against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wjlroe/bim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c254a82a49f9d5cb4e50adc33f7c48f3895421b7ae820b27f6c12d053597c5f [INFO] running `"docker" "start" "-a" "4c254a82a49f9d5cb4e50adc33f7c48f3895421b7ae820b27f6c12d053597c5f"` [INFO] [stderr] Checking errno v0.2.4 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking bim v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/row.rs:407:5 [INFO] [stderr] | [INFO] [stderr] 407 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/row.rs:407:5 [INFO] [stderr] | [INFO] [stderr] 407 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/row.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 185 | | if c == '\'' || c == '"' { [INFO] [stderr] 186 | | in_string = Some(c); [INFO] [stderr] 187 | | cur_hl = Some(String); [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 184 | } else if c == '\'' || c == '"' { [INFO] [stderr] 185 | in_string = Some(c); [INFO] [stderr] 186 | cur_hl = Some(String); [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/row.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | / if syntax.highlight_numbers() && cur_hl.is_none() { [INFO] [stderr] 193 | | if (c.is_digit(10) && (prev_sep || prev_hl == Number)) [INFO] [stderr] 194 | | || (c == '.' && prev_hl == Number) [INFO] [stderr] 195 | | { [INFO] [stderr] 196 | | cur_hl = Some(Number); [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if syntax.highlight_numbers() && cur_hl.is_none() && ((c.is_digit(10) && (prev_sep || prev_hl == Number)) [INFO] [stderr] 193 | || (c == '.' && prev_hl == Number)) { [INFO] [stderr] 194 | cur_hl = Some(Number); [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/row.rs:184:24 [INFO] [stderr] | [INFO] [stderr] 184 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 185 | | if c == '\'' || c == '"' { [INFO] [stderr] 186 | | in_string = Some(c); [INFO] [stderr] 187 | | cur_hl = Some(String); [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 184 | } else if c == '\'' || c == '"' { [INFO] [stderr] 185 | in_string = Some(c); [INFO] [stderr] 186 | cur_hl = Some(String); [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/row.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | / if syntax.highlight_numbers() && cur_hl.is_none() { [INFO] [stderr] 193 | | if (c.is_digit(10) && (prev_sep || prev_hl == Number)) [INFO] [stderr] 194 | | || (c == '.' && prev_hl == Number) [INFO] [stderr] 195 | | { [INFO] [stderr] 196 | | cur_hl = Some(Number); [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if syntax.highlight_numbers() && cur_hl.is_none() && ((c.is_digit(10) && (prev_sep || prev_hl == Number)) [INFO] [stderr] 193 | || (c == '.' && prev_hl == Number)) { [INFO] [stderr] 194 | cur_hl = Some(Number); [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/unix.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | Terminal::new(ws.ws_col as i32, ws.ws_row as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(ws.ws_col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/unix.rs:52:49 [INFO] [stderr] | [INFO] [stderr] 52 | Terminal::new(ws.ws_col as i32, ws.ws_row as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(ws.ws_row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/unix.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | stdout().write(b"\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | if buf[i] == 'R' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'R' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | buf[i] = '\0' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if buf[0] != '\x1b' as u8 || buf[1] != '[' as u8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\x1b' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:87:52 [INFO] [stderr] | [INFO] [stderr] 87 | if buf[0] != '\x1b' as u8 || buf[1] != '[' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'[' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unix.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | let mut raw = ORIG_TERMIOS.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ORIG_TERMIOS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/buffer.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | .unwrap_or(DEFAULT_NEWLINE.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_NEWLINE.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match self { [INFO] [stderr] 12 | | &SearchDirection::Forwards => write!(f, "Forwards"), [INFO] [stderr] 13 | | &SearchDirection::Backwards => write!(f, "Backwards"), [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 11 | match *self { [INFO] [stderr] 12 | SearchDirection::Forwards => write!(f, "Forwards"), [INFO] [stderr] 13 | SearchDirection::Backwards => write!(f, "Backwards"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/row.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | self.render[0..at + 1].chars().count() - 1 [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/syntax.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/syntax.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax.rs:106:16 [INFO] [stderr] | [INFO] [stderr] 106 | && self.singleline_comment_start.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.singleline_comment_start.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | && self.multiline_comment_start.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.multiline_comment_start.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | && self.multiline_comment_end.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.multiline_comment_end.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/terminal.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | self.filename.clone().unwrap_or(String::from("[No Name]")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("[No Name]"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/terminal.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self.flush() { [INFO] [stderr] 175 | | Err(err) => { [INFO] [stderr] 176 | | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | _ => {} [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 174 | if let Err(err) = self.flush() { [INFO] [stderr] 175 | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/terminal.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | let _ = stdout().flush()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/terminal.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / match self.flush() { [INFO] [stderr] 243 | | Err(err) => { [INFO] [stderr] 244 | | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | _ => {} [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | if let Err(err) = self.flush() { [INFO] [stderr] 243 | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 244 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bim`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/unix.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | Terminal::new(ws.ws_col as i32, ws.ws_row as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(ws.ws_col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/unix.rs:52:49 [INFO] [stderr] | [INFO] [stderr] 52 | Terminal::new(ws.ws_col as i32, ws.ws_row as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(ws.ws_row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/unix.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | stdout().write(b"\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | if buf[i] == 'R' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'R' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | buf[i] = '\0' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | if buf[0] != '\x1b' as u8 || buf[1] != '[' as u8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\x1b' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/unix.rs:87:52 [INFO] [stderr] | [INFO] [stderr] 87 | if buf[0] != '\x1b' as u8 || buf[1] != '[' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'[' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unix.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | let mut raw = ORIG_TERMIOS.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ORIG_TERMIOS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/buffer.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | .unwrap_or(DEFAULT_NEWLINE.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| DEFAULT_NEWLINE.to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/buffer.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | let first_row = buffer.rows.get(0).clone().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `buffer.rows.get(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/buffer.rs:285:22 [INFO] [stderr] | [INFO] [stderr] 285 | .map(|r| r.as_str().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 285 | .map(|r| &(*r.as_str()).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 285 | .map(|r| &str::clone(r.as_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/buffer.rs:302:22 [INFO] [stderr] | [INFO] [stderr] 302 | .map(|r| r.as_str().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 302 | .map(|r| &(*r.as_str()).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 302 | .map(|r| &str::clone(r.as_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/buffer.rs:310:22 [INFO] [stderr] | [INFO] [stderr] 310 | .map(|r| r.rendered_str().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 310 | .map(|r| &(*r.rendered_str()).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 310 | .map(|r| &str::clone(r.rendered_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/buffer.rs:347:22 [INFO] [stderr] | [INFO] [stderr] 347 | .map(|r| r.as_str().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 347 | .map(|r| &(*r.as_str()).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 347 | .map(|r| &str::clone(r.as_str())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/commands.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match self { [INFO] [stderr] 12 | | &SearchDirection::Forwards => write!(f, "Forwards"), [INFO] [stderr] 13 | | &SearchDirection::Backwards => write!(f, "Backwards"), [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 11 | match *self { [INFO] [stderr] 12 | SearchDirection::Forwards => write!(f, "Forwards"), [INFO] [stderr] 13 | SearchDirection::Backwards => write!(f, "Backwards"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/row.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | self.render[0..at + 1].chars().count() - 1 [INFO] [stderr] | ^^^^^^^^^ help: use: `0..=at` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/syntax.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/syntax.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | .or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax.rs:106:16 [INFO] [stderr] | [INFO] [stderr] 106 | && self.singleline_comment_start.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.singleline_comment_start.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax.rs:111:16 [INFO] [stderr] | [INFO] [stderr] 111 | && self.multiline_comment_start.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.multiline_comment_start.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/syntax.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | && self.multiline_comment_end.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.multiline_comment_end.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/terminal.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | self.filename.clone().unwrap_or(String::from("[No Name]")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("[No Name]"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/terminal.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self.flush() { [INFO] [stderr] 175 | | Err(err) => { [INFO] [stderr] 176 | | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | _ => {} [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 174 | if let Err(err) = self.flush() { [INFO] [stderr] 175 | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/terminal.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | let _ = stdout().flush()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/terminal.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / match self.flush() { [INFO] [stderr] 243 | | Err(err) => { [INFO] [stderr] 244 | | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | _ => {} [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | if let Err(err) = self.flush() { [INFO] [stderr] 243 | panic!("oh no! flush failed: {:?}", err); [INFO] [stderr] 244 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bim`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4c254a82a49f9d5cb4e50adc33f7c48f3895421b7ae820b27f6c12d053597c5f"` [INFO] running `"docker" "rm" "-f" "4c254a82a49f9d5cb4e50adc33f7c48f3895421b7ae820b27f6c12d053597c5f"` [INFO] [stdout] 4c254a82a49f9d5cb4e50adc33f7c48f3895421b7ae820b27f6c12d053597c5f