[INFO] updating cached repository wismer/caesar-cipher [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wismer/caesar-cipher [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wismer/caesar-cipher" "work/ex/clippy-test-run/sources/stable/gh/wismer/caesar-cipher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wismer/caesar-cipher'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wismer/caesar-cipher" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wismer/caesar-cipher"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wismer/caesar-cipher'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cda2f26c1e779c0c72a97c4388eab53d6fb84041 [INFO] sha for GitHub repo wismer/caesar-cipher: cda2f26c1e779c0c72a97c4388eab53d6fb84041 [INFO] validating manifest of wismer/caesar-cipher on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wismer/caesar-cipher on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wismer/caesar-cipher [INFO] finished frobbing wismer/caesar-cipher [INFO] frobbed toml for wismer/caesar-cipher written to work/ex/clippy-test-run/sources/stable/gh/wismer/caesar-cipher/Cargo.toml [INFO] started frobbing wismer/caesar-cipher [INFO] finished frobbing wismer/caesar-cipher [INFO] frobbed toml for wismer/caesar-cipher written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wismer/caesar-cipher/Cargo.toml [INFO] crate wismer/caesar-cipher has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wismer/caesar-cipher against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wismer/caesar-cipher:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1d11cacbba5e4504f9eec514a3a12a197c1f66d52e0e8881e6fe3557fed8c57 [INFO] running `"docker" "start" "-a" "e1d11cacbba5e4504f9eec514a3a12a197c1f66d52e0e8881e6fe3557fed8c57"` [INFO] [stderr] Checking caesar-cipher v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub mod euler; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/euler/euler.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/euler/euler.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const EULER: [&'static str; 1] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 32 | | if actual + shift >= 25 { [INFO] [stderr] 33 | | crypted_pos = (actual + shift - 25) as usize; [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | crypted_pos = (actual + shift) as usize; [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | } else if actual + shift >= 25 { [INFO] [stderr] 32 | crypted_pos = (actual + shift - 25) as usize; [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | crypted_pos = (actual + shift) as usize; [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub mod euler; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/euler/euler.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/euler/euler.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const EULER: [&'static str; 1] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 32 | | if actual + shift >= 25 { [INFO] [stderr] 33 | | crypted_pos = (actual + shift - 25) as usize; [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | crypted_pos = (actual + shift) as usize; [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | } else if actual + shift >= 25 { [INFO] [stderr] 32 | crypted_pos = (actual + shift - 25) as usize; [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | crypted_pos = (actual + shift) as usize; [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `remainder` [INFO] [stderr] --> src/euler/euler.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | fn calculate_remainder(remainder: &mut i32) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_remainder` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/euler/euler.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut total_number = 0u64; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Neither` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Neither [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `calculate_remainder` [INFO] [stderr] --> src/euler/euler.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | fn calculate_remainder(remainder: &mut i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `line_total` [INFO] [stderr] --> src/euler/euler.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | fn line_total(line: &str) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/euler/euler.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `acc` [INFO] [stderr] --> src/euler/euler.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | None => acc + 0 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | &self.process(c, &mut crypted_message, shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.process(c, &mut crypted_message, shift);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | &self.process(c, &mut decoded_message, shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.process(c, &mut decoded_message, shift);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `remainder` [INFO] [stderr] --> src/euler/euler.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | fn calculate_remainder(remainder: &mut i32) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_remainder` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/euler/euler.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut total_number = 0u64; [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Neither` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Neither [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `calculate_remainder` [INFO] [stderr] --> src/euler/euler.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | fn calculate_remainder(remainder: &mut i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `line_total` [INFO] [stderr] --> src/euler/euler.rs:44:1 [INFO] [stderr] | [INFO] [stderr] 44 | fn line_total(line: &str) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/euler/euler.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `acc` [INFO] [stderr] --> src/euler/euler.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | None => acc + 0 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | &self.process(c, &mut crypted_message, shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.process(c, &mut crypted_message, shift);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | &self.process(c, &mut decoded_message, shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.process(c, &mut decoded_message, shift);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "e1d11cacbba5e4504f9eec514a3a12a197c1f66d52e0e8881e6fe3557fed8c57"` [INFO] running `"docker" "rm" "-f" "e1d11cacbba5e4504f9eec514a3a12a197c1f66d52e0e8881e6fe3557fed8c57"` [INFO] [stdout] e1d11cacbba5e4504f9eec514a3a12a197c1f66d52e0e8881e6fe3557fed8c57